Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-08 Thread Winston Chang
> > Now that I think about it some more, I think I can do the following: > > 1. In the DESCRIPTION file, remove "SystemRequirements: C++11". I believe > this field is used only for R CMD check, not for actually installing > packages. CRAN only runs R CMD check on r-oldrel, r-release, and r-devel,

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-07 Thread Iñaki Ucar
On Tue, 7 Feb 2023 at 01:50, Avraham Adler wrote: > > On Tue, Feb 7, 2023 at 12:10 AM Iñaki Ucar wrote: > > > > On Tue, 7 Feb 2023 at 00:09, Avraham Adler wrote: > > > > > > "If a package does have a src/Makevars[.win] file then also setting > > > the make variable ‘CXX_STD’ there is

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-07 Thread Vincent Dorie
This might be helpful. Using autoconf and ax_cxx_compile_stdcxx ( https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html) in package_root/tools/m4: configure.ac AC_PREREQ(2.64) AC_INIT(yourpackagename, 1.0, y...@email.com) AC_CONFIG_SRCDIR([src/main.cpp])

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Winston Chang
On Mon, Feb 6, 2023 at 6:44 PM Duncan Murdoch wrote: > On 06/02/2023 3:46 p.m., Winston Chang wrote: > > I recently submitted a package to CRAN with "SystemRequirements: C++11". > > This raises the following NOTE on R-devel, and I was asked to fix and > > resubmit: > > > > * checking C++

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Duncan Murdoch
On 06/02/2023 3:46 p.m., Winston Chang wrote: I recently submitted a package to CRAN with "SystemRequirements: C++11". This raises the following NOTE on R-devel, and I was asked to fix and resubmit: * checking C++ specification ... NOTE Specified C++11: please update to current default of

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Avraham Adler
On Tue, Feb 7, 2023 at 12:10 AM Iñaki Ucar wrote: > > On Tue, 7 Feb 2023 at 00:09, Avraham Adler wrote: > > > > "If a package does have a src/Makevars[.win] file then also setting > > the make variable ‘CXX_STD’ there is recommended," > > That doesn't refer to the SystemRequirements field. > >

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Iñaki Ucar
On Tue, 7 Feb 2023 at 00:09, Avraham Adler wrote: > > "If a package does have a src/Makevars[.win] file then also setting > the make variable ‘CXX_STD’ there is recommended," That doesn't refer to the SystemRequirements field. Iñaki > > Avi > > On Mon, Feb 6, 2023 at 10:58 PM Iñaki Ucar

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Avraham Adler
"If a package does have a src/Makevars[.win] file then also setting the make variable ‘CXX_STD’ there is recommended," Avi On Mon, Feb 6, 2023 at 10:58 PM Iñaki Ucar wrote: > > On Mon, 6 Feb 2023 at 23:27, Avraham Adler wrote: > > > > On Mon, Feb 6, 2023 at 9:46 PM Duncan Murdoch > > wrote:

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Iñaki Ucar
On Mon, 6 Feb 2023 at 23:27, Avraham Adler wrote: > > On Mon, Feb 6, 2023 at 9:46 PM Duncan Murdoch > wrote: > > > > On 06/02/2023 4:01 p.m., Duncan Murdoch wrote: > > > On 06/02/2023 3:46 p.m., Winston Chang wrote: > > >> I recently submitted a package to CRAN with "SystemRequirements: C++11".

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Avraham Adler
On Mon, Feb 6, 2023 at 9:46 PM Duncan Murdoch wrote: > > On 06/02/2023 4:01 p.m., Duncan Murdoch wrote: > > On 06/02/2023 3:46 p.m., Winston Chang wrote: > >> I recently submitted a package to CRAN with "SystemRequirements: C++11". > >> This raises the following NOTE on R-devel, and I was asked

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Ivan Krylov
В Mon, 6 Feb 2023 14:46:16 -0600 Winston Chang пишет: > 1. Remove "SystemRequirements: C++11" entirely. The problem with this > is that on systems with older versions of R (3.6 and below, I > believe), it may try to compile the package with an older C++ > standard, which will fail. > 2. Update

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Duncan Murdoch
On 06/02/2023 4:01 p.m., Duncan Murdoch wrote: On 06/02/2023 3:46 p.m., Winston Chang wrote: I recently submitted a package to CRAN with "SystemRequirements: C++11". This raises the following NOTE on R-devel, and I was asked to fix and resubmit: * checking C++ specification ... NOTE

Re: [R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Duncan Murdoch
On 06/02/2023 3:46 p.m., Winston Chang wrote: I recently submitted a package to CRAN with "SystemRequirements: C++11". This raises the following NOTE on R-devel, and I was asked to fix and resubmit: * checking C++ specification ... NOTE Specified C++11: please update to current default of

[R-pkg-devel] How to update "SystemRequirements: C++11"?

2023-02-06 Thread Winston Chang
I recently submitted a package to CRAN with "SystemRequirements: C++11". This raises the following NOTE on R-devel, and I was asked to fix and resubmit: * checking C++ specification ... NOTE Specified C++11: please update to current default of C++17 If I understand correctly, I have two