Re: [R-pkg-devel] Win-builder: Author field differs from that derived from Authors@R

2019-02-06 Thread Ivan Krylov
On Wed, 6 Feb 2019 15:23:00 +0100
Sebastian Meyer  wrote:

> The CRAN repository policy says:
> 
> > <...> This should be done with current R-patched or the current
> > release of R.  

Right. Time for me to update to R-3.5.2 to comply with the policy and
prevent other silly mistakes.

> Further to that, note that you are using a non-standard role ("con").
> See the details in help("person") for the roles used in the context
> of R packages: aut, com, ctr, ctb, cph, cre, dtc, fnd, ths, trl.

Ouch! My reading comprehension could have been better when I read that
part of help("person"). Indeed, I should have used "ctb" instead of
"con".

Additional thanks to Peter Dalgaard for spotting the same mistake and
to Dirk Eddelbuettel for the link to Debian packages of current release
of R.

-- 
Best regards,
Ivan

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] Win-builder: Author field differs from that derived from Authors@R

2019-02-06 Thread Sebastian Meyer
The DESCRIPTION's Author field is auto-generated from Authors@R during R
CMD build. You are right, the format has slightly changed since R 3.3.3
(e.g., support for ORCID ID).

The CRAN repository policy says:

> Uploads must be source tarballs created by R CMD build and following
> the PACKAGE_VERSION.tar.gz naming scheme. This should be done with
> current R-patched or the current release of R.

-> https://cran.r-project.org/web/packages/policies.html

Further to that, note that you are using a non-standard role ("con").
See the details in help("person") for the roles used in the context of R
packages: aut, com, ctr, ctb, cph, cre, dtc, fnd, ths, trl.

Cheers,

Sebastian


Am 06.02.19 um 13:26 schrieb Ivan Krylov:
> Hi!
> 
> I'm relying on Authors@R to generate the Author: and Maintainer:
> headers. When checking my package at win-builder using R-unstable, I
> got a NOTE that Author field differs from that derived from Authors@R:
> 
>>> Author: 'Miquel Garriga [aut, cph], Stefan Gerlach [aut, cph],
>>> Ion Vasilief [aut, cph], Alex Kargovsky [aut, cph], Knut Franke
>>> [cph], Alexander Semke [cph], Tilman Benkert [cph], Kasper Peeters
>>> [cph], Russell Standish [cph], Ivan Krylov [cre, cph]'
> 
>>> Authors@R: 'Miquel Garriga [aut, cph], Stefan Gerlach [aut, cph],
>>> Ion Vasilief [aut, cph], Alex Kargovsky [aut, cph], Knut Franke
>>> [con, cph], Alexander Semke [con, cph], Tilman Benkert [con, cph],
>>> Kasper Peeters [con, cph], Russell Standish [con, cph], Ivan Krylov
>>> [cre, cph]'
> 
> Link to full check output:
> https://win-builder.r-project.org/EWz9zWS0niO3/
> 
> The actual field from DESCRIPTION now looks like this:
> 
>>> Authors@R: c(person('Miquel', 'Garriga', email =
>>> 'gbmiq...@gmail.com', role = c('aut', 'cph')), person('Stefan',
>>> 'Gerlach', email = 'stefan.gerl...@uni-konstanz.de', role = c('aut',
>>> 'cph')), person('Ion', 'Vasilief', email = 'ion_vasil...@yahoo.fr',
>>> role = c('aut', 'cph')), person('Alex', 'Kargovsky', email =
>>> 'kargov...@yumr.phys.msu.su', role = c('aut', 'cph')),
>>> person('Knut', 'Franke', email = 'knut.fra...@gmx.de', role =
>>> c('con', 'cph')), person('Alexander', 'Semke', email =
>>> 'alexander.se...@web.de', role = c('con', 'cph')), person('Tilman',
>>> 'Benkert', email = 't...@gmx.net', role = c('con', 'cph')),
>>> person('Kasper', 'Peeters', email = 'kasper.peet...@aei.mpg.de',
>>> role = c('con', 'cph')), person('Russell', 'Standish', role =
>>> c('con', 'cph')), person('Ivan', 'Krylov', email =
>>> 'krylov.r...@gmail.com', role = c('cre', 'cph')))
> 
> The version of R I'm currently using is 3.3.3 (2017-03-06) from Debian
> stable, which might explain the differences in utils:::format.person.
> 
> What should I do to avoid the NOTE?
>

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] Win-builder: Author field differs from that derived from Authors@R

2019-02-06 Thread peter dalgaard
The difference is obviously in the "con" men. The definition of role="con" in 
the MARC code list is

Conservator [con]
A person or organization responsible for documenting, preserving, or treating 
printed or manuscript material, works of art, artifacts, or other media
UF Preservationist

Is this as intended?

-pd

> On 6 Feb 2019, at 13:26 , Ivan Krylov  wrote:
> 
> Hi!
> 
> I'm relying on Authors@R to generate the Author: and Maintainer:
> headers. When checking my package at win-builder using R-unstable, I
> got a NOTE that Author field differs from that derived from Authors@R:
> 
>>> Author: 'Miquel Garriga [aut, cph], Stefan Gerlach [aut, cph],
>>> Ion Vasilief [aut, cph], Alex Kargovsky [aut, cph], Knut Franke
>>> [cph], Alexander Semke [cph], Tilman Benkert [cph], Kasper Peeters
>>> [cph], Russell Standish [cph], Ivan Krylov [cre, cph]'
> 
>>> Authors@R: 'Miquel Garriga [aut, cph], Stefan Gerlach [aut, cph],
>>> Ion Vasilief [aut, cph], Alex Kargovsky [aut, cph], Knut Franke
>>> [con, cph], Alexander Semke [con, cph], Tilman Benkert [con, cph],
>>> Kasper Peeters [con, cph], Russell Standish [con, cph], Ivan Krylov
>>> [cre, cph]'
> 
> Link to full check output:
> https://win-builder.r-project.org/EWz9zWS0niO3/
> 
> The actual field from DESCRIPTION now looks like this:
> 
>>> Authors@R: c(person('Miquel', 'Garriga', email =
>>> 'gbmiq...@gmail.com', role = c('aut', 'cph')), person('Stefan',
>>> 'Gerlach', email = 'stefan.gerl...@uni-konstanz.de', role = c('aut',
>>> 'cph')), person('Ion', 'Vasilief', email = 'ion_vasil...@yahoo.fr',
>>> role = c('aut', 'cph')), person('Alex', 'Kargovsky', email =
>>> 'kargov...@yumr.phys.msu.su', role = c('aut', 'cph')),
>>> person('Knut', 'Franke', email = 'knut.fra...@gmx.de', role =
>>> c('con', 'cph')), person('Alexander', 'Semke', email =
>>> 'alexander.se...@web.de', role = c('con', 'cph')), person('Tilman',
>>> 'Benkert', email = 't...@gmx.net', role = c('con', 'cph')),
>>> person('Kasper', 'Peeters', email = 'kasper.peet...@aei.mpg.de',
>>> role = c('con', 'cph')), person('Russell', 'Standish', role =
>>> c('con', 'cph')), person('Ivan', 'Krylov', email =
>>> 'krylov.r...@gmail.com', role = c('cre', 'cph')))
> 
> The version of R I'm currently using is 3.3.3 (2017-03-06) from Debian
> stable, which might explain the differences in utils:::format.person.
> 
> What should I do to avoid the NOTE?
> 
> -- 
> Best regards,
> Ivan
> 
> __
> R-package-devel@r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-package-devel

-- 
Peter Dalgaard, Professor,
Center for Statistics, Copenhagen Business School
Solbjerg Plads 3, 2000 Frederiksberg, Denmark
Phone: (+45)38153501
Office: A 4.23
Email: pd@cbs.dk  Priv: pda...@gmail.com

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] Win-builder: Author field differs from that derived from Authors@R

2019-02-06 Thread Dirk Eddelbuettel


On 6 February 2019 at 15:26, Ivan Krylov wrote:
| The version of R I'm currently using is 3.3.3 (2017-03-06) from Debian
| stable, which might explain the differences in utils:::format.person.

In case you were unaware you _can_ get current R versions, now R 3.5.2, for
Debian stable thanks to the backports administered by Johannes Ranke -- see
http://cloud.r-project.org/bin/linux/debian/

I see no real reason for a package developer aiming for CRAN to use a
twice-outdated R version.

| What should I do to avoid the NOTE?

I suspect locale and sorting settings but I don't know for sure. In any case,
I would not start by debugging on an outdated R version.

Dirk

-- 
http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


[R-pkg-devel] Win-builder: Author field differs from that derived from Authors@R

2019-02-06 Thread Ivan Krylov
Hi!

I'm relying on Authors@R to generate the Author: and Maintainer:
headers. When checking my package at win-builder using R-unstable, I
got a NOTE that Author field differs from that derived from Authors@R:

>> Author: 'Miquel Garriga [aut, cph], Stefan Gerlach [aut, cph],
>> Ion Vasilief [aut, cph], Alex Kargovsky [aut, cph], Knut Franke
>> [cph], Alexander Semke [cph], Tilman Benkert [cph], Kasper Peeters
>> [cph], Russell Standish [cph], Ivan Krylov [cre, cph]'

>> Authors@R: 'Miquel Garriga [aut, cph], Stefan Gerlach [aut, cph],
>> Ion Vasilief [aut, cph], Alex Kargovsky [aut, cph], Knut Franke
>> [con, cph], Alexander Semke [con, cph], Tilman Benkert [con, cph],
>> Kasper Peeters [con, cph], Russell Standish [con, cph], Ivan Krylov
>> [cre, cph]'

Link to full check output:
https://win-builder.r-project.org/EWz9zWS0niO3/

The actual field from DESCRIPTION now looks like this:

>> Authors@R: c(person('Miquel', 'Garriga', email =
>> 'gbmiq...@gmail.com', role = c('aut', 'cph')), person('Stefan',
>> 'Gerlach', email = 'stefan.gerl...@uni-konstanz.de', role = c('aut',
>> 'cph')), person('Ion', 'Vasilief', email = 'ion_vasil...@yahoo.fr',
>> role = c('aut', 'cph')), person('Alex', 'Kargovsky', email =
>> 'kargov...@yumr.phys.msu.su', role = c('aut', 'cph')),
>> person('Knut', 'Franke', email = 'knut.fra...@gmx.de', role =
>> c('con', 'cph')), person('Alexander', 'Semke', email =
>> 'alexander.se...@web.de', role = c('con', 'cph')), person('Tilman',
>> 'Benkert', email = 't...@gmx.net', role = c('con', 'cph')),
>> person('Kasper', 'Peeters', email = 'kasper.peet...@aei.mpg.de',
>> role = c('con', 'cph')), person('Russell', 'Standish', role =
>> c('con', 'cph')), person('Ivan', 'Krylov', email =
>> 'krylov.r...@gmail.com', role = c('cre', 'cph')))

The version of R I'm currently using is 3.3.3 (2017-03-06) from Debian
stable, which might explain the differences in utils:::format.person.

What should I do to avoid the NOTE?

-- 
Best regards,
Ivan

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel