Hi,
On 25. 09. 19 19:43, Dominik Pantůček wrote:
>
> On 25. 09. 19 19:32, Ben Greenman wrote:
>>> Should I include a brief documentation in
>>> scribble-doc/scribblings/scribble/srcdoc.scrbl within the same PR as well?
>>
>> Yes!
>
> Btw, looking at the struct-doc and struct*-doc descriptions
On 25. 09. 19 19:32, Ben Greenman wrote:
>> Should I include a brief documentation in
>> scribble-doc/scribblings/scribble/srcdoc.scrbl within the same PR as well?
>
> Yes!
Btw, looking at the struct-doc and struct*-doc descriptions maybe I
should actually provide class-doc and class*-doc
> Should I include a brief documentation in
> scribble-doc/scribblings/scribble/srcdoc.scrbl within the same PR as well?
Yes!
And if there are tests for scribble/srcdoc, it'd be good to add some
for `class-doc` before merging
--
You received this message because you are subscribed to the
Hi,
thank you for the quick response.
On 25. 09. 19 17:11, Ben Greenman wrote:
> These changes look great. Can you open a pull request for the
> racket/scribble repo?
>
opened PR#212.
> It looks like:
> - `class?` would be a better contract than `any/c`
Definitely makes sense, as the result
These changes look great. Can you open a pull request for the
racket/scribble repo?
https://github.com/racket/scribble
Some comments below
> Also I implemented a simple defclass wrapper as a provide form named
> class-doc:
>
> class-doc syntax form
> (define-provide/doc-transformer
Hello,
as a heavy user of scribble/srcdoc I've always missed a defclass provide
form equivalent. Therefore I wanted to implement my own. I decided to
use thing-doc as a starting point and noticed that it raises misleading
message if id is not an identifier. Minimal working example follows.
6 matches
Mail list logo
