Re: [racket-users] Re: Typed Racket has lowered my performance

2017-12-03 Thread Sam Tobin-Hochstadt
Ok, looking more at the commit, I think this is not actually a bug anywhere, but really an unfortunate combination of things that I don't have an idea for improving at the moment. Sorry for not realizing that earlier. First, I think you should just go back to using `Any` in the type for `pack`

Re: [racket-users] Re: Typed Racket has lowered my performance

2017-12-03 Thread HiPhish
Anything more I can do? On Sunday, December 3, 2017 at 6:11:42 PM UTC+1, Sam Tobin-Hochstadt wrote: > > Thanks, that's very helpful. It's clear that the contract optimization is > working in the old code but not the new code, and we need to fix that. > -- You received this message because you

Re: [racket-users] plot and drracket: beautiful thing

2017-12-03 Thread Robby Findler
That is Neil Toronto for the plot library. It is a wonder! Robby On Sun, Dec 3, 2017 at 5:36 AM Robert Girault wrote: > To whomever is responsible for plot and DrRacket working together, this is > just to say that for a moment here I forgot I was using a Lisp. It

[racket-users] plot and drracket: beautiful thing

2017-12-03 Thread Robert Girault
To whomever is responsible for plot and DrRacket working together, this is just to say that for a moment here I forgot I was using a Lisp. It felt more like using a software completely devoted to graphing. I can zoom in? That's wild. Thanks! -- You received this message because you are

Re: [racket-users] Re: Typed Racket has lowered my performance

2017-12-03 Thread HiPhish
Is there anything I can do to help investigate the issue? I have reverted my commit for the time being, and it's a difference like day and night. On Sunday, December 3, 2017 at 12:36:16 AM UTC+1, Sam Tobin-Hochstadt wrote: > > I don't think the mutable/immutable issue should be as significant as

Re: [racket-users] Re: Typed Racket has lowered my performance

2017-12-03 Thread Sam Tobin-Hochstadt
Running the contract profiler [1] on your code would be quite helpful. [1] https://docs.racket-lang.org/contract-profile/index.html Sam On Sun, Dec 3, 2017 at 9:29 AM, HiPhish wrote: > Is there anything I can do to help investigate the issue? I have reverted my >

Re: [racket-users] Re: Typed Racket has lowered my performance

2017-12-03 Thread HiPhish
Here is what happens when I run one of the array tests with the more restrictive type specifications: OK, passed 100 tests. Running time is 70.75% contracts 75/106 ms (-> (recursive-contract (or/c (and/c hash? (and/c hash-equal ... 75 ms (lib msgpack/pack.rkt):24:9

Re: [racket-users] Re: Typed Racket has lowered my performance

2017-12-03 Thread Sam Tobin-Hochstadt
Thanks, that's very helpful. It's clear that the contract optimization is working in the old code but not the new code, and we need to fix that. Sam On Dec 3, 2017 12:07 PM, "HiPhish" wrote: > Here is what happens when I run one of the array tests with the more >