LGTM, but I should note that I already accepted Philip’s earlier suggestion. If
you want to make further changes, go for it!
John
> On Nov 30, 2018, at 06:25, Greg Hendershott wrote:
>
> On Fri, Nov 30, 2018 at 5:58 AM Robby Findler
> wrote:
>> What about using the function
>>
>> (lambda
On Fri, Nov 30, 2018 at 5:58 AM Robby Findler
wrote:
> What about using the function
>
> (lambda (x) (and x #true))
>
> And putting a short discussion of truthy and a link to elsewhere in the docs?
Yeah. I feel like the `filter-map` doc would be fine with just that change.
Already it tells you
What about using the function
(lambda (x) (and x #true))
And putting a short discussion of truthy and a link to elsewhere in the
docs?
Robby
On Thu, Nov 29, 2018 at 11:17 PM Philip McGrath
wrote:
> I can do it.
>
> -Philip
>
>
> On Thu, Nov 29, 2018 at 5:17 PM John Clements
> wrote:
>
>> I
I can do it.
-Philip
On Thu, Nov 29, 2018 at 5:17 PM John Clements
wrote:
> I like your idea better than mine. Do you have time to make it a pull
> request? If not, I’ll do it.
>
> John
>
> > On Nov 29, 2018, at 2:08 PM, Philip McGrath
> wrote:
> >
> > I would find `true?` confusing, since
I like your idea better than mine. Do you have time to make it a pull request?
If not, I’ll do it.
John
> On Nov 29, 2018, at 2:08 PM, Philip McGrath wrote:
>
> I would find `true?` confusing, since it really means "truthy." For example,
> in Rackunit, `check-not-false` has this behavior,
I would find `true?` confusing, since it really means "truthy." For
example, in Rackunit, `check-not-false` has this behavior, whereas
`check-true` checks that the result is really `eq?` to `#t`.
Personally, I think it might be better to clarify the documentation with
more prose, rather than
This function is a already defined in a few libraries and it is called
`true?` for example in
https://docs.racket-lang.org/predicates/index.html?q=true#%28def._%28%28lib._predicates%2Fmain..rkt%29._true~3f%29%29
I think that `not-false?` is easier to understand, but `true?` is more
idiomatic.
This stack overflow post
https://stackoverflow.com/questions/53543191/what-is-the-different-between-filter-and-filter-map/53545115#53545115
… is written by someone confused by the documentation for `filter-map`. I went
and read the documentation, and *I* was confused for about 30 seconds. I
8 matches
Mail list logo
