Re: [Radiant] URL tags

2009-09-23 Thread Sean Cribbs
At one point, I believe it was for Con-way, I implemented an r:if_blank tag that checked whether a part was blank. Regarding the syntax of Jim's proposal, it would be nice to disambiguate the 'blank' attribute - it's unclear to me what it would do in each case. Maybe: r:if_content

Re: [Radiant] URL tags

2009-09-23 Thread Andrew vonderLuft
As info, these are the tags Sean mentioned: tag 'if_blank' do |tag| part_name = tag.attr['part'] raise StandardTags::TagError.new(`if_blank' tag requires a 'part' attribute) unless part_name part = tag.locals.page.part(part_name) result = part.nil? ? :

Re: [Radiant] URL tags

2009-09-23 Thread John W. Long
On Sep 23, 2009, at 10:53 AM, Andrew vonderLuft wrote: As info, these are the tags Sean mentioned: tag 'if_blank' do |tag| ... end tag 'unless_blank' do |tag| ... end I like this: r:if_blank part=my_part r:unless_blank part=my_part The current semantics of if_content are nice

Re: [Radiant] URL tags

2009-09-23 Thread Mohit Sindhwani
John W. Long wrote: On Sep 23, 2009, at 10:53 AM, Andrew vonderLuft wrote: As info, these are the tags Sean mentioned: tag 'if_blank' do |tag| ... end tag 'unless_blank' do |tag| ... end I like this: r:if_blank part=my_part r:unless_blank part=my_part The current semantics of

Re: [Radiant] URL tags

2009-09-23 Thread Anton Aylward
John W. Long said the following on 09/23/2009 11:20 AM: I like this: r:if_blank part=my_part r:unless_blank part=my_part Personally I am tired of the if_ and prefer the more generic simple if with some parameter. It look more natural. -- Nothing is more difficult to carry out,

Re: [Radiant] URL tags

2009-09-23 Thread John W. Long
On Sep 23, 2009, at 12:17 PM, Chris Parrish wrote: Anton Aylward wrote: Personally I am tired of the if_ and prefer the more generic simple if with some parameter. It look more natural. I suppose you all know where I stand on this. Anton, I use my conditional tags extension

Re: [Radiant] URL tags

2009-09-23 Thread Alexander Wallace
I prefer trusting `if_content` to just tell me if the part is actually present on the page, especially when using page parts that do more than just output text (granted, using non-text page parts probably isn't a common use-case, but it might become more common after the Page Parts is polished up

Re: [Radiant] URL tags

2009-09-23 Thread Jim Gay
On Wed, Sep 23, 2009 at 2:09 PM, John W. Long m...@johnwlong.com wrote: On Sep 23, 2009, at 1:08 PM, Jim Gay wrote: That may be the case, but the name of the tag has caused confusion in my experience. My typical users (myself included) consider content to be text. . . . I'm arguing that the

Re: [Radiant] URL tags

2009-09-23 Thread Jim Gay
On Wed, Sep 23, 2009 at 3:00 PM, John W. Long m...@johnwlong.com wrote: Basically, encouraging users to have blank page parts is not something that I want to encourage. They should delete the object to keep the database clean if this is something that they desire. Users don't care about

Re: [Radiant] URL tags

2009-09-23 Thread Mohit Sindhwani
John W. Long wrote: On Sep 23, 2009, at 2:45 PM, Jim Gay wrote: I'm not sure I understand what you mean by that last comment. It's harder to explain. Basically, encouraging users to have blank page parts is not something that I want to encourage. They should delete the object to keep the

Re: [Radiant] URL tags

2009-09-23 Thread Mohit Sindhwani
Jim Gay wrote: On Wed, Sep 23, 2009 at 3:00 PM, John W. Long m...@johnwlong.com wrote: Basically, encouraging users to have blank page parts is not something that I want to encourage. They should delete the object to keep the database clean if this is something that they desire. Users

Re: [Radiant] URL tags

2009-09-23 Thread John W. Long
On Sep 23, 2009, at 3:26 PM, Jim Gay wrote: Users don't care about keeping the database clean. Developers might care, but regular content editors just want to know where to put their content. And the problem with deleting a page part is that the user needs to remember what it was called to

Re: [Radiant] URL tags

2009-09-23 Thread Jim Gay
On Wed, Sep 23, 2009 at 4:26 PM, John W. Long m...@johnwlong.com wrote: On Sep 23, 2009, at 3:26 PM, Jim Gay wrote: Users don't care about keeping the database clean. Developers might care, but regular content editors just want to know where to put their content. And the problem with deleting

Re: [Radiant] URL tags

2009-09-23 Thread John W. Long
On Sep 23, 2009, at 5:33 PM, Jim Gay wrote: So how will Radiant (or John Long) be discouraging its use? Would the documentation in the tag reference say that? I don't think there is a need to document this in the tag reference. It will be somewhat discouraged by having if_content and

Re: [Radiant] URL tags

2009-09-23 Thread Anton Aylward
Jim Gay said the following on 09/23/2009 03:26 PM: On Wed, Sep 23, 2009 at 3:00 PM, John W. Long m...@johnwlong.com wrote: Basically, encouraging users to have blank page parts is not something that I want to encourage. They should delete the object to keep the database clean if this is

Re: [Radiant] URL tags

2009-09-23 Thread Mohit Sindhwani
Anton Aylward wrote: John W. Long said the following on 09/23/2009 03:00 PM: On Sep 23, 2009, at 2:45 PM, Jim Gay wrote: I'm not sure I understand what you mean by that last comment. It's harder to explain. Basically, encouraging users to have blank page parts is not

Re: [Radiant] URL tags

2009-09-23 Thread John W. Long
On Sep 23, 2009, at 8:01 PM, Jim Gay wrote: Ok. At first this seems reasonable, but will unless_blank also implement the inherit attribute to look up the page tree? I'm fine with that. If it will be implemented with inherit, it brings me back to just wanting to use if_content. And if_content

Re: [Radiant] URL tags

2009-09-23 Thread Anton Aylward
Mohit Sindhwani said the following on 09/23/2009 09:35 PM: Anton Aylward wrote: John W. Long said the following on 09/23/2009 03:00 PM: Basically, encouraging users to have blank page parts is not something that I want to encourage. Not so. I've had to use blank page parts as

Re: [Radiant] URL tags

2009-09-23 Thread Anton Aylward
John W. Long said the following on 09/23/2009 10:00 PM: On Sep 23, 2009, at 9:35 PM, Mohit Sindhwani wrote: Anton Aylward wrote: I've had to use blank page parts as flags in a number of situations becuase I could not solve the problem any other way. I think that is the most common use case of

Re: [Radiant] URL tags

2009-09-22 Thread Mohit Sindhwani
John W. Long wrote: Hi all, Looking for some feedback on something. I'm thinking about changing the URL tags to operate on and return the full URL. I'm also thinking adding a new set of path tags for the case when you just want to work with the path. This would mean that r:if_url, r:url,

Re: [Radiant] URL tags

2009-09-22 Thread Nate
Jim Gay wrote: I think this is a good idea. Possibly painful, but ultimately good. I'd like to broaden the discussion a bit and also suggest a change to if_content so that it checks if content is not blank in a part, and if_part which would check if the part exists. I think those names would

Re: [Radiant] URL tags

2009-09-22 Thread Jim Gay
On Tue, Sep 22, 2009 at 11:21 PM, Nate pixeln...@gmail.com wrote: Jim Gay wrote: I think this is a good idea. Possibly painful, but ultimately good. I'd like to broaden the discussion a bit and also suggest a change to if_content so that it checks if content is not blank in a part, and