Re: [Rails-core] [PROPOSAL] Partial commit access

2006-06-24 Thread Blair Zajac
On Jun 13, 2006, at 3:00 AM, David Heinemeier Hansson wrote: It would be nice if the people like Michael Schoen who have shown a commitment to the Oracle bindings could work on that portion without the overhead of a full time committer reviewing each commit, as long as only that file or fi

Re: [Rails-core] Reloadable modules

2006-06-24 Thread Blair Zajac
On Jun 7, 2006, at 9:01 PM, Trevor Squires wrote: Hey, I too have felt the pain of having to restart the server when working on the modules in plugins. However it's easily avoided by putting a require_dependency 'my_module' just before the include MyModule call. It's a small amount of

Re: [Rails-core] Tests Broken!

2006-06-24 Thread Coda Hale
On 6/24/06, Hampton <[EMAIL PROTECTED]> wrote: Looks like some changes made in the Ennumerable extensions had some majorly negative effects on the Summing ability of AR. Enumerable#sum was overriding AR::Calculations#sum. I opened a ticket for this (#5500 [http://dev.rubyonrails.org/ticket/5500

[Rails-core] Thank-you to the Rails Core Team

2006-06-24 Thread Dave Teare
I posted this to the wrong list yesterday...sorry for the repost. While we were listening to Dave Thomas' Keynote address today at RailsConf, Roustem and I were reminded about how much of our success we owe to the Rails Core team. If it wasn't for you kind folks, we'd still be slugging out "

[Rails-core] Tests Broken!

2006-06-24 Thread Hampton
Looks like some changes made in the Ennumerable extensions had some majorly negative effects on the Summing ability of AR. Sample Errors off mysql: 2) Error: test_should_group_by_summed_field_with_conditions_and_having(CalculationsTest): ArgumentError: wrong number of arguments (2 for 0) ./t

[Rails-core] Patch for #3438: Eager loading doesn't respect :order of association

2006-06-24 Thread Coda Hale
Hello all, I just submitted a patch for #3438 [http://dev.rubyonrails.org/ticket/3438], to make eagerly-loaded associations have the same order as regularly-loaded associations. It passes all existing MySQL tests, and I've added two more fairly comprehensive tests which make sure that all eagerly

Re: [Rails-core] COMMITTERS: Tests needed for this patch?

2006-06-24 Thread Kevin Clark
RailsTies doesn't have any tests, which is unfortunate. If you'd like to write tests for your generator (and I'd encourage it), you probably want to mock out whatever is written to and look for the correct content. I hear good things about FlexMock. Kev On 6/24/06, Brad Ediger <[EMAIL PROTECTED]

[Rails-core] COMMITTERS: Tests needed for this patch?

2006-06-24 Thread Brad Ediger
I submitted this patch, which fixes a minor MigrationGenerator issue, about a month ago: http://dev.rubyonrails.org/ticket/5197 I was trying to be a good Rails / Ruby citizen and write tests for it, but I couldn't find any tests for the generators. Are the generators tested right now? If I sh