[Rails-core] Rails AR/Oracle Unit Test: [4554] failed (but getting better)

2006-07-05 Thread Michael Schoen
"rick" has given AR/Oracle some love, but it's still unhappy... http://dev.rubyonrails.org/changeset/4554 r4554 | rick | 2006-07-05 07:22:24 -0700 (Wed, 05 Jul 2006) | 1 line revert ActiveRecord equality change. Closes #559

[Rails-core] Rails AR/Oracle Unit Test: [4552] failed (getting worse)

2006-07-05 Thread Michael Schoen
"david" has kicked AR/Oracle while it was down... http://dev.rubyonrails.org/changeset/4552 r4552 | david | 2006-07-04 19:54:19 -0700 (Tue, 04 Jul 2006) | 1 line Fixed a few Oracle issues: Allows Oracle's odd date handling t

[Rails-core] Rails AR/Oracle Unit Test: [4549] failed (getting worse)

2006-07-05 Thread Michael Schoen
"david" has kicked AR/Oracle while it was down... http://dev.rubyonrails.org/changeset/4549 r4549 | david | 2006-07-04 19:30:37 -0700 (Tue, 04 Jul 2006) | 1 line rake should run active_schema_mysql_test.rb (closes #5390) ---

[Rails-core] Oracle/AR test failures

2006-07-05 Thread Michael A. Schoen
Sorry for the spam folks -- I had turned off my autotesting script for a bit while I hacked away, to avoid conflicts in my test db. Just turned it back on, and it got caught up. I'll have a patch submitted shortly to get it back into shape. ___ Rails

[Rails-core] Rails AR/Oracle Unit Test: [4543] failed (getting worse)

2006-07-05 Thread Michael Schoen
"david" has kicked AR/Oracle while it was down... http://dev.rubyonrails.org/changeset/4543 r4543 | david | 2006-07-04 18:43:47 -0700 (Tue, 04 Jul 2006) | 1 line Doc fix (closes #5504) [EMAIL PROTECTED] -

[Rails-core] Rails AR/Oracle Unit Test: [4508] failed (but getting better)

2006-07-05 Thread Michael Schoen
"bitsweat" has given AR/Oracle some love, but it's still unhappy... http://dev.rubyonrails.org/changeset/4508 r4508 | bitsweat | 2006-06-28 18:13:55 -0700 (Wed, 28 Jun 2006) | 3 lines [EMAIL PROTECTED]: jeremy | 2006-06-28

[Rails-core] Rails AR/Oracle Unit Test: [4505] failed (getting worse)

2006-07-05 Thread Michael Schoen
"bitsweat" has kicked AR/Oracle while it was down... http://dev.rubyonrails.org/changeset/4505 r4505 | bitsweat | 2006-06-28 16:51:50 -0700 (Wed, 28 Jun 2006) | 1 line Don't assume Active Record is available. Closes #5497. -

[Rails-core] Rails AR/Oracle Unit Test: [4493] failed (but getting better)

2006-07-05 Thread Michael Schoen
"ulysses" has given AR/Oracle some love, but it's still unhappy... http://dev.rubyonrails.org/changeset/4493 r4493 | ulysses | 2006-06-25 10:49:24 -0700 (Sun, 25 Jun 2006) | 1 line Add AssociationCollection#sum since the met

[Rails-core] Rails AR/Oracle Unit Test: [4490] failed (getting worse)

2006-07-05 Thread Michael Schoen
"david" has kicked AR/Oracle while it was down... http://dev.rubyonrails.org/changeset/4490 r4490 | david | 2006-06-24 09:27:34 -0700 (Sat, 24 Jun 2006) | 1 line Cant use separate module [DHH] ---

[Rails-core] Rails AR/Oracle Unit Test: [4489] failed (but getting better)

2006-07-05 Thread Michael Schoen
"david" has given AR/Oracle some love, but it's still unhappy... http://dev.rubyonrails.org/changeset/4489 r4489 | david | 2006-06-24 09:14:59 -0700 (Sat, 24 Jun 2006) | 1 line Added Enumerable#sum for calculating a sum from

[Rails-core] Rails AR/Oracle Unit Test: [4484] failed (but getting better)

2006-07-05 Thread Michael Schoen
"bitsweat" has given AR/Oracle some love, but it's still unhappy... http://dev.rubyonrails.org/changeset/4484 r4484 | bitsweat | 2006-06-21 16:15:03 -0700 (Wed, 21 Jun 2006) | 1 line Get there ---

[Rails-core] Rails AR/Oracle Unit Test: [4483] failed (getting worse)

2006-07-05 Thread Michael Schoen
"bitsweat" has kicked AR/Oracle while it was down... http://dev.rubyonrails.org/changeset/4483 r4483 | bitsweat | 2006-06-21 16:09:01 -0700 (Wed, 21 Jun 2006) | 1 line preserve chained method punctuation

[Rails-core] Rails AR/Oracle Unit Test: [4482] failed (but getting better)

2006-07-05 Thread Michael Schoen
"bitsweat" has given AR/Oracle some love, but it's still unhappy... http://dev.rubyonrails.org/changeset/4482 r4482 | bitsweat | 2006-06-21 13:40:14 -0700 (Wed, 21 Jun 2006) | 1 line alias_method_chain preserves method punct

[Rails-core] Rails AR/Oracle Unit Test: [4472] failed (getting worse)

2006-07-05 Thread Michael Schoen
"bitsweat" has kicked AR/Oracle while it was down... http://dev.rubyonrails.org/changeset/4472 r4472 | bitsweat | 2006-06-20 12:54:35 -0700 (Tue, 20 Jun 2006) | 3 lines [EMAIL PROTECTED]: jeremy | 2006-06-20 12:53:36 -0700

[Rails-core] Rails AR/Oracle Unit Test: [4462] failed (getting worse)

2006-07-05 Thread Michael Schoen
"bitsweat" has kicked AR/Oracle while it was down... http://dev.rubyonrails.org/changeset/4462 r4462 | bitsweat | 2006-06-19 18:58:36 -0700 (Mon, 19 Jun 2006) | 3 lines [EMAIL PROTECTED]: jeremy | 2006-06-19 18:55:36 -0700

Re: [Rails-core] help finishing a patch for label helpers? [#362]

2006-07-05 Thread Rick Olson
On 7/5/06, Jeremy Kemper <[EMAIL PROTECTED]> wrote: On Jul 5, 2006, at 5:43 PM, Peter Michaux wrote: > Rick, it looks like a little more than hacking. What is stopping your > patch from going into the core? (BTW, you quoted his answer just a few lines up.) I use labels too and would like to see

Re: [Rails-core] help finishing a patch for label helpers? [#362]

2006-07-05 Thread Jeremy Kemper
On Jul 5, 2006, at 5:43 PM, Peter Michaux wrote: Rick, it looks like a little more than hacking. What is stopping your patch from going into the core? (BTW, you quoted his answer just a few lines up.) I use labels too and would like to see them in the standard form builder. jeremy

Re: [Rails-core] help finishing a patch for label helpers? [#362]

2006-07-05 Thread Peter Michaux
On 7/4/06, Rick Olson <[EMAIL PROTECTED]> wrote: > I think this is a good idea but is not so flexible. If I am reading > this correctly, this will produce > > Foohttp://svn.techno-weenie.net/projects/plugins/labeled_form_helper/ as more of a proof of concept than anything. Rick, it looks like a

Re: [Rails-core] Re: [Ruby on Rails] #5544: [PATCH] Add underscore_table_names option to ActiveRecord::Base

2006-07-05 Thread Kevin Clark
This is my fault. set_fixture_class was something I contributed to fix the bug, but didn't write RDoc for it at the time. If you want to file a ticket for it (make sure to add the 'docs' keyword) then I'll get on it. Kev On 7/5/06, Rob Sanheim <[EMAIL PROTECTED]> wrote: On 7/3/06, Rick Olson <[

Re: [Rails-core] Re: [Ruby on Rails] #5544: [PATCH] Add underscore_table_names option to ActiveRecord::Base

2006-07-05 Thread Rob Sanheim
On 7/3/06, Rick Olson <[EMAIL PROTECTED]> wrote: fixtures map to table names. Use set_fixture_class to set a custom class name for a fixture name. -- Rick Olson http://techno-weenie.net Is there any reason there is no documentation for this? Or just awaiting a patch? - Rob -- http://www.r

Re: [Rails-core] help finishing a patch for label helpers? [#362]

2006-07-05 Thread Martin Emde
<%= f.label_for :name %> is cool as it hides the internal generation of the id attribute for use in the for="">In most people's views, this is done twice by two different methods, once for the label (manually), then again for the input (using internal rails stuff). I agree this isn't DRY and there

Re: [Rails-core] New records now considered equal if their attributes are equal (ActiveRecord, r4552)

2006-07-05 Thread Michael A. Schoen
Michael Koziarski wrote: That's a strange change to embed in an oracle fix? Was it intentional david? Michael? http://dev.rubyonrails.org/changeset/4552 Agreed, that wasn't in my patch. I presume another patch from somebody else got applied by mistake? ___

Re: [Rails-core] Improving ActionController Filters

2006-07-05 Thread Andrew Kaspick
I would tend to think { |controller, block| block.call } would more clear, especially to people new to the framework and ruby itself. On 7/5/06, Martin Emde <[EMAIL PROTECTED]> wrote: Great. Good to see people agree with the idea. I still think there's a lot of improvement to be made in the fil

Re: [Rails-core] Improving ActionController Filters

2006-07-05 Thread Martin Emde
Great. Good to see people agree with the idea.I still think there's a lot of improvement to be made in the filter code so I will continue making this patch.I also wanted to see what people's preference was for yielding the action from a filter. The problem with yield is that yield from a block pass

Re: [Rails-core] New records now considered equal if their attributes are equal (ActiveRecord, r4552)

2006-07-05 Thread Rick Olson
> In light of this recent change: That's a strange change to embed in an oracle fix? Was it intentional david? Michael? I rolled it back. The ticket for the change was denied prior to the commit. -- Rick Olson http://techno-weenie.net ___ Rails-c

Re: [Rails-core] New records now considered equal if their attributes are equal (ActiveRecord, r4552)

2006-07-05 Thread Michael Koziarski
On 7/5/06, Chris Mear <[EMAIL PROTECTED]> wrote: Hello list, In light of this recent change: That's a strange change to embed in an oracle fix? Was it intentional david? Michael? http://dev.rubyonrails.org/changeset/4552 I personally don't like the change at all, the previous behaviour of

[Rails-core] New records now considered equal if their attributes are equal (ActiveRecord, r4552)

2006-07-05 Thread Chris Mear
Hello list, In light of this recent change: --- lib/active_record/base.rb (revision 4551) +++ lib/active_record/base.rb (revision 4552) @@ -1646,8 +1646,9 @@ def ==(comparison_object) comparison_object.equal?(self) || (comparison_object.instance_of?(self.class) &&