[Rails-core] [PATCH] Quick RailTies fix

2006-07-04 Thread Brad Ediger
;t think it makes sense to just say "don't do that" when a fix exists. Thanks! Brad Ediger Madriska Media Group ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core

Re: [Rails-core] Patching process (Was: Ticket 4440 seems mostly completed)

2006-06-27 Thread Brad Ediger
) Include tests 3) Make the patch small if possible. I think there were a few more things mentioned but that is all I can recall off the top of my head. Hope this helps, Zack On 6/27/06, Brad Ediger <[EMAIL PROTECTED]> wrote: I think quite a few of us have been lurking on rails-core waiti

[Rails-core] Patching process (Was: Ticket 4440 seems mostly completed)

2006-06-27 Thread Brad Ediger
hanks! -- Brad Ediger Madriska Media Group Charles O Nutter wrote: I've posted a couple different patches to ticket 4440, and as far as I can tell they resolve all nonstandard block syntax throughout the rails/railties module. I would be very interested in helping to move this forward, s

[Rails-core] COMMITTERS: Tests needed for this patch?

2006-06-24 Thread Brad Ediger
I submitted this patch, which fixes a minor MigrationGenerator issue, about a month ago: http://dev.rubyonrails.org/ticket/5197 I was trying to be a good Rails / Ruby citizen and write tests for it, but I couldn't find any tests for the generators. Are the generators tested right now? If I sh