Re: Re: [Rails-core] Clean Functional Tests

2006-11-04 Thread Chris Roos
* Posting on behalf of James Mead ([EMAIL PROTECTED]) * Sounds interesting. I've been doing my own monkey-patching recently (http://mocha.rubyforge.org/classes/MultipleSetupAndTeardown.html) and have noticed a couple of other people (http://www.agilewebdevelopment.com/plugins/testcase_setup_and_t

Re: Re: [Rails-core] Clean Functional Tests

2006-08-18 Thread Nathaniel Talbott
On 8/18/06, Keith Morrison <[EMAIL PROTECTED]> wrote: You could define a fake test, but then the test and assertion count will be off. A simple: def default_test end In your abstract test case will prevent the failure, and while you will see an extra test, there will be no assertion inflat

Re: [Rails-core] Clean Functional Tests

2006-08-18 Thread Kevin Clark
But the difference here is that has_many is named explicitly. The TestInjector (while cool, don't get me wrong) feels a bit like PFM to save 3 lines in a setup method. It also encourages a 1 class to 1 test case method of testing which I don't think always makes the most sense (see http://glu.tto

Re: [Rails-core] Clean Functional Tests

2006-08-18 Thread Keith Morrison
Rails does a great job of inferring a lot of things based on names, so it seems like a good fit to me. class User < ActiveRecord::Base has_many :assignments end From this class declaration, Rails infers that there is an Assignment model that contains the foreign key user_id. Isn't this the

Re: [Rails-core] Clean Functional Tests

2006-08-18 Thread Kevin Clark
See ActiveRecordTestCase in active_record_unit.rb in actionpack. I defined a test_truth so Test::Unit::TestCase doesn't complain. The test count is slightly inflated, but if you care enough about not having request, response and controller instance variables setup then it's an option. Adding a de

Re: [Rails-core] Clean Functional Tests

2006-08-18 Thread Keith Morrison
Not without even more magic. Test::Unit::TestCase has an inherited method that tries to build a test suite from any test_* methods in the subclass. Executing this code: require 'test/unit' class FunctionalTest < Test::Unit::TestCase; end Produces: 1) Failure: default_test:2 No tests were sp

Re: [Rails-core] Clean Functional Tests

2006-08-18 Thread Kevin Clark
Is there a reason we don't just create a new subclass of Test::Unit::TestCase called ControllerTest (or FunctionalTest) and inheirit from that instead? We don't have to worry about the magic and it's still backwards compatible. -- Kevin Clark http://glu.ttono.us __

Re: [Rails-core] Clean Functional Tests

2006-08-18 Thread Keith Morrison
In that case, the plugin won't help you, but it won't hinder you either. Francois Beausoleil wrote: Hello Keith, 2006/8/17, Keith Morrison <[EMAIL PROTECTED]>: Comments, questions, suggestions? My tests are defined like this now: # test/functional/admin_controller_t

Re: [Rails-core] Clean Functional Tests

2006-08-17 Thread Rob Sanheim
On 8/17/06, Keith Morrison <[EMAIL PROTECTED]> wrote: Hi all, I'd like to gauge the interest for a patch before I add to the already large ticket list in Trac. I've created a small patch that cleans up functional tests. With this patch applied, functional tests can look just like unit tests. T

Re: [Rails-core] Clean Functional Tests

2006-08-17 Thread Francois Beausoleil
Hello Keith, 2006/8/17, Keith Morrison <[EMAIL PROTECTED]>: Comments, questions, suggestions? My tests are defined like this now: # test/functional/admin_controller_test.rb class UnauthenticatedAccessToAdminSectionTest < Test::Unit::TestCase def setup @controller = AdminController.new

[Rails-core] Clean Functional Tests

2006-08-17 Thread Keith Morrison
Hi all, I'd like to gauge the interest for a patch before I add to the already large ticket list in Trac. I've created a small patch that cleans up functional tests. With this patch applied, functional tests can look just like unit tests. There is no need to open the controller class in ord