Re: [Rails-core] Routing failures on r4498

2006-07-10 Thread Francois Beausoleil
Hi ! 2006/6/28, Nicholas Seckar <[EMAIL PROTECTED]>: Awesome. There are two places Regexp's appear. They are attached to segments in the path as segment.regexp (See DynamicSegment.) and they also appear on the route's requirements hash (route.requirements.) However they both pass thru RouteBui

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Nicholas Seckar
On 6/28/06, Francois Beausoleil <[EMAIL PROTECTED]> wrote: Hello Nicholas !2006/6/28, Nicholas Seckar <[EMAIL PROTECTED]>:> Perhaps we should add an informative error message for this case. Feel free> to weight in if you think so. (Or better yet, send a diff + unit test.) I will, I only need a poin

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Francois Beausoleil
Hello Nicholas ! 2006/6/28, Nicholas Seckar <[EMAIL PROTECTED]>: Perhaps we should add an informative error message for this case. Feel free to weight in if you think so. (Or better yet, send a diff + unit test.) I will, I only need a pointer on where I should start searching. With that, I'll

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Francois Beausoleil
Hello Jean-François, 2006/6/28, Jean-François <[EMAIL PROTECTED]>: By the way, isn't \A \z better than \A \Z ? Actually, you might be right, except in this case it doesn't matter. From "Programming Ruby" 2nd edition, p. 70, section Anchors: """The sequence \A matches the beginning of a string

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Nicholas Seckar
On 6/28/06, Francois Beausoleil <[EMAIL PROTECTED]> wrote: Hi all,The route is:map.game_instructions 'game/:game/instructions', :controller => 'games',:action ="" 'instructions', :requirements => {:game => /\A[-\w \+%]+\Z/i} Placing ^, \A, \Z, and $ inside regexp captures for requirements is no

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Francois Beausoleil
Ah ha ! 2006/6/28, Jamis Buck <[EMAIL PROTECTED]>: I suspect the problem is that the :game regex has \A and \Z in it. Because the new routes put that verbatim into the larger route regex, the match will fail. (Ditto for the /^.*$/ regex, with the ^ and $ anchors.) I *think* (Nicholas, correct me

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Jean-François
2006/6/28, Jamis Buck <[EMAIL PROTECTED]>: Francois, I suspect the problem is that the :game regex has \A and \Z in it. Because the new routes put that verbatim into the larger route regex, the match will fail. (Ditto for the /^.*$/ regex, with the ^ and $ anchors.) I *think* (Nicholas, correct

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Jamis Buck
Francois, I suspect the problem is that the :game regex has \A and \Z in it. Because the new routes put that verbatim into the larger route regex, the match will fail. (Ditto for the /^.*$/ regex, with the ^ and $ anchors.) I *think* (Nicholas, correct me if I'm wrong) that you can just t

Re: [Rails-core] Routing failures on r4498

2006-06-28 Thread Michael Genereux
I lost even the most basic automatic routing support for the module/:controller/:action/:id URL format going from 1.1.2 to 1.1.3. I had to lock all my apps back to 1.1.2. Is my issue the same issue as Francois? Actual data but .com names have been changed to protect the innocent: --- route.

[Rails-core] Routing failures on r4498

2006-06-28 Thread Francois Beausoleil
Hi all, I seem to have a problem. I attached a test case which I can't make pass. The route was extracted verbatim from an existing application. If I rollback in time to r4393, the tests pass. The route is: map.game_instructions 'game/:game/instructions', :controller => 'games', :action =>