[Rails-core] RegexpError (regular expression too big)

2006-06-07 Thread Solomon White
Hello all-- I encountered an issue last night that appears to be related to the new routes implementation. We're running edge rails for our production e-commerce app (* ignores snickers from the crowd *), and had to roll back when last night's deployment failed. What we were seeing in t

[Rails-core] Routing code patch

2006-06-07 Thread Blair Zajac
I just opened a ticket for the new routing code that breaks the restful_rails plugin. The plugin is using the public API for inserting routes and not going behind the scenes, besides adding a #connect_resource method to the routing code that adds multiple routes using #connect. The code that

[Rails-core] #5209 patch: :dependent => :nullify deletes child records

2006-06-07 Thread Chris Mear
Hi everyone, A couple of weeks ago I noticed a bug with :dependent => :nullify on a has_many or has_one. When you delete the parent, the children's foreign keys are nullified, as expected. But when you do parent.child.delete or parent.children.clear, ActiveRecord actually deletes the chil

Re: [Rails-core] RegexpError (regular expression too big)

2006-06-07 Thread Jamis Buck
Solomon, I'll definitely take a look at it today and see what I can find. In the meantime, please note that the current routes impl is NOT ready for production. It is known to be inefficient in several areas (particularly route generation) and buggy (as you discovered). We are working har

[Rails-core] Feedback needed on scoping

2006-06-07 Thread Julian 'Julik' Tarkhanov
I already asked nzkoz about this, but I have some questions unanswered on http://dev.rubyonrails.org/ticket/5305 Would someone take a look? -- Julian 'Julik' Tarkhanov please send all personal mail to me at julik.nl ___ Rails-core mailing list Rails

Re: [Rails-core] RegexpError (regular expression too big)

2006-06-07 Thread Jamis Buck
Solomon, Can you svn up and see if it works now? I've made the possible_controllers code smarter, so it should return a much smaller list of possible controllers. Definitely still room for improvement, but it's better than it was. - Jamis On Jun 7, 2006, at 7:52 AM, Jamis Buck wrote: S

Re: [Rails-core] Routing code patch

2006-06-07 Thread Jamis Buck
Blair, thanks for this patch. It's been applied. - Jamis On Jun 6, 2006, at 5:36 PM, Blair Zajac wrote: I just opened a ticket for the new routing code that breaks the restful_rails plugin. The plugin is using the public API for inserting routes and not going behind the scenes, besides add

Re: [Rails-core] Routing code patch

2006-06-07 Thread Blair Zajac
Jamis, Thanks! Blair Jamis Buck wrote: Blair, thanks for this patch. It's been applied. - Jamis On Jun 6, 2006, at 5:36 PM, Blair Zajac wrote: I just opened a ticket for the new routing code that breaks the restful_rails plugin. The plugin is using the public API for inserting routes a

Re: [Rails-core] Too. Many. Scriptaculous. Tickets.

2006-06-07 Thread Giles Bowkett
Right, it isn't getting rid of magic lantern patches so much as magic lantern requests without a patch. OK this just makes me think in terms of economics. Requests for enhancements which require no action on the requestor's part are guaranteed to trigger "tragedy of the commons" effects. That i

[Rails-core] Reloadable modules

2006-06-07 Thread Blair Zajac
There's a scenario with the projects I'm working on that could use reloadable modules, instead of just reloadable classes. Ticket and patch with test suite changes are at: http://dev.rubyonrails.org/ticket/5329 The reasoning for doing this is I have a library of 25 and growing plugins that de

Re: [Rails-core] Reloadable modules

2006-06-07 Thread Julian 'Julik' Tarkhanov
On 8-jun-2006, at 1:31, Blair Zajac wrote: There's a scenario with the projects I'm working on that could use reloadable modules, instead of just reloadable classes. Ticket and patch with test suite changes are at: http://dev.rubyonrails.org/ticket/5329 I am now building an app that assem

Re: [Rails-core] Reloadable modules

2006-06-07 Thread Trevor Squires
Hey, I too have felt the pain of having to restart the server when working on the modules in plugins. However it's easily avoided by putting a require_dependency 'my_module' just before the include MyModule call. It's a small amount of pain that I only have to bear during development so

Re: [Rails-core] Reloadable modules

2006-06-07 Thread Julian 'Julik' Tarkhanov
On 8-jun-2006, at 6:01, Trevor Squires wrote: However it's easily avoided by putting a require_dependency 'my_module' just before the include MyModule call. It's a small amount of pain that I only have to bear during development so it's okay with me. Thanks for the tip Trevor! -- Juli