Re: [Rails-core] help finishing a patch for label helpers? [#362]

2006-07-06 Thread Stefan Kaes
Jeremy Kemper wrote: On Jul 5, 2006, at 5:43 PM, Peter Michaux wrote: Rick, it looks like a little more than hacking. What is stopping your patch from going into the core? (BTW, you quoted his answer just a few lines up.) I use labels too and would like to see them in the standard form builde

[Rails-core] Showing SQL Server some love...

2006-07-06 Thread Tom Ward
There are a fair few issues against the SQL Server db adapter that I'd like to see fixed. There are also a couple of features I'd like to add, but don't really want to until these bugs have been fixed. It's time to show SQL Server some love! Many of these outstanding issues have patches against

Re: [Rails-core] Showing SQL Server some love...

2006-07-06 Thread David Heinemeier Hansson
Many of these outstanding issues have patches against that need reviewing, testing or just generally cleaning up. I'm more than willing to go through these patches and do this work, but what's the best way to get them actually committed to trunk? Create one new aggregated patch and mark the oth

Re: Re: [Rails-core] New records now considered equal if their attributes are equal (ActiveRecord, r4552)

2006-07-06 Thread David Heinemeier Hansson
Agreed, that wasn't in my patch. I presume another patch from somebody else got applied by mistake? Yup, applied by mistake. Rick rolled it back. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.back

Re: [Rails-core] help finishing a patch for label helpers? [#362]

2006-07-06 Thread Peter Michaux
On 7/5/06, Rick Olson <[EMAIL PROTECTED]> wrote: The actual label_tag and label helpers are fine, I was just expressing my opinion on the custom LabelingFormBuilder thing that adds labels to other helpers. I don't remember why I never submitted it as a patch. Maybe the rails-core channel wasn'

[Rails-core] Re: help finishing a patch for label helpers? [#362]

2006-07-06 Thread Peter Michaux
Hi, How would people feel about an error_message_on helper? <%= f.label_for :name %> <%= f.text_field :name %> <%= f.error_message_on :name %> I think it would be nice if this returned the error message in a so all messages could be styled easily and consistently. Peter _

[Rails-core] Rails AR/Oracle Unit Test: [4571] failed (but getting better)

2006-07-06 Thread Michael Schoen
"bitsweat" has given AR/Oracle some love, but it's still unhappy... http://dev.rubyonrails.org/changeset/4571 r4571 | bitsweat | 2006-07-06 10:30:54 -0700 (Thu, 06 Jul 2006) | 1 line Rename test file so it runs for MySQL onl

Re: [Rails-core] Oracle/AR test failures

2006-07-06 Thread Michael A. Schoen
Michael A. Schoen wrote: I'll have a patch submitted shortly to get it back into shape. http://dev.rubyonrails.org/ticket/5635 ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-co