[openstreetmap/openstreetmap-website] Lock changeset in api single element changes (PR #6366)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6366 -- Commit Summary -- * Add missing changeset tests for api element writes * Lock changeset in api create element actions * Lock changeset in api update elemen

Re: [openstreetmap/openstreetmap-website] Update num_changes when backfilling changesets (PR #6361)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6361) > I don't remember if Rails checks the current number of changes while holding > a lock on Changesets. If not, then there's a chance of a race condition. There's no changeset lock for single element writes. > On cgimap, there

Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#3715) For old elements tags can't be preloaded for the same reasons as in #4569. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-3233357753 You are

Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)

@AntonKhorev pushed 7 commits. 56744929bc46837d0b438278594d709a6a103c76 Split api elements controller index tests bd64b768ec5276fec7509d22d6d3a978236df0a3 Test required parameter message in element multi fetch 90ee2dc59fedf7bab191b65fd0510f8f4625a331 Add generic api elements controller for m

Re: [openstreetmap/openstreetmap-website] Browse node version coordinates (PR #4930)

Closed #4930. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4930#event-19390075436 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Move next page button of shared pagination to the right side (PR #4707)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#4707) Now there are oldest/newest buttons at these places. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4707#issuecomment-3233192074 You are receiving this because

Re: [openstreetmap/openstreetmap-website] Don't include unused bootstrap css (PR #4250)

Closed #4250. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4250#event-19390150316 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Move next page button of shared pagination to the right side (PR #4707)

Closed #4707. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4707#event-19390110717 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

[openstreetmap/openstreetmap-website] Move English language names to en.yml (PR #6365)

With this PR the names can be translated, that would fix #6319. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6365 -- Commit Summary -- * Increase language list column width a bit * Move English language names to

Re: [openstreetmap/openstreetmap-website] Add geo URI handler registration on link interaction (PR #5968)

@AntonKhorev commented on this pull request. > @@ -227,6 +229,16 @@ L.OSM.share = function (options) { const precision = 5 * Math.pow(10, Math.floor(Math.LOG10E * Math.log(scale)) - 2); return precision * Math.ceil(scale / precision); } + +function askToHandleGeoURI() { +

Re: [openstreetmap/openstreetmap-website] Add geo URI handler registration on link interaction (PR #5968)

@AntonKhorev commented on this pull request. > @@ -29,6 +29,8 @@ L.OSM.share = function (options) { $ui.find(".share-tab [id]").on("click", select); +$("#geo_uri").on("mouseover click focus", askToHandleGeoURI); What do you think about adding a button to trigger the registration? I

[openstreetmap/openstreetmap-website] Make GitHub auth button invertible (PR #6360)

Continuing #6351 with GitHub logo.

Re: [openstreetmap/openstreetmap-website] Do more preloading of tags and members (PR #6338)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6338) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6338#issuecomment-3228147784 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Do more preloading of tags and members (PR #6338)

Merged #6338 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6338#event-19368301441 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add geo URI handler registration on link interaction (PR #5968)

@AntonKhorev commented on this pull request. > @@ -29,6 +29,8 @@ L.OSM.share = function (options) { $ui.find(".share-tab [id]").on("click", select); +$("#geo_uri").on("mouseover click focus", askToHandleGeoURI); `click` also has odd behavior. If `mouseover` is removed, the standard

Re: [openstreetmap/openstreetmap-website] Add geo URI handler registration on link interaction (PR #5968)

@AntonKhorev commented on this pull request. > @@ -227,6 +229,16 @@ L.OSM.share = function (options) { const precision = 5 * Math.pow(10, Math.floor(Math.LOG10E * Math.log(scale)) - 2); return precision * Math.ceil(scale / precision); } + +function askToHandleGeoURI() { +

Re: [openstreetmap/openstreetmap-website] Add geo URI handler registration on link interaction (PR #5968)

@AntonKhorev commented on this pull request. > @@ -29,6 +29,8 @@ L.OSM.share = function (options) { $ui.find(".share-tab [id]").on("click", select); +$("#geo_uri").on("mouseover click focus", askToHandleGeoURI); Is `mouseover` a good idea? I move my mouse pointer over the link and

Re: [openstreetmap/openstreetmap-website] Add geo URI handler registration on link interaction (PR #5968)

@AntonKhorev commented on this pull request. > @@ -227,6 +229,16 @@ L.OSM.share = function (options) { const precision = 5 * Math.pow(10, Math.floor(Math.LOG10E * Math.log(scale)) - 2); return precision * Math.ceil(scale / precision); } + +function askToHandleGeoURI() { +

Re: [openstreetmap/openstreetmap-website] Instantiate js controllers only once needed (PR #6295)

@AntonKhorev commented on this pull request. > - addNoteButton.on("click", function (e) { -e.preventDefault(); -e.stopPropagation(); - -if ($(this).hasClass("disabled")) return; - -OSM.router.route("/note/new"); - }); Do the event handlers need to to be moved to another file?

[openstreetmap/openstreetmap-website] Use @elements instead of @elems in api element history (PR #6356)

Eliminates `@elems` instance variable. Otherwise there are both `@elements` and `@elems` and the difference is that one is filtered by redactions and the other is not, which you can't guess from their names. You can view, comment on, or merge this pull request online at: https://github.com/ope

Re: [openstreetmap/openstreetmap-website] Do more preloading of tags and members (PR #6338)

@AntonKhorev commented on this pull request. > @@ -30,7 +30,7 @@ def index # Dump the details on a node given in params[:id] def show - @node = Node.find(params[:id]) + @node = Node.includes(:element_tags).find(params[:id]) Does this make any difference besides running t

Re: [openstreetmap/openstreetmap-website] Added error handling for object display on map (PR #6353)

@AntonKhorev commented on this pull request. > +function displayLoadError(message, close) { + $("#browse_status").html( +$("").append( + $("").append( +$("") + .text(OSM.i18n.t("browse.start_rjs.load_data")), +$("").append( +

Re: [openstreetmap/openstreetmap-website] Fix test failures from #6351 (PR #6352)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6352) It can't be related to my changes, but I don't even see how it is related to anything. A test fails/passes depending on previous `Kernel.respond_to?` call. Tried on ruby 3.2.6, then 3.2.9. ```ruby def test_what # fails

Re: [openstreetmap/openstreetmap-website] Fix test failures from #6351 (PR #6352)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6352) If `test_user_image_sizes_gravatar` runs before `test_user_image_sizes_avatar`, `test_user_image_sizes_avatar` passes; if `test_user_image_sizes_avatar` runs first, it fails. -- Reply to this email directly or view it on GitH

[openstreetmap/openstreetmap-website] Replace auth_button helper with template (PR #6355)

After #6351 and #6352 I don't think we need a helper for auth buttons. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6355 -- Commit Summary -- * Replace auth_button helper with template -- File Changes -- M a

Re: [openstreetmap/openstreetmap-website] Fix test failures from #6351 (PR #6352)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6352) `test/helpers/user_helper_test.rb` also fails on `test_user_image_sizes_avatar` for me, depending on the order of execution. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap

Re: [openstreetmap/openstreetmap-website] Fix test failures from #6351 (PR #6352)

Merged #6352 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6352#event-19334473400 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Inline auth provider logos and make Apple logo invertible (PR #6351)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6351) Tests fail because Translatewiki. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6351#issuecomment-3220213173 You are receiving this because you are subscribed

[openstreetmap/openstreetmap-website] Inline auth provider logos and make Apple logo invertible (PR #6351)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6351 -- Commit Summary -- * Replace end margin with gap * Remove unused auth button options * Combine auth button helpers * Remove from auth provider logo

Re: [openstreetmap/openstreetmap-website] Fix Apple logo aspect ratio and dark mode appearance on login page (PR #6336)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6336) Black on black is already deployed, from your earlier PR: https://github.com/user-attachments/assets/3f40cfad-791e-42b2-9b85-58d83c3516ff"; /> As it is right now, this PR fixes #6328. Which logos should be inverted (we're inv

Re: [openstreetmap/openstreetmap-website] Apple Logo on login page is not square (Issue #6328)

Closed #6328 as completed via #6336. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6328#event-19318304620 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Fix Apple logo aspect ratio and dark mode appearance on login page (PR #6336)

Merged #6336 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6336#event-19318304289 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Fix Apple logo aspect ratio and dark mode appearance on login page (PR #6336)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6336) > See > https://developer.apple.com/design/human-interface-guidelines/sign-in-with-apple#Black > for details - it should be a white logo on the existing black background. Only in light mode. In dark mode it shouldn't. -- Re

Re: [openstreetmap/openstreetmap-website] Add test for mediawiki magic words in translations (PR #6342)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6342) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6342#issuecomment-3219327496 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Broken grammatical gender syntax in translated interface strings (Issue #6341)

Closed #6341 as completed via 67ff36e4b5f27f411882ca7619d8e9ee42c7e226. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6341#event-19317461595 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Add test for mediawiki magic words in translations (PR #6342)

Merged #6342 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6342#event-19317461611 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Fix Apple logo aspect ratio and dark mode appearance on login page (PR #6336)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6336) @MAHanupriSAR can you remove the merge commit and squash the remaining commits into one? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6336#issuecomment-3218

Re: [openstreetmap/openstreetmap-website] Add test for mediawiki magic words in translations (PR #6342)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6342) Shouldn't the commits be in the opposite order, for the same reasons as https://github.com/openstreetmap/openstreetmap-website/pull/6318#issuecomment-3184530884? -- Reply to this email directly or view it on GitHub: https://g

Re: [openstreetmap/openstreetmap-website] Fix Apple logo aspect ratio and dark mode appearance on login page (PR #6336)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6336) I'd make the images larger, some of them are already button-shaped: https://github.com/user-attachments/assets/7a05a014-8105-4320-a194-869168b31781"; /> -- Reply to this email directly or view it on GitHub: https://github.co

Re: [openstreetmap/openstreetmap-website] Add and unignore `.ruby-version` file to ensure consistent dev Ruby (PR #6333)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6333) > Adds and unignores .ruby-version file to ensure a consistent development Ruby > for all contributors. Why do we need a consistent Ruby if we're supporting a range of versions? > Doing so also helps push contributors onto ne

Re: [openstreetmap/openstreetmap-website] [Question] Desktop version for Windows, Mac, Linux? (Issue #6330)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6330) This is not a question for a repository named openstreetmap-website, but you can look at https://wiki.openstreetmap.org/wiki/Software/Desktop -- Reply to this email directly or view it on GitHub: https://github.com/openstreet

[openstreetmap/openstreetmap-website] Add a note that you only need to register iD and website once (PR #6327)

To clear up this: https://github.com/openstreetmap/openstreetmap-website/issues/6325#issuecomment-3192253190 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6327 -- Commit Summary -- * Add a note that you only need

Re: [openstreetmap/openstreetmap-website] Lazy loading relation members (PR #6326)

@AntonKhorev commented on this pull request. > +can :read, RelationMember +can :read, OldRelationMember Are those actually "can read relation members if there's more than ten members"? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap

Re: [openstreetmap/openstreetmap-website] Preload element tags when showing changesets (PR #4569)

@AntonKhorev pushed 1 commit. 45e286dea34b8845e035c2a37cbb6129c2a0dc96 Preload element tags when showing changesets -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4569/files/9e3db5bbb83a646771296e04733c231b9b0ab503..45e286dea34b8845e035c2a37cbb6129c2a0dc96 Yo

Re: [openstreetmap/openstreetmap-website] Show edit history of deleted users (PR #4224)

@AntonKhorev pushed 3 commits. 340f4e97f51c1b4f2de7316ba187cae4764b0bd7 Add links to previous/next changesets of deleted user bd469142e8b6a556b9365740a4e8ef6811a38a57 Show edit history of deleted users 62b310ae0996bc0cba1f2cea422c15d80dba1817 Remove deleted authors from history feed -- View

Re: [openstreetmap/openstreetmap-website] Add user id redirect paths (PR #4215)

@AntonKhorev pushed 2 commits. 689a5acb7117d2b886900fe8b172b78fdb7c1f93 Add user id redirect paths 48f538134b35b0eb5f7a22b3bf195eafcfa1f8fd Add error page for incorrect user ids -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4215/files/01ddd31b3304925333befaa

Re: [openstreetmap/openstreetmap-website] Remove classic pagination (PR #5205)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#5205) Superseded by #6299. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5205#issuecomment-3188729297 You are receiving this because you are subscribed to this thre

Re: [openstreetmap/openstreetmap-website] Remove classic pagination (PR #5205)

Closed #5205. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5205#event-19161114670 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Bump activestorage from 8.0.2 to 8.0.2.1 (PR #6322)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6322) @dependabot rebase -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6322#issuecomment-3186367696 You are receiving this because you are subscribed to this thread

Re: [openstreetmap/openstreetmap-website] Update rails-dom-testing to 2.3.0 (PR #6318)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6318) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6318#issuecomment-3186331483 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Update rails-dom-testing to 2.3.0 (PR #6318)

Merged #6318 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6318#event-19148274339 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 1 commit. f1cd9e7298ce0c11debd48d5812df010bab8b5c9 Remove classic pagination -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6299/files/fa2a07081ef0217e99595b48d726f1275b2ac0b2..f1cd9e7298ce0c11debd48d5812df010bab8b5c9 You are receiving this

Re: [openstreetmap/openstreetmap-website] Update rails-dom-testing to 2.3.0 (PR #6318)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6318) I'd first apply the fixes and after that update rails-dom-testing. That way there won't be any test errors right after the rails-dom-testing commit, in case we'll need to bisect later. -- Reply to this email directly or view

Re: [openstreetmap/openstreetmap-website] Update rails-dom-testing to 2.3.0 (PR #6318)

@AntonKhorev commented on this pull request. > @@ -421,7 +421,7 @@ def test_create post user_blocks_path assert_response :not_found assert_template "users/no_such_user" -assert_select "h1", "The user does not exist" +assert_select "h1", "The user does not exist" This bre

Re: [openstreetmap/openstreetmap-website] Update rails-dom-testing to 2.3.0 (PR #6318)

@AntonKhorev commented on this pull request. > @@ -32,7 +32,7 @@ def test_changeset_details changeset_details_dom = Rails::Dom::Testing.html_document_fragment.parse "#{changeset_details(changeset)}" assert_dom changeset_details_dom, ":root", :text => /^Closed .* by #{changeset.user.d

Re: [openstreetmap/openstreetmap-website] Localize English captions in language picker (Issue #6319)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6319) When you [say](https://github.com/openstreetmap/openstreetmap-website/pull/6313#discussion_r2271709380) > I think we’re going to get people wondering why there’s bits of English that > never change no matter what you set as y

Re: [openstreetmap/openstreetmap-website] Enable scrollable pagination for changeset elements (PR #6316)

@AntonKhorev commented on this pull request. > +@ways = @changeset.old_ways + .order(:way_id, :version) + .offset(ELEMENTS_PER_PAGE * (@current_way_page - 1)) + .limit(ELEMENTS_PER_PAGE) + end + + def load_relations +@relat

Re: [openstreetmap/openstreetmap-website] Add English names to Select Language dialog (PR #6313)

@AntonKhorev commented on this pull request. > - :code: zh-CN :native_name: 中文（简体） + :english_name: Chinese (Simplified) - :code: zh-TW :native_name: 中文（繁體） + :english_name: Chinese (Traditional) - :code: zh-HK :native_name: 中文（香港） + :english_name: Chinese (Hong Kong) You could h

Re: [openstreetmap/openstreetmap-website] Add English names to Select Language dialog (PR #6313)

@AntonKhorev commented on this pull request. > + + <%= language[:english_name] %> + @1ec5 If you propose using `new Intl.DisplayNames([lang], { type: "language" }).of(lang)`, you can open a new issue, then I'll ask you what are your plans for `lang = be-Tarask`, `lang

Re: [openstreetmap/openstreetmap-website] Add English names to Select Language dialog (PR #6313)

@AntonKhorev commented on this pull request. > + + <%= language[:english_name] %> + > I think we can assume that the user has an adequate font for the language > they currently prefer. Not true as soon as you click on any language that doesn't have a font. -- Reply

Re: [openstreetmap/openstreetmap-website] Add English names to Select Language dialog (PR #6313)

@AntonKhorev commented on this pull request. > - :code: zh-CN :native_name: 中文（简体） + :english_name: Chinese (Simplified) - :code: zh-TW :native_name: 中文（繁體） + :english_name: Chinese (Traditional) - :code: zh-HK :native_name: 中文（香港） + :english_name: Chinese (Hong Kong) English nam

Re: [openstreetmap/openstreetmap-website] Introduce scoped placeholder `type:` for element routes (PR #6149)

@AntonKhorev commented on this pull request. > @@ -7,8 +7,10 @@ of the above pages support. The router is initialized with a set of routes: a mapping of URL path templates - to route controller objects. Path templates can contain placeholders - (`/note/:id`) and optional segments (`/:

Re: [openstreetmap/openstreetmap-website] Enable scrollable pagination for changeset elements (PR #6316)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6316) Coverage decrease is because classic pagination is not in use anymore. I didn't remove it in this PR to avoid complaints from Danger, but instead I got complaints from Coveralls. -- Reply to this email directly or view it on

[openstreetmap/openstreetmap-website] Enable scrollable pagination for changeset elements (PR #6316)

Part 3 of https://github.com/openstreetmap/openstreetmap-website/pull/6299. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6316 -- Commit Summary -- * Add load elements methods for changeset controller * Add eleme

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 8 commits. 8c9e4ca1a979c6fd23f43c5602d478fd73dc25fc Add load elements methods for changeset controller b0609622d27e4b37dbfc5c7e662fb051cb29c812 Add elements per page constant for changeset controller d780fcb86423952e1aaf26818a7602e2315c940a Add element_range_values helper

[openstreetmap/openstreetmap-website] Generic scrollable numbered pagination (PR #6314)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6314 -- Commit Summary -- * Rename element_versions_pagination helper to numbered_pagination * Rename top/active version parameters to top/active page * Change ver

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 18 commits. b5d4f363bc38a9f3aae1f18a1f2c581b21a19af5 Rename element_versions_pagination helper to numbered_pagination 6f2ce07c7582cb4e3690a24fb99c2983349ef53c Rename top/active version parameters to top/active page 666df44453e5aa77cc50a510653c381a41cde77f Change version re

[openstreetmap/openstreetmap-website] Add English names to Select Language dialog (PR #6313)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6313 -- Commit Summary -- * Add English names to Select Language dialog * Reset colors of English language name underlines -- File Changes -- M app/assets/styl

[openstreetmap/openstreetmap-website] Fix "Log in with Apple" title (PR #6312)

https://github.com/openstreetmap/openstreetmap-website/commit/fc5f0f2ec064710caba8aa2aa693e0a515f97690#r163725641 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6312 -- Commit Summary -- * Fix "Log in with Apple" ti

Re: [openstreetmap/openstreetmap-website] Make changeset comment count + icon on element pages clickable links to changeset page (Issue #6190)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6190) The same page but not the same link. See the anchor in the diary comments link? https://github.com/user-attachments/assets/b42d04f6-3aa9-4715-8a2d-c56512c038e9"; /> -- Reply to this email directly or view it on GitHub: https

Re: [openstreetmap/openstreetmap-website] Changeset: strange icon with no tooltip (Issue #6311)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6311) Usually these link icons don't have tooltips. However they often are often invisible and appear only on hover. See [Bootstrap docs for example](https://getbootstrap.com/docs/5.3/helpers/icon-link/), they also have `aria-label

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 23 commits. cc6bed9c4e736cbbe920ce74b1219bdc5fb37edd Add empty numbered pagination js module 11676ee915573579e7146b6b717735a74053c44e Move centering active version to numbered pagination js module 00ad4fdc67b31acd0bfe5330a8947fb7d6d1a507 Move breadcrumbs version click to

Re: [openstreetmap/openstreetmap-website] Scrollable pagination javascript module (PR #6304)

@AntonKhorev commented on this pull request. > @@ -5,7 +5,7 @@ const isOfExpectedLanguage = ({ language }) => languagesToRequest[0].startsWith(language) || language === "mul"; $(document).on("click", "a[href='#versions-navigation-active-page-item']", function (e) { -scrollToActiveV

Re: [openstreetmap/openstreetmap-website] Scrollable pagination javascript module (PR #6304)

@AntonKhorev commented on this pull request. > + $(document).on("numbered_pagination:enable", function () { +shadowEffect = new ShadowEffect(); +$(document).trigger("numbered_pagination:center"); + }); + + $(document).on("numbered_pagination:disable", function () { +shadowEffect?.

[openstreetmap/openstreetmap-website] Migrate from @stylistic/eslint-plugin-js to @stylistic/eslint-plugin (PR #6308)

Previously we [picked javascript-only package of stylistic plugin](https://github.com/openstreetmap/openstreetmap-website/pull/5557#discussion_r1941580714) but now they [deprecated it](https://eslint.style/guide/getting-started#plugin). You can view, comment on, or merge this pull request online

[openstreetmap/openstreetmap-website] Fix next page boundary condition for user notes (PR #6307)

Fixes #6283. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6307 -- Commit Summary -- * Fix next page boundary condition for user notes -- File Changes -- M app/controllers/notes_controller.rb (10) M app/v

[openstreetmap/openstreetmap-website] Scrollable pagination javascript module (PR #6304)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6304 -- Commit Summary -- * Add empty numbered pagination js module * Move centering active version to numbered pagination js module * Move breadcrumbs version cli

[openstreetmap/openstreetmap-website] Changeset num_changed_(element type) methods (PR #6305)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6305 -- Commit Summary -- * Shorten changeset count methods * Add changeset counters per element type * Add changeset counters that check db when out of sync -- F

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 26 commits. 4227f3a88d94ad525299c9b8b1f6c83eb82c5cc6 Add empty numbered pagination js module 884a43397ee4c31e17927f5c2f1583ca8c16c441 Move centering active version to numbered pagination js module 2fde1a58b9f4dfdf3bbed9e7866681e0f4281624 Move breadcrumbs version click to

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 1 commit. ad6cbd6eade2db3f0e8a31dc1f9f8bc7a5ee8ab7 WIP fix test for counts optimization -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6299/files/ed40b853ea2904e3bfeb5049fe5cce114de18e8b..ad6cbd6eade2db3f0e8a31dc1f9f8bc7a5ee8ab7 You are rec

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 1 commit. ed40b853ea2904e3bfeb5049fe5cce114de18e8b WIP update actual_num_* -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6299/files/b8e7d8324dcb64c36ca7baf5d3a0291516311922..ed40b853ea2904e3bfeb5049fe5cce114de18e8b You are receiving this b

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 3 commits. 729663aa3fb692d07c69c9ad651876a2a1ef4a16 WIP num_changed_* 7582e8bc2b793c83b4c4e5797d131e181372b9dd WIP optimize changeset element counts b8e7d8324dcb64c36ca7baf5d3a0291516311922 WIP shorten element loads -- View it on GitHub: https://github.com/openstreetmap/op

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 3 commits. 5bfd610ec7e0167014c59992542a23c8eb73eba6 WIP move counter helpers to changeset controller 92fc54d1dac37fa2ccf54c609423c6e68ea5d4b7 WIP clamp element page dffc13bf8da9c9ac639406a52114969da26f146f WIP elements per page const -- View it on GitHub: https://github.c

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 1 commit. b5f9101707eb07d3359bc464642896a724c9a779 WIP more calculations in helpers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6299/files/fad27d7e3e43272d5b142ae13caad3ac6708f31e..b5f9101707eb07d3359bc464642896a724c9a779 You are receivi

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 3 commits. 28008d403178445e652ed873d5710624dd557960 WIP enable/disable events 9dde1349b5cf855d003cdc3562108960a94e7fe1 WIP rename focus event fad27d7e3e43272d5b142ae13caad3ac6708f31e WIP enable shadow effect on changeset pages -- View it on GitHub: https://github.com/open

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 4 commits. 1154759d753e4a8b4cd0bbbfe68430d0db44e2d3 WIP shorten jquery code 3e6896bf8ac1f29a6d411181980b113e32c889ed WIP remove refs to versions from shadow effect 187debb90dd079a674680bf426f1495e5d353bd2 WIP remove ids from helper 0757a2679e0097ae764b68f0c68c74d1facedb56

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 31 commits. 44ba4567511e81b2704d62c21b053d5eb71e0f63 WIP add scrollable pagination 9874a2766feea1aab4c465eeac2b928ff14673a4 WIP turbo d4a63eed9a0f9a3d9c0b74e72c2e1c1723b7a98f WIP title total 1c6f0392c871e5ea0bbcff6159a04e4361714664 WIP pass element counts 8d0b9a9f02282696b4

Re: [openstreetmap/openstreetmap-website] Add support for Apple authentication (PR #6298)

Merged #6298 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6298#event-19041152387 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)

Closed #2799 as completed via fc5f0f2ec064710caba8aa2aa693e0a515f97690. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2799#event-19041152383 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Add support for Apple authentication (PR #6298)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6298) I can't really test it because I don't have the keys. I guess there are reasons why this line doesn't need to be changed: https://github.com/openstreetmap/openstreetmap-website/blob/d8fff3c499653ac492b7ad82dd56fb5ba6dae359/app/

Re: [openstreetmap/openstreetmap-website] osm unusable on mobile because of banner (Issue #6301)

Closed #6301 as completed via #6302. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6301#event-19039765747 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Fix erroneously collapsed CSS rule (PR #6302)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6302) So I guess it wasn't intended to start showing banners in small layouts. Then the next questions are why aren't we showing them and should we start? Maybe we're not showing them because a banner in the corner of the screen vs

Re: [openstreetmap/openstreetmap-website] Fix erroneously collapsed CSS rule (PR #6302)

Merged #6302 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6302#event-19039765507 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Force banner close button inside viewport (PR #6302)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6302) You're fixing a regression from #6271. Banners weren't shown on small layouts prior to that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6302#issuecomment-

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 6 commits. 73ac0100e63add60474c924129f76266108d729e WIP scroll event 17b30a64653f66d1f1cd619f59ab0a40477dbef5 WIP generic click listener 88b130f8cd51191fd5aaed88e6cd04cd4565224e WIP start numbered pagination js 6ad2e9d7cfc1fb5bbdee777d9df850e6422b0e73 WIP remove version ref

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 1 commit. c23113f3256f2a4f3b432bbdec0fee369b2a3a3b WIP pass active item id -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6299/files/37836fa663a0c4ae46c3dcb984e959dececb8bfe..c23113f3256f2a4f3b432bbdec0fee369b2a3a3b You are receiving this b

Re: [openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

@AntonKhorev pushed 23 commits. 8ce28d2584efc2e9d381062ac9aa694d5157f7f7 WIP add scrollable pagination 8ad8874f6f0f28d06bf69a9245347945f2a67d63 WIP turbo 10882b8f695182bde50f31b8894676647ae67864 WIP title total 01f56296f1cab5b68ba7ed581218c867e6caf3f8 WIP pass element counts 10ac16a53ffa260ade

[openstreetmap/openstreetmap-website] Scrollable pagination for changeset elements (PR #6299)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6299 -- Commit Summary -- * WIP a

Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)

@AntonKhorev pushed 7 commits. 743eb6b47dcf8d8baf51b4a1045a467f89783c55 Split api elements controller index tests 9af67a74bb3339d7c84a3e73b69b0545f28d0b9d Test required parameter message in element multi fetch c38bc0f576e1fd70a057b0578558dd73e5aac88f Add generic api elements controller for m

Re: [openstreetmap/openstreetmap-website] Test logout after using turbo pagination (PR #6292)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6292) Was merged in 707ef0667dee1bf3c75d6e0cfdfd0b2f779f7b99 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6292#issuecomment-3156029827 You are receiving this becau

  1   2   3   4   5   6   7   8   9   10   >