Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
Closed #5255. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255#event-15027313160 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
I opened new PR #5297 according to suggestion here. Closing this as not planed for now. > You can make a pull request that just adds the status filter. That doesn't > depend on pagination and shouldn't tank the performance because: > > - status is checked anyway to see if the note is not hidden > > - we're doing a similar thing in the api -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2449349900 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
@kcne pushed 1 commit. ec7668874ba6da72d718661746baf5460c37012e Remove filtering by interaction. Group status by open, closed and commented -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/900b9153f3daecf2bc8bcf3e10ac6a5cfc380a8d..ec7668874ba6da72d718661746baf5460c37012e You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
As for splitting this into multiple smaller PRs, I would prefer we merge this as a complete feature/functionality. Adding filters one by one would significantly increase the time required and might leave the feature feeling incomplete. This PR covers all the intended functionality cohesively, and it seems better to refine and adjust post-merge if needed rather than delay further by segmenting the changes. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2435237921 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
> 3. When you mentioned "blue on blue" colors I'm not sure if this is something > I've introduced in this PR Obviously you didn't introduce it. That comment was made in July. > since when I toggle dark mode on my end everything is looking fine. Check it when the note is colored as "submitted". -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2435264671 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
> Yes, the goal was to implement the filters that were most commonly requested > and improve the feature based on that feedback. Where are these requests? For example #832 wants status filter but doesn't say anything about date ranges. Why would a status filter be incomplete without a date range filter? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2435347487 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
> Time for what? For PR review? Exactly, since each PR would need to be reviewed sequentially, it would prolong the overall process. > Are you sure? Is it complete with exactly the filters you added and not some > other filters? Yes, the goal was to implement the filters that were most commonly requested and improve the feature based on that feedback. However, if you have any suggestions for additional filters that could enhance the usability for mappers, I’m definitely open to discussing and considering those ideas too. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2435315280 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
> Adding filters one by one would significantly increase the time required Time for what? For PR review? > and might leave the feature feeling incomplete. Are you sure? Is it complete with exactly the filters you added and not some other filters? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2435272945 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
@kcne pushed 1 commit. 900b9153f3daecf2bc8bcf3e10ac6a5cfc380a8d Remove filtering by interaction. Group status by open, closed and commented -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/cc6c281028aef5983500b62091321f4b215bba3c..900b9153f3daecf2bc8bcf3e10ac6a5cfc380a8d You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)
@kcne pushed 1 commit. cc6c281028aef5983500b62091321f4b215bba3c Remove filtering by interaction. Group status by open, closed and commented -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/8725d95265e95b1b16610bbc6d483a0afffe9d9e..cc6c281028aef5983500b62091321f4b215bba3c You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
