Re: [RP] Unresponsive after 'tmpwm' ?

2015-11-17 Thread Antoine Busque
l X via Ctrl-alt-bksp. I haven't tested on master yet. I know however that the unresponsiveness issue when exiting the tmpwm is not new from the current stable version, as I've encountered it systematically for a while. I'll try and investigate the issue later this week, if I can rep

[RP] [PATCH] Show frame indicator on focus* invocations

2017-06-26 Thread Antoine Busque
to a completely different one, without any indication of the current frame, provided that the newly focused screen has a single window. Instead, show the current frame indicator regardless of number of frames whenever invoking `focus*`. Signed-off-by: Antoine Busque --- src/actions.c | 16

[RP] [PATCH] Fix: check frame overlap in find_frame_left, find_frame_right

2017-06-26 Thread Antoine Busque
other. The boundary checks have therefore been corrected to mirror those in `find_frame_{up,down}`, and check for actual overlap between the frames. Signed-off-by: Antoine Busque --- src/split.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/split.c b/src/split.c index

Re: [RP] [PATCH] Show frame indicator on focus* invocations

2017-07-08 Thread Antoine Busque
On Mon, Jul 3, 2017 at 11:58 PM, Jeremie Courreges-Anglas wrote: > > [...] > > I like the idea, however... why the show_frame_indicator(0) -> > show_frame_indicator(1) changes below? > > Right now, if the focus{up,down,left,right} commands can't find an > appropriate frame, they'll stay silent if

Re: [RP] libhistory-support.

2017-08-01 Thread Antoine Busque
biquitous and probably more likely to be already present on the system than many other libraries). [0] https://github.com/abusque/ratpoison/tree/fix-history-expand Best Regards, Antoine Busque. > Btw, i'm sorry I cannot contribute myself (yet), as a noob in C programming, > but im

[RP] [PATCH] Fix: call using_history after initializing history entries

2017-08-02 Thread Antoine Busque
performing initialization of history entries found in `history_expand_line`. This allows for `history_offset` to reflect the now non-zero length of the history, restoring the expected behaviour of history expansion. Tested-by: Martin Hertz Signed-off-by: Antoine Busque --- src/history.c | 2 +- 1 fi

[RP] [PATCH] Fix: sync wins correctly after tmpwm for multiple screens

2017-08-06 Thread Antoine Busque
indow` utility function to prevent a special ratpoison window from being mapped, regardless of the screen it belongs to. Signed-off-by: Antoine Busque --- src/actions.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/actions.c b/src/actions.c index a044f7a..21

[RP] [PATCH] Fix: only set active frame when needed in sync_wins

2017-08-06 Thread Antoine Busque
Only set the active frame after destryoing a normal window in `sync_wins` if this window was on the current screen. This mirrors the behaviour already found in other functions like `unmap_notify`, `destroy_notify`, etc. Signed-off-by: Antoine Busque --- src/actions.c | 3 ++- 1 file changed, 2

[RP] [PATCH] Fix: don't draw help window beyond screen height

2017-09-21 Thread Antoine Busque
e true edge of the screen, and therefore cut off. Simply using `s->height` corrects this issue, and the help window gets drawn properly even on multi-screen setups with differently sized screens. Signed-off-by: Antoine Busque --- src/actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[RP] [PATCH] Fix: draw the license text centered on multi-screen setup

2017-09-21 Thread Antoine Busque
rent screen, causing the text to be rendered off-screen. Simply removing the top and left values from the computation fixes this issue and allows the license text to be drawn centered on the current screen, even in multi-screen setups with differently sized screens. Signed-off-by: Antoine Busque --- sr

[RP] [PATCH] Fix: exclude degenerate case from frame overlap

2018-02-05 Thread Antoine Busque
valid frame overlap. Signed-off-by: Antoine Busque --- src/split.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/src/split.c b/src/split.c index eed0f50..1c7d8b5 100644 --- a/src/split.c +++ b/src/split.c @@ -1000,6 +1000,28

Re: [RP] Segfault and faulty focus (related regressions after v1.4.8)

2019-07-15 Thread Antoine Busque
On Mon, Jul 15, 2019 at 12:01 PM Axel Svensson wrote: > > I have found 3 regressions in ratpoison. They seem somewhat related. > > Regression 1: Segfault at startup. > > Regression 2: Faulty :focusup and :focusdown > > Regression 3: Faulty :focusright > Hi Axel, Thanks a lot for the detailed rep