Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-09 Thread Tim Keitt
Yup, that example is really helpful. Note that if you do: the_list.attr("row.names") = IntegerVector::create(NA_INTEGER, -nrow); it will create implicit row names from 1:nrow. The number of rows must be negative. THK On Sun, Jun 8, 2014 at 8:03 PM, Dmitry Nesterov wrote: > Dirk, > The exam

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-08 Thread Dmitry Nesterov
Dirk, The example that you provided in the link to the Rcpp Gallery has been very helpful. Thank you for pointing it out, it did speed up my data frame creation code significantly. It allows me to use Rcpp where I used C api and keep practically the same speed of execution. Best, Dmitry On Jun

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-08 Thread Dirk Eddelbuettel
On 8 June 2014 at 13:33, Christian Gunning wrote: | Hello list, long time no see! Indeed :) | Dmitry, | Have you identified any other consequences than what Romain pointed | out? This information would be useful for the rest of us. | | Some key points that I agree with: | * as per Dirk: this

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-08 Thread Dmitry Nesterov
Gunning wrote: >> Subject: Re: [Rcpp-devel] Speed up of the data.frame creation in >> DataFrame.h >> Message-ID: <757ef798-6bc6-4150-93cd-b5f23d901...@gmail.com> >> Content-Type: text/plain; charset=windows-1252 >> >> The fix I was proposing ac

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-08 Thread Christian Gunning
> Subject: Re: [Rcpp-devel] Speed up of the data.frame creation in > DataFrame.h > Message-ID: <757ef798-6bc6-4150-93cd-b5f23d901...@gmail.com> > Content-Type: text/plain; charset=windows-1252 > > The fix I was proposing actually has implications much deeper than I

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-07 Thread Dmitry Nesterov
The fix I was proposing actually has implications much deeper than I thought. I would need to investigate further and will take no action at this time. On Jun 6, 2014, at 10:47 PM, Dirk Eddelbuettel wrote: > > On 6 June 2014 at 22:16, Dmitry Nesterov wrote: > | It was even simpler, I just ran

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-07 Thread Romain François
Hello, I was merely pointing out the problem. People who maintain and contribute to Rcpp will tell you what they expect. I am no longer one of them. So I don’t really care either way, unless it starts adding a bug that will cause issues for software I’m involved with that still has to depend o

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-07 Thread Dmitry Nesterov
Hello Romain, maybe then another function, like force_create() could be available? Or some checks for equal number of elements in each vector. One of the main Rcpp advantages to the user is its flexibility and speed, compared to the plain R code. I am not sure at this point what solution would be

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-07 Thread Romain François
Le 7 juin 2014 à 03:27, Dmitry Nesterov a écrit : > Hello, > Here I report the slowness in creation of Rcpp DataFrame objects and proposed > change to speed it up. > For system information, here is output from sessionInfo(): > R version 3.1.0 (2014-04-10) > Platform: x86_64-apple-darwin13.1.0 (

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-06 Thread Dirk Eddelbuettel
On 6 June 2014 at 22:16, Dmitry Nesterov wrote: | It was even simpler, I just ran install.package(“Rcpp") in R and it pulled in all the headers… Which version? Was that recently? | I have found the repo, will do the change and then the pull request, | I assume the regression tests are done on

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-06 Thread Dmitry Nesterov
Dirk, It was even simpler, I just ran install.package(“Rcpp") in R and it pulled in all the headers… I have found the repo, will do the change and then the pull request, I assume the regression tests are done on your side? Dmitry On Jun 6, 2014, at 10:11 PM, Dirk Eddelbuettel wrote: > > On 6 J

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-06 Thread Dirk Eddelbuettel
On 6 June 2014 at 22:00, Dmitry Nesterov wrote: | Where is the Rcpp git repository that I can fork? Does it have a description of regression environment too? It is listed in the DESCRIPTION of the package. Which source version did you work from? Did you just use a tarball from CRAN? Dirk --

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-06 Thread Dmitry Nesterov
Dirk, Where is the Rcpp git repository that I can fork? Does it have a description of regression environment too? Thanks, Dmitry On Jun 6, 2014, at 9:58 PM, Dirk Eddelbuettel wrote: > > Dmitry, > > On 6 June 2014 at 21:41, Dmitry Nesterov wrote: > | I would try to do that, although I only hav

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-06 Thread Dirk Eddelbuettel
Dmitry, On 6 June 2014 at 21:41, Dmitry Nesterov wrote: | I would try to do that, although I only have the Mac OSX 10.9.3 to work on. The OS should not matter. Rcpp works on Linux, OS X and Windows. | If this is ok for regression tests, then where can I get instructions on where to fork from

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-06 Thread Dmitry Nesterov
Dirk, I would try to do that, although I only have the Mac OSX 10.9.3 to work on. If this is ok for regression tests, then where can I get instructions on where to fork from and how to run the tests? Best, Dmitry On Jun 6, 2014, at 9:36 PM, Dirk Eddelbuettel wrote: > > Dmitry, > > At first g

Re: [Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-06 Thread Dirk Eddelbuettel
Dmitry, At first glance, this looks like good detective / debugging work on your end. Now, our preferred way of getting code into Rcpp would involve you forking the repo and submitting a pull request. The chief advantage of that approach is that it would run all regression tests in the standard

[Rcpp-devel] Speed up of the data.frame creation in DataFrame.h

2014-06-06 Thread Dmitry Nesterov
Hello, Here I report the slowness in creation of Rcpp DataFrame objects and proposed change to speed it up. For system information, here is output from sessionInfo(): R version 3.1.0 (2014-04-10) Platform: x86_64-apple-darwin13.1.0 (64-bit) ... other attached packages: [1] microbenchmark_1.3-0 Rcp