Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-04-02 Thread Dirk Eddelbuettel
On 2 April 2013 at 20:28, Romain Francois wrote: | Should be back to normal now. Indeed, looks good -- thanks a bunch! Dirk -- Dirk Eddelbuettel | e...@debian.org | http://dirk.eddelbuettel.com ___ Rcpp-devel mailing list Rcpp-devel@lists.r-forge.r-p

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-04-02 Thread Romain Francois
Le 02/04/13 20:04, Chenliang Xu a écrit : Maybe not. I think a function in library should do only one thing, and for DataFrame::create it is building a data.frame. If the users wish to convert string to factor, one should do it explicitly, may with a help function such as `stringsToFactor` or `as

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-04-02 Thread Chenliang Xu
Maybe not. I think a function in library should do only one thing, and for DataFrame::create it is building a data.frame. If the users wish to convert string to factor, one should do it explicitly, may with a help function such as `stringsToFactor` or `as.factor`. stringsAsFactor is an important fe

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-04-02 Thread Dirk Eddelbuettel
On 2 April 2013 at 17:37, Romain Francois wrote: | Le 02/04/13 17:33, Dirk Eddelbuettel a écrit : | > | > On 2 April 2013 at 17:16, Romain Francois wrote: | > | Do we really need this feature ? | > | > I like to maintain existing APIs and interfaces. | > | > I haven't had time to look at how you n

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-04-02 Thread Dirk Eddelbuettel
On 2 April 2013 at 17:16, Romain Francois wrote: | Do we really need this feature ? I like to maintain existing APIs and interfaces. I haven't had time to look at how you now impletement the DataFrame ctor via List -- but is there no way to catch that stringsAsFactor yes/no choice and accomida

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-04-02 Thread Romain Francois
Le 02/04/13 17:01, Dirk Eddelbuettel a écrit : On 2 April 2013 at 16:36, Romain Francois wrote: | Le 29/03/13 16:37, Dirk Eddelbuettel a écrit : | > | > On 29 March 2013 at 16:20, rom...@r-enthusiasts.com wrote: | > | Cool. I'll have a look when I'm back from easter weekend. | > | > Sounds good.

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-04-02 Thread Dirk Eddelbuettel
On 2 April 2013 at 16:36, Romain Francois wrote: | Le 29/03/13 16:37, Dirk Eddelbuettel a écrit : | > | > On 29 March 2013 at 16:20, rom...@r-enthusiasts.com wrote: | > | Cool. I'll have a look when I'm back from easter weekend. | > | > Sounds good. | > | > And that point, it would be really nice

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-04-02 Thread Romain Francois
Le 29/03/13 16:37, Dirk Eddelbuettel a écrit : On 29 March 2013 at 16:20, rom...@r-enthusiasts.com wrote: | Cool. I'll have a look when I'm back from easter weekend. Sounds good. And that point, it would be really nice if you could also restore the ability to build Rcpp, which appears to have

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread Kevin Ushey
Great. Thanks for the quick response and all the work you and Romain put into Rcpp! -Kevin On Fri, Mar 29, 2013 at 9:35 AM, Dirk Eddelbuettel wrote: > > On 29 March 2013 at 08:48, Kevin Ushey wrote: > | Thanks for the quick responses. > > Thanks for the reproducible bug report. > > In (some ver

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread Dirk Eddelbuettel
On 29 March 2013 at 08:48, Kevin Ushey wrote: | Thanks for the quick responses. Thanks for the reproducible bug report. In (some version of) Rcpp 0.10.3.1 [1] you can now use your function again: R> sourceCpp("/tmp/kevin.cpp") R> set.seed(42) R> x <- sample(1:10, 20, replace=TRUE) R> table(x

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread Kevin Ushey
Thanks for the quick responses. It seems counter-productive for R Core to be removing API entry points, at least doing so without informing package maintainers of newly implemented and tested alternatives. I wonder if it's due to the introduction of 'long' vectors, and the team decided it would be

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread Dirk Eddelbuettel
On 29 March 2013 at 16:20, rom...@r-enthusiasts.com wrote: | Cool. I'll have a look when I'm back from easter weekend. Sounds good. And that point, it would be really nice if you could also restore the ability to build Rcpp, which appears to have broken with your Data.Frame patch. Details are b

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread romain
Cool. I'll have a look when I'm back from easter weekend. Romain Le 2013-03-29 16:00, Dirk Eddelbuettel a écrit : On 29 March 2013 at 09:40, Dirk Eddelbuettel wrote: | | On 29 March 2013 at 15:24, rom...@r-enthusiasts.com wrote: | | Le 2013-03-29 14:31, Dirk Eddelbuettel a écrit : | | > On 29 M

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread Dirk Eddelbuettel
On 29 March 2013 at 09:40, Dirk Eddelbuettel wrote: | | On 29 March 2013 at 15:24, rom...@r-enthusiasts.com wrote: | | Le 2013-03-29 14:31, Dirk Eddelbuettel a écrit : | | > On 29 March 2013 at 09:11, rom...@r-enthusiasts.com wrote: | | > | | | > | Hello, | | > | | | > | This is related to this c

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread Dirk Eddelbuettel
On 29 March 2013 at 15:24, rom...@r-enthusiasts.com wrote: | Le 2013-03-29 14:31, Dirk Eddelbuettel a écrit : | > On 29 March 2013 at 09:11, rom...@r-enthusiasts.com wrote: | > | | > | Hello, | > | | > | This is related to this change: | > | | > | 2013-01-15 Dirk Eddelbuettel | > | | > | * sr

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread romain
Le 2013-03-29 14:31, Dirk Eddelbuettel a écrit : On 29 March 2013 at 09:11, rom...@r-enthusiasts.com wrote: | | Hello, | | This is related to this change: | | 2013-01-15 Dirk Eddelbuettel | | * src/api.cpp (Rcpp): Commented-out coerce_to_string() for real and | complex arguments as R-

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread Dirk Eddelbuettel
On 29 March 2013 at 09:11, rom...@r-enthusiasts.com wrote: | | Hello, | | This is related to this change: | | 2013-01-15 Dirk Eddelbuettel | | * src/api.cpp (Rcpp): Commented-out coerce_to_string() for real and | complex arguments as R-devel (as of today) dislikes use of non-API

Re: [Rcpp-devel] Bug with table sugar and NumericVector in Rcpp 0.10.3

2013-03-29 Thread romain
Hello, This is related to this change: 2013-01-15 Dirk Eddelbuettel * src/api.cpp (Rcpp): Commented-out coerce_to_string() for real and complex arguments as R-devel (as of today) dislikes use of non-API functions Rf_EncodeComplex’, ‘Rf_EncodeReal’, ‘Rf_formatComplex’