Re: reiser4 plugins

2005-07-12 Thread Neil Brown
On Monday July 11, [EMAIL PROTECTED] wrote: Stefan Smietanowski wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ok, still haven't heard much discussion of metafs vs file-as-directory, but it seems like it'd be easier in metafs. Why not implement it inside the directory

Re: reiser4 plugins

2005-07-12 Thread Hans Reiser
Neil Brown wrote: Maybe it is worth repeating Al Viro's suggestion at this point. I don't have a reference but the idea was basically that if you open /foo and get filedescriptor N, then /proc/self/fds/N-meta is a directory which contains all the meta stuff for /foo. Then it is trivial to

[PATCH/URL] reiserfs: reformat code with Lindent

2005-07-12 Thread Jeff Mahoney
The ReiserFS code is a mix of a number of different coding styles, sometimes different even from line-to-line. Since the code has been relatively stable for quite some time and there are few outstanding patches to be applied, it is time to reformat the code to conform to the Linux style

Re: [PATCH/URL] reiserfs: reformat code with Lindent

2005-07-12 Thread Alexey Dobriyan
On Tuesday 12 July 2005 23:42, Jeff Mahoney wrote: The ReiserFS code is a mix of a number of different coding styles, sometimes different even from line-to-line. Since the code has been relatively stable for quite some time and there are few outstanding patches to be applied, it is time to

Re: reiser4 plugins

2005-07-12 Thread David Masover
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Neil Brown wrote: On Monday July 11, [EMAIL PROTECTED] wrote: Stefan Smietanowski wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ok, still haven't heard much discussion of metafs vs file-as-directory, but it seems like it'd be easier in

Re: reiser4 plugins

2005-07-12 Thread David Masover
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hans Reiser wrote: Horst von Brand wrote: Hans Reiser [EMAIL PROTECTED] wrote: Stefan Smietanowski wrote: I think ... and .meta both serve as a logical delimiter. However some programs implement their own ... which would make it clash

Re: [PATCH/URL] reiserfs: reformat code with Lindent

2005-07-12 Thread Linus Torvalds
On Tue, 12 Jul 2005, Jeff Mahoney wrote: This patch contains the result of running scripts/Lindent against fs/reiserfs/*.c and include/linux/reiserfs_*.h. That can't be true. It isn't actually following the Lindent rules. It has that braindamaged put the type on a separate line thing for

Re: [PATCH/URL] reiserfs: reformat code with Lindent

2005-07-12 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus Torvalds wrote: On Tue, 12 Jul 2005, Jeff Mahoney wrote: This patch contains the result of running scripts/Lindent against fs/reiserfs/*.c and include/linux/reiserfs_*.h. That can't be true. It isn't actually following the Lindent rules.

[PATCH] reiserfs: fix up case where indent misreads the code

2005-07-12 Thread Jeff Mahoney
indent(1) doesn't know how to handle the do not compile error. It results in the item_ops array declaration being indented a tab stop in when it should not be. This patch replaces it with a #error that describes why it's failing. Signed-off-by: Jeff Mahoney [EMAIL PROTECTED] diff -ruNpX

[PATCH/SCRIPT] reiserfs: run scripts/Lindent on reiserfs code

2005-07-12 Thread Jeff Mahoney
The attached script runs scripts/Lindent against fs/reiserfs.c and include/linux/reiserfs_*.h It's a quick one-liner consisting of: scripts/Lindent fs/reiserfs/*.c include/linux/reiserfs_*.h -Jeff -- Jeff Mahoney SuSE Labs reiserfs-lindent.sh Description: Bourne shell script

Re: reiser4 plugins

2005-07-12 Thread Hans Reiser
David Masover wrote: That's why we're trying to find something that people won't actually touch, especially since if we design it right, this will be the last delimiter introduced at the fs/vfs level. Uh, no, there needs to be about a dozen or so more. But not this year.

Re: reiser4 plugins

2005-07-12 Thread Neil Brown
On Tuesday July 12, [EMAIL PROTECTED] wrote: Maybe it is worth repeating Al Viro's suggestion at this point. I don't have a reference but the idea was basically that if you open /foo and get filedescriptor N, then /proc/self/fds/N-meta How am I supposed to get there with a shell

Re: reiser4 plugins

2005-07-12 Thread Neil Brown
On Tuesday July 12, [EMAIL PROTECTED] wrote: Neil Brown wrote: Maybe it is worth repeating Al Viro's suggestion at this point. I don't have a reference but the idea was basically that if you open /foo and get filedescriptor N, then /proc/self/fds/N-meta is a directory which

Re: reiser4 plugins

2005-07-12 Thread Hans Reiser
Neil Brown wrote: On Tuesday July 12, [EMAIL PROTECTED] wrote: Neil Brown wrote: Maybe it is worth repeating Al Viro's suggestion at this point. I don't have a reference but the idea was basically that if you open /foo and get filedescriptor N, then /proc/self/fds/N-meta is a

Re: reiser4 plugins

2005-07-12 Thread Horst von Brand
David Masover [EMAIL PROTECTED] wrote: Hans Reiser wrote: Horst von Brand wrote: Hans Reiser [EMAIL PROTECTED] wrote: Stefan Smietanowski wrote: [...] Better to spend one's mind looking for bugs instead of this issue. .if bugs were seen as such a big deal. I think it's far

Re: reiser4 plugins

2005-07-12 Thread David Masover
Hans Reiser wrote: David Masover wrote: That's why we're trying to find something that people won't actually touch, especially since if we design it right, this will be the last delimiter introduced at the fs/vfs level. Uh, no, there needs to be about a dozen or so more. Where? From

Re: [PATCH/SCRIPT] reiserfs: run scripts/Lindent on reiserfs code

2005-07-12 Thread Linus Torvalds
On Tue, 12 Jul 2005, Jeff Mahoney wrote: scripts/Lindent fs/reiserfs/*.c include/linux/reiserfs_*.h Ok, applied. You should check that you got the same results I did, and feel free to send further cleanup patches. Sometimes indent does some silly things. Linus