Re: Freeze break exception for the new lock screen

2020-02-14 Thread Matthias Clasen via release-team
On Fri, Feb 14, 2020 at 1:17 PM Michael Catanzaro wrote: > On Fri, Feb 14, 2020 at 10:10 am, Allan Day wrote: > > I thought we got the freeze break. We did get it, didn't we?! > > No, you need two approvals to break the freeze, but you only received a > single approval from me. Somebody else

Re: Freeze break exception for the new lock screen

2020-02-14 Thread Michael Catanzaro
On Fri, Feb 14, 2020 at 10:10 am, Allan Day wrote: I thought we got the freeze break. We did get it, didn't we?! No, you need two approvals to break the freeze, but you only received a single approval from me. Somebody else would need to give a second approval.

Re: Freeze break exception for the new lock screen

2020-02-14 Thread Allan Day
Michael Catanzaro wrote: ... > > It is equally not smart to never land the things we've worked on for > > years just because we put ourselves under the pressure of yet another > > deadlne. > > So far this exception has only one of two required approvals. Do you > want to give the second approval?

Re: Freeze break exception for the new lock screen

2020-02-05 Thread Michael Catanzaro
On Fri, Jan 31, 2020 at 3:22 am, Matthias Clasen wrote: It is equally not smart to never land the things we've worked on for years just because we put ourselves under the pressure of yet another deadlne. So far this exception has only one of two required approvals. Do you want to give the

Re: Freeze break exception for the new lock screen

2020-01-31 Thread Matthias Clasen via release-team
On Tue, Jan 28, 2020 at 1:37 PM Allan Day wrote: > Michael Catanzaro wrote: > > > Would it be possible to arrange a freeze exception for the lock > > > screen work, so we can plan on having another week to get it merged? > > > We don't expect there to be any new strings and I'm happy to > > >

Re: Freeze break exception for the new lock screen

2020-01-30 Thread Michael Catanzaro
Thanks Allan! Since you put in the effort to create a very detailed test plan, I will give the first of two required +1s for this freeze exception, even though the code isn't quite ready yet. I suggest we allow an extra two weeks for the login screen work, until February 15 (the 3.35.91

Re: Freeze break exception for the new lock screen

2020-01-30 Thread Allan Day
An initial version of the test plan can be found here: https://gitlab.gnome.org/Teams/Design/os-mockups/issues/44 Allan On Wed, 29 Jan 2020 at 11:38, Allan Day wrote: > > Michael Catanzaro wrote: > ... > > There are many, many, many more like these. Sorry for sending so many > > mails to this

Re: Freeze break exception for the new lock screen

2020-01-29 Thread Allan Day
Michael Catanzaro wrote: ... > There are many, many, many more like these. Sorry for sending so many > mails to this thread, but I just happen to remember this is a > particularly fragile portion of the codebase. ... Thanks, I'll try and include those in the test plan. I still feel that these

Re: Freeze break exception for the new lock screen

2020-01-28 Thread Michael Catanzaro
From https://gitlab.gnome.org/GNOME/gnome-shell/commits/master/js/gdm, some telling examples of what could break: "If the user fails to enter their password then hits escape, we jump back to the user list, then ask again for a password in a garbled screen. this commit fixes that by skipping

Re: Freeze break exception for the new lock screen

2020-01-28 Thread Michael Catanzaro
On Tue, Jan 28, 2020 at 1:11 pm, Michael Catanzaro wrote: Including the login screen as well, it becomes more complicated. In the distant past we've had a *lot* of weird bugs in edge cases. E.g. type password then click cancel, select a different user, try to log in again. Does it work? Does

Re: Freeze break exception for the new lock screen

2020-01-28 Thread Allan Day
Michael Catanzaro wrote: > > Would it be possible to arrange a freeze exception for the lock > > screen work, so we can plan on having another week to get it merged? > > We don't expect there to be any new strings and I'm happy to > > coordinate with docs and marketing. > > Certainly possible,

Re: Freeze break exception for the new lock screen

2020-01-28 Thread Michael Catanzaro
On Tue, Jan 28, 2020 at 12:08 pm, Allan Day wrote: Would it be possible to arrange a freeze exception for the lock screen work, so we can plan on having another week to get it merged? We don't expect there to be any new strings and I'm happy to coordinate with docs and marketing. Certainly

Freeze break exception for the new lock screen

2020-01-28 Thread Allan Day
Hi Release Team, You might be aware that we've had plans for a redesigned lock screen for some time. Development on this has been proceeding this cycle. Some of it has landed already, and the other pieces are close to being ready (see my review here