Re: Freeze break request: EDS phone number support functions

2013-03-07 Thread Frederic Peters
Hi, Mathias Hasselmann wrote: I want do land the attached patch. It adds GError arguments to the functions e_phone_number_get_country_code_for_region() and e_phone_number_get_default_region(). This is to permit better error handling and to avoid unit tests to break because of warnings, if

Re: Freeze break request: EDS phone number support functions

2013-03-07 Thread Mathias Hasselmann
Am Donnerstag, den 07.03.2013, 14:34 +0100 schrieb Frederic Peters: Hi, Mathias Hasselmann wrote: I want do land the attached patch. It adds GError arguments to the functions e_phone_number_get_country_code_for_region() and e_phone_number_get_default_region(). This is to permit better

Re: Freeze break request: EDS phone number support functions

2013-03-07 Thread Andre Klapper
On Thu, 2013-03-07 at 15:11 +0100, Mathias Hasselmann wrote: The functions in question were newly introduced within the 3.8 cycle and to far they only are used within EDS itself and outside of GNOME. r-t approval 1 of 2. andre -- Andre Klapper | ak...@gmx.net

Re: Freeze break request: EDS phone number support functions

2013-03-07 Thread Frederic Peters
Andre Klapper wrote: On Thu, 2013-03-07 at 15:11 +0100, Mathias Hasselmann wrote: The functions in question were newly introduced within the 3.8 cycle and to far they only are used within EDS itself and outside of GNOME. r-t approval 1 of 2. Seconded; thanks Mathias! Fred