Re: GNOME Shell freeze break request

[mcatanzaro]

On Thu, Sep 5, 2019 at 7:45 AM, Emmanuele Bassi  
wrote:

RT approval 1/2.


Approval 2/2


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: GNOME Shell freeze break request

[Emmanuele Bassi]

On , Iain Lane wrote:

I discovered this morning¹ that if you toggle mute/unmute in Shell
3.33.90 then your volume is not restored to what it was before - it's
left at 0. The reason is that Shell's volume slider responds to the
initial muting by setting itself to empty, but this also triggers the
slider's callback to update Pulseaudio with a level of 0.

(I also have noticed that when you log in to a new session then the
volume is set to 0 each time and this doesn't happen any more with this
patch, but I haven't proved that bug so this is more of an aside that
the effect might be greater than the mute/unmute case.)

We had a similar bug with the brightness slider, which Florian fixed by
blocking the signal handlers when updating the slider's value in
response to an external change (commit referenced in the below MR). The
fix here is the same -it's just that volume case was overlooked 
earlier.

It's already been pre-approved by Carlos (thanks).

  https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/703

This bug is kind of lame - I think it'd be good to fix for 3.34.


This looks like a "paper cut" issue, but the change is small and not 
very intrusive, so might as well get into 3.34.0.


I do hope we have reached the end of the gnome-shell freeze break 
requests, though.


RT approval 1/2.

Ciao,
 Emmanuele.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

GNOME Shell freeze break request

[Iain Lane]

I discovered this morning¹ that if you toggle mute/unmute in Shell
3.33.90 then your volume is not restored to what it was before - it's
left at 0. The reason is that Shell's volume slider responds to the
initial muting by setting itself to empty, but this also triggers the
slider's callback to update Pulseaudio with a level of 0.

(I also have noticed that when you log in to a new session then the
volume is set to 0 each time and this doesn't happen any more with this
patch, but I haven't proved that bug so this is more of an aside that
the effect might be greater than the mute/unmute case.)

We had a similar bug with the brightness slider, which Florian fixed by
blocking the signal handlers when updating the slider's value in
response to an external change (commit referenced in the below MR). The
fix here is the same -it's just that volume case was overlooked earlier.
It's already been pre-approved by Carlos (thanks).

  https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/703

This bug is kind of lame - I think it'd be good to fix for 3.34.

Cheers,

-- 
Iain Lane  [ i...@orangesquash.org.uk ]
Debian Developer   [ la...@debian.org ]
Ubuntu Developer   [ la...@ubuntu.com ]

¹ But someone had already reported
  https://gitlab.gnome.org/GNOME/gnome-shell/issues/1557


signature.asc
Description: PGP signature
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell freeze break request

[Michael Catanzaro]

On Tue, Sep 12, 2017 at 1:38 PM, Andre Klapper  wrote:

r-t approval 1 of 2.


2/2

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell freeze break request

[Andre Klapper]

On Tue, 2017-09-12 at 19:44 +0200, Marc-Antoine Perennou wrote:
> Hi,
> 
> I known this is *really* late in the cycle, but there currently is a
> bug allowing any extension using StEntry to crash the whole
> gnome-shell process.
> The fix is really trivial and available there:
> https://bugzilla.gnome.org/show_bug.cgi?id=787580

r-t approval 1 of 2.

andre
-- 
Andre Klapper  |  ak...@gmx.net
http://blogs.gnome.org/aklapper/
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

gnome-shell freeze break request

[Marc-Antoine Perennou]

Hi,

I known this is *really* late in the cycle, but there currently is a
bug allowing any extension using StEntry to crash the whole
gnome-shell process.
The fix is really trivial and available there:
https://bugzilla.gnome.org/show_bug.cgi?id=787580

Regards,
Marc-Antoine
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell freeze break request

[Matthias Clasen]

On Wed, Mar 18, 2015 at 12:22 PM, Frederic Peters fpet...@gnome.org wrote:
 Ray Strode wrote:
 Hi guys,

 A change that went in before 3.15.92 broke the session chooser:

 https://bugzilla.gnome.org/show_bug.cgi?id=740142

 I'd like to revert the changes until we come up with a better solution.

 Sound good?

 Ok #.


Sounds good to me too.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell freeze break request

[Frederic Peters]

Ray Strode wrote:
 Hi guys,
 
 A change that went in before 3.15.92 broke the session chooser:
 
 https://bugzilla.gnome.org/show_bug.cgi?id=740142
 
 I'd like to revert the changes until we come up with a better solution.
 
 Sound good?

Ok #.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

gnome-shell freeze break request

[Ray Strode]

Hi guys,

A change that went in before 3.15.92 broke the session chooser:

https://bugzilla.gnome.org/show_bug.cgi?id=740142

I'd like to revert the changes until we come up with a better solution.

Sound good?
--Ray
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

gnome-shell: Freeze break request

[drago01]

Hi,

I'd like to ask for a freeze break for
https://bugzilla.gnome.org/show_bug.cgi?id=708472
It just increases the width of the menu by 20px to make translated
strings fit. It is just a css change so should be pretty safe.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell: Freeze break request

[Matthias Clasen]

On Mon, Sep 23, 2013 at 1:30 PM, Frederic Peters fpet...@gnome.org wrote:
 drago01 wrote:
 Hi,

 I'd like to ask for a freeze break for
 https://bugzilla.gnome.org/show_bug.cgi?id=708472
 It just increases the width of the menu by 20px to make translated
 strings fit. It is just a css change so should be pretty safe.

 And I hereby approve the next patch adding another 20px because
 another language will need them.  Seriously, +1 for this one but pixel
 layouts do not work well with translated strings and we have various
 issues every cycle, I hope we can give it more attention during design
 and development in next cycle.


This is just a short-term fix for 3.10 - removing the hardcoded width
solves the string length problem, but makes the menu resize in an
unfortunate way when opening and closing submenus.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Another GNOME Shell freeze break request ...

[Florian Müllner]

Hey,

I'd like to request another app-picker related freeze break for bug
694710. Currently the frequent view shows up empty when there isn't
any usage data yet (e.g. on a fresh install).
With the patches from the aforementioned bug, we will open the all
view in that case, and show a short explanation in frequent view[0].
Given that this is dealing with a corner case, I doubt the change will
have any effect on existing documention.

Cheers,
Florian

[0] https://people.gnome.org/~fmuellner/empty-frequent-view.png
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Another GNOME Shell freeze break request ...

[Shaun McCance]

On Mon, 2013-09-02 at 17:38 +0200, Florian Müllner wrote:
 Hey,
 
 I'd like to request another app-picker related freeze break for bug
 694710. Currently the frequent view shows up empty when there isn't
 any usage data yet (e.g. on a fresh install).
 With the patches from the aforementioned bug, we will open the all
 view in that case, and show a short explanation in frequent view[0].
 Given that this is dealing with a corner case, I doubt the change will
 have any effect on existing documention.
 
 Cheers,
 Florian
 
 [0] https://people.gnome.org/~fmuellner/empty-frequent-view.png

No objections.

--
Shaun


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Another GNOME Shell freeze break request ...

[Matthias Clasen]

Approval 1/2 for the release team. I'll point out that this was
specifically requested by Allan.

On Mon, Sep 2, 2013 at 12:22 PM, Shaun McCance sha...@gnome.org wrote:
 On Mon, 2013-09-02 at 17:38 +0200, Florian Müllner wrote:
 Hey,

 I'd like to request another app-picker related freeze break for bug
 694710. Currently the frequent view shows up empty when there isn't
 any usage data yet (e.g. on a fresh install).
 With the patches from the aforementioned bug, we will open the all
 view in that case, and show a short explanation in frequent view[0].
 Given that this is dealing with a corner case, I doubt the change will
 have any effect on existing documention.

 Cheers,
 Florian

 [0] https://people.gnome.org/~fmuellner/empty-frequent-view.png

 No objections.

 --
 Shaun


 ___
 release-team@gnome.org
 https://mail.gnome.org/mailman/listinfo/release-team
 Release-team lurker? Do NOT participate in discussions.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Another GNOME Shell freeze break request ...

[Javier Jardón]

2/2 for the release team: go ahead

On 2 September 2013 17:49, Matthias Clasen matthias.cla...@gmail.com wrote:
 Approval 1/2 for the release team. I'll point out that this was
 specifically requested by Allan.

 On Mon, Sep 2, 2013 at 12:22 PM, Shaun McCance sha...@gnome.org wrote:
 On Mon, 2013-09-02 at 17:38 +0200, Florian Müllner wrote:
 Hey,

 I'd like to request another app-picker related freeze break for bug
 694710. Currently the frequent view shows up empty when there isn't
 any usage data yet (e.g. on a fresh install).
 With the patches from the aforementioned bug, we will open the all
 view in that case, and show a short explanation in frequent view[0].
 Given that this is dealing with a corner case, I doubt the change will
 have any effect on existing documention.

 Cheers,
 Florian

 [0] https://people.gnome.org/~fmuellner/empty-frequent-view.png

 No objections.

 --
 Shaun


 ___
 release-team@gnome.org
 https://mail.gnome.org/mailman/listinfo/release-team
 Release-team lurker? Do NOT participate in discussions.
 ___
 gnome-doc-list mailing list
 gnome-doc-l...@gnome.org
 https://mail.gnome.org/mailman/listinfo/gnome-doc-list



-- 
Javier Jardón Cabezas
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Another GNOME Shell freeze break request ...

[Florian Müllner]

On Mon, Sep 2, 2013 at 7:03 PM, Javier Jardón jjar...@gnome.org wrote:
 2/2 for the release team: go ahead

Thanks! Will do as soon as we land the app-picker patch series (very soon).


Cheers,
Florian
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

gnome-shell freeze break request

[Cosimo Cecchi]

Hi all,

I am requesting a hard code freeze break for this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=696287

Patch has been tested by me and Giovanni, and should work fine.

Thanks,
Cosimo
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell freeze break request

[Javier Jardón]

On 25 March 2013 20:21, Matthias Clasen matthias.cla...@gmail.com wrote:
 On Mon, Mar 25, 2013 at 3:25 PM, Cosimo Cecchi cosi...@gnome.org wrote:
 Hi all,

 I am requesting a hard code freeze break for this bug:
 https://bugzilla.gnome.org/show_bug.cgi?id=696287

 Patch has been tested by me and Giovanni, and should work fine.

 First approval

Seconded



-- 
Javier Jardón Cabezas
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

gnome-shell freeze break request

[drago01]

Hi,

I'd like to get the patch from
https://bugzilla.gnome.org/show_bug.cgi?id=696404 into 3.8 it fixes a
regression where
opening the application view in the overview (or any other shell UI
where we use the edge fade effect) can cause a
30 second lag for every paint on older hardware.

The patch from the bug just reverts the behavior to what we had in
3.6, so it is low (~0) risk. We can revisit for 3.10
once / if we have a fixed mesa but for now this is the best thing to do.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell freeze break request

[Matthias Clasen]

On Fri, Mar 22, 2013 at 2:23 PM, drago01 drag...@gmail.com wrote:
 Hi,

 I'd like to get the patch from
 https://bugzilla.gnome.org/show_bug.cgi?id=696404 into 3.8 it fixes a
 regression where
 opening the application view in the overview (or any other shell UI
 where we use the edge fade effect) can cause a
 30 second lag for every paint on older hardware.

 The patch from the bug just reverts the behavior to what we had in
 3.6, so it is low (~0) risk. We can revisit for 3.10
 once / if we have a fixed mesa but for now this is the best thing to do.

Thats the responsible thing to do. Approval 1 for the release team
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

gnome-shell freeze break request

[Florian Müllner]

Hey,

we have a reported crasher bug[0] for which I'd like to push a quick
fix; the patch is small and I consider it safe (given that it does not
change the normal non-error code path), though a proper solution
requires some investigation and would hopefully be included in time for
3.2.1.


Regards,

Florian


[0] https://bugzilla.gnome.org/show_bug.cgi?id=659676

___
release-team@gnome.org
http://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell freeze break request

[Colin Walters]

On Mon, 2011-09-26 at 20:35 +0200, Florian Müllner wrote:
 Hey,
 
 we have a reported crasher bug[0] for which I'd like to push a quick
 fix; the patch is small and I consider it safe (given that it does not
 change the normal non-error code path), though a proper solution
 requires some investigation and would hopefully be included in time for
 3.2.1.

Discussed this on IRC; +1 from me given testing from the reporter.


___
release-team@gnome.org
http://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: gnome-shell freeze break request

[Matthias Clasen]

On Mon, Sep 26, 2011 at 4:04 PM, Colin Walters walt...@verbum.org wrote:
 On Mon, 2011-09-26 at 20:35 +0200, Florian Müllner wrote:
 Hey,

 we have a reported crasher bug[0] for which I'd like to push a quick
 fix; the patch is small and I consider it safe (given that it does not
 change the normal non-error code path), though a proper solution
 requires some investigation and would hopefully be included in time for
 3.2.1.

 Discussed this on IRC; +1 from me given testing from the reporter.

looks safe to me, +1
___
release-team@gnome.org
http://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.