Re: Creating bugzilla entries for KDE Applications
El dissabte, 2 de setembre de 2017, a les 21:03:23 CEST, Rolf Eike Beer va escriure: > > Nobody really complained so I went ahead and added > > > > https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning#Bug > > zi lla_versions > > > > We will start doing this for KDE Applications 17.12 > > That means the minimum required CMake version is now 3.0, as "project(… > VERSION)" was introduced in that version (according to the release notes). > > Is there any general policy about what the minimum required CMake version > is? latest KF5 require that version already, so most distros compiling newer stuff already have that as a requirement, yes i know your app, for example Okular depends on an older KF5 version that doesn't require cmake 3.0, but honestly who compiles a really new Okular with a really old KF5 ? Cheers, Albert > > Eike
Re: Creating bugzilla entries for KDE Applications
> Nobody really complained so I went ahead and added > > https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning#Bugzi > lla_versions > > We will start doing this for KDE Applications 17.12 That means the minimum required CMake version is now 3.0, as "project(… VERSION)" was introduced in that version (according to the release notes). Is there any general policy about what the minimum required CMake version is? Eike signature.asc Description: This is a digitally signed message part.
Re: Creating bugzilla entries for KDE Applications
El dilluns, 31 de juliol de 2017, a les 22:45:17 CEST, Albert Astals Cid va escriure: > El dilluns, 31 de juliol de 2017, a les 9:44:17 CEST, David Faure va escriure: > > On lundi 31 juillet 2017 00:01:54 CEST Albert Astals Cid wrote: > > > Anyone has an idea on how to read the version specified in the cmake > > > project() function? > > > > It sets the variable PROJECT_VERSION. > > > > (as well as PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR, > > PROJECT_VERSION_PATCH and PROJECT_VERSION_TWEAK) > > These don't seem to be available though cmake -L > > One other option would be calling > cmake --trace-expand > and parsing for > > project(.* VERSION _THE_NUNBER_WE_WANT ) > > maybe that does indeed make more sense. > > Adrián could you update the code to parse for that? > > Patch for okular would be something like https://paste.kde.org/pelj2ugxp Nobody really complained so I went ahead and added https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning#Bugzilla_versions We will start doing this for KDE Applications 17.12 Cheers, Albert > > Cheers, > Albert
Re: Creating bugzilla entries for KDE Applications
2017-07-31 22:45 GMT+02:00 Albert Astals Cid : > El dilluns, 31 de juliol de 2017, a les 9:44:17 CEST, David Faure va > escriure: > One other option would be calling > cmake --trace-expand > and parsing for > > project(.* VERSION _THE_NUNBER_WE_WANT ) > > maybe that does indeed make more sense. > > Adrián could you update the code to parse for that? > > Patch for okular would be something like https://paste.kde.org/pelj2ugxp > On it.
Re: Creating bugzilla entries for KDE Applications
El dimarts, 1 d’agost de 2017, a les 8:22:04 CEST, Ralf Habacker va escriure: > Am 31.07.2017 um 00:01 schrieb Albert Astals Cid: > > El diumenge, 30 de juliol de 2017, a les 12:48:05 CEST, David Faure va > > > > escriure: > >> On samedi 29 juillet 2017 18:15:16 CEST Albert Astals Cid wrote: > >>> At Akademy Adrián adapted Jonathan's scripts for Plasma to KDE > >>> Applications. > >>> > >>> https://cgit.kde.org/sysadmin/release-tools.git/tree/add-bugzilla-versio > >>> ns > >>> > >>> Since KDE Applications are different in regard to Plasma in which not > >>> all > >>> applications have the same version, we thought of adding a new cmake > >>> variable that will define the version created. > >>> > >>> For example the patch for okular would be something like > >>> https://paste.kde.org/pest4msbu > >>> > >>> The limitation of this is that it can only create one version per repo, > >>> and > >>> at this stage it assumes the name of the bugzilla product is the same as > >>> the repo, though that could be fixed with creating a > >>> BUGZILLA_APPLICATION_NAME or similar if needed. > >>> > >>> What are your thoughts? > > umbrello for example uses something like 2.22.3 (KDE Applications 17.04.3) H, you're doing it wrong. You're using 2.22.3 as version (what umbrello -v) reports, but then you're creating "2.22.3 (KDE Applications 17.04.3)" in bugzilla. So when i go to Help -> Report error, it fails to find the matching version. So basically, you either have to make your version really be "2.22.3 (KDE Applications 17.04.3)", which would mean not using the cmake project() function since it doesn't accept random strings, or you don't create weird bugzilla entries, or you still create your weird bugzilla entries outside of this "feature". Cheers, Albert > > Ralf
Re: Creating bugzilla entries for KDE Applications
Am 31.07.2017 um 00:01 schrieb Albert Astals Cid: > El diumenge, 30 de juliol de 2017, a les 12:48:05 CEST, David Faure va > escriure: >> On samedi 29 juillet 2017 18:15:16 CEST Albert Astals Cid wrote: >>> At Akademy Adrián adapted Jonathan's scripts for Plasma to KDE >>> Applications. >>> >>> https://cgit.kde.org/sysadmin/release-tools.git/tree/add-bugzilla-versions >>> >>> Since KDE Applications are different in regard to Plasma in which not all >>> applications have the same version, we thought of adding a new cmake >>> variable that will define the version created. >>> >>> For example the patch for okular would be something like >>> https://paste.kde.org/pest4msbu >>> >>> The limitation of this is that it can only create one version per repo, >>> and >>> at this stage it assumes the name of the bugzilla product is the same as >>> the repo, though that could be fixed with creating a >>> BUGZILLA_APPLICATION_NAME or similar if needed. >>> >>> What are your thoughts? umbrello for example uses something like 2.22.3 (KDE Applications 17.04.3) Ralf
Re: Creating bugzilla entries for KDE Applications
On Mon, Jul 31, 2017 at 10:45 PM, Albert Astals Cid wrote: > El dilluns, 31 de juliol de 2017, a les 9:44:17 CEST, David Faure va escriure: >> On lundi 31 juillet 2017 00:01:54 CEST Albert Astals Cid wrote: >> > Anyone has an idea on how to read the version specified in the cmake >> > project() function? >> >> It sets the variable PROJECT_VERSION. >> >> (as well as PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR, >> PROJECT_VERSION_PATCH and PROJECT_VERSION_TWEAK) > > These don't seem to be available though cmake -L > > One other option would be calling > cmake --trace-expand > and parsing for > > project(.* VERSION _THE_NUNBER_WE_WANT ) > > maybe that does indeed make more sense. > > Adrián could you update the code to parse for that? > > Patch for okular would be something like https://paste.kde.org/pelj2ugxp Alternatively, if the cmake we run it on is new enough we also should be able to use the cmake server mode (cmake -E server). But we'd have to configure the project again anyway so there's not much of a benefit. Aleix
Re: Creating bugzilla entries for KDE Applications
El dilluns, 31 de juliol de 2017, a les 9:44:17 CEST, David Faure va escriure: > On lundi 31 juillet 2017 00:01:54 CEST Albert Astals Cid wrote: > > Anyone has an idea on how to read the version specified in the cmake > > project() function? > > It sets the variable PROJECT_VERSION. > > (as well as PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR, > PROJECT_VERSION_PATCH and PROJECT_VERSION_TWEAK) These don't seem to be available though cmake -L One other option would be calling cmake --trace-expand and parsing for project(.* VERSION _THE_NUNBER_WE_WANT ) maybe that does indeed make more sense. Adrián could you update the code to parse for that? Patch for okular would be something like https://paste.kde.org/pelj2ugxp Cheers, Albert
Re: Creating bugzilla entries for KDE Applications
On lundi 31 juillet 2017 00:01:54 CEST Albert Astals Cid wrote: > Anyone has an idea on how to read the version specified in the cmake > project() function? It sets the variable PROJECT_VERSION. (as well as PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR, PROJECT_VERSION_PATCH and PROJECT_VERSION_TWEAK) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: Creating bugzilla entries for KDE Applications
El diumenge, 30 de juliol de 2017, a les 12:48:05 CEST, David Faure va
escriure:
> On samedi 29 juillet 2017 18:15:16 CEST Albert Astals Cid wrote:
> > At Akademy Adrián adapted Jonathan's scripts for Plasma to KDE
> > Applications.
> >
> > https://cgit.kde.org/sysadmin/release-tools.git/tree/add-bugzilla-versions
> >
> > Since KDE Applications are different in regard to Plasma in which not all
> > applications have the same version, we thought of adding a new cmake
> > variable that will define the version created.
> >
> > For example the patch for okular would be something like
> > https://paste.kde.org/pest4msbu
> >
> > The limitation of this is that it can only create one version per repo,
> > and
> > at this stage it assumes the name of the bugzilla product is the same as
> > the repo, though that could be fixed with creating a
> > BUGZILLA_APPLICATION_NAME or similar if needed.
> >
> > What are your thoughts?
>
> It seems strange to make it configurable for people who compile the
> application, what the value of BUGZILLA_APPLICATION_VERSION should be.
> I.e. my questions is, why is this a cmake variable?
So that you can ask cmake -L it's value.
>
> On the other hand cmake has the notion of the "project version", why don't
> we set that and use it for bugzilla too?
>
> E.g. KIO does
> set(KF5_VERSION "5.37.0") # handled by release scripts
> project(KIO VERSION ${KF5_VERSION})
>
> And okular *should* be doing something like
> project(okular VERSION "1.3.${KDE_APPLICATIONS_VERSION_MICRO}")º
>
> And Dolphin should be doing
> project(Dolphin VERSION ${KDE_APPLICATIONS_VERSION})
>
> (Note that when doing this, you can then port the calls to ecm_setup_version
> to ecm_setup_version(PROJECT [...]) i.e. it can get the version number from
> the project line) [requires CMake policy CMP0048 to not be OLD].
>
>
> Then add_bugzilla_versions can parse the version number out of
> project([...] VERSION [...]) in all cases, without having a
> bugzilla-specific cmake variable.
The problem is, i don't want to parse it, i want cmake to parse it, and if
it's in a variable cmake -L gives me it's value, it being in project, even if
it's probably more proper, doesn't seem to give us a way to find it, and
honestly we really don't want to write a cmake parse/evaluator :D
Anyone has an idea on how to read the version specified in the cmake project()
function?
Cheers,
Albert
Re: Creating bugzilla entries for KDE Applications
On samedi 29 juillet 2017 18:15:16 CEST Albert Astals Cid wrote:
> At Akademy Adrián adapted Jonathan's scripts for Plasma to KDE Applications.
>
> https://cgit.kde.org/sysadmin/release-tools.git/tree/add-bugzilla-versions
>
> Since KDE Applications are different in regard to Plasma in which not all
> applications have the same version, we thought of adding a new cmake
> variable that will define the version created.
>
> For example the patch for okular would be something like
> https://paste.kde.org/pest4msbu
>
> The limitation of this is that it can only create one version per repo, and
> at this stage it assumes the name of the bugzilla product is the same as
> the repo, though that could be fixed with creating a
> BUGZILLA_APPLICATION_NAME or similar if needed.
>
> What are your thoughts?
It seems strange to make it configurable for people who compile the
application, what the value of BUGZILLA_APPLICATION_VERSION should be.
I.e. my questions is, why is this a cmake variable?
On the other hand cmake has the notion of the "project version", why don't we
set that and use it for bugzilla too?
E.g. KIO does
set(KF5_VERSION "5.37.0") # handled by release scripts
project(KIO VERSION ${KF5_VERSION})
And okular *should* be doing something like
project(okular VERSION "1.3.${KDE_APPLICATIONS_VERSION_MICRO}")
And Dolphin should be doing
project(Dolphin VERSION ${KDE_APPLICATIONS_VERSION})
(Note that when doing this, you can then port the calls to ecm_setup_version
to ecm_setup_version(PROJECT [...]) i.e. it can get the version number from
the project line) [requires CMake policy CMP0048 to not be OLD].
Then add_bugzilla_versions can parse the version number out of
project([...] VERSION [...]) in all cases, without having a bugzilla-specific
cmake variable.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
Re: Creating bugzilla entries for KDE Applications
El dissabte, 29 de juliol de 2017, a les 18:52:12 CEST, Elvis Angelaccio va escriure: > On sabato 29 luglio 2017 18:15:16 CEST, Albert Astals Cid wrote: > > At Akademy Adrián adapted Jonathan's scripts for Plasma to KDE > > Applications. > > > > https://cgit.kde.org/sysadmin/release-tools.git/tree/add-bugzilla-versions > > Hi, > this is great news, thanks a lot! > > > Since KDE Applications are different in regard to Plasma in which not all > > applications have the same version, we thought of adding a new > > cmake variable > > that will define the version created. > > > > For example the patch for okular would be something like > > https://paste.kde.org/pest4msbu > > > > The limitation of this is that it can only create one version > > per repo, and at > > this stage it assumes the name of the bugzilla product is the same as the > > repo, though that could be fixed with creating a > > BUGZILLA_APPLICATION_NAME or > > similar if needed. > > > > What are your thoughts? > > > > Improvements? > > What about using the version in KDE_APPLICATIONS_VERSION if > BUGZILLA_APPLICATION_VERSION is not defined? > > This way we don't need to patch applications that do not define their own > version number and just use the automatic Applications version number. Thought about that, but then discarded it since i think it will not be a good solution. Let's say we run this just in time for the KDE Applications 17.08.0 release, for kpat it would create a 17.08.0 verison, but kpat is at version 3.6, so it's unnecessary noise in the version list. The important thing about this is that if we have the correct version number using the Help->Report bug actually works instead of selecting "unspecified". Cheers, Albert > > Cheers, > Elvis
Re: Creating bugzilla entries for KDE Applications
On sabato 29 luglio 2017 18:15:16 CEST, Albert Astals Cid wrote: At Akademy Adrián adapted Jonathan's scripts for Plasma to KDE Applications. https://cgit.kde.org/sysadmin/release-tools.git/tree/add-bugzilla-versions Hi, this is great news, thanks a lot! Since KDE Applications are different in regard to Plasma in which not all applications have the same version, we thought of adding a new cmake variable that will define the version created. For example the patch for okular would be something like https://paste.kde.org/pest4msbu The limitation of this is that it can only create one version per repo, and at this stage it assumes the name of the bugzilla product is the same as the repo, though that could be fixed with creating a BUGZILLA_APPLICATION_NAME or similar if needed. What are your thoughts? Improvements? What about using the version in KDE_APPLICATIONS_VERSION if BUGZILLA_APPLICATION_VERSION is not defined? This way we don't need to patch applications that do not define their own version number and just use the automatic Applications version number. Cheers, Elvis
