Re: Dropping the svn kio from kdesdk-kioslaves

2017-01-04 Thread Albert Astals Cid 
El dimarts, 20 de desembre de 2016, a les 10:40:44 CET, Christian Ehrlicher va 
escriure:
> Am 16.12.2016 um 11:32 schrieb Kevin Funk:
> > If the SVN kioslave is standalone, wouldn't it make more sense to actually
> > keep it in a separate repository/package? So users who just want the
> > Dolphin integration can just use that?
> > 
> > Wouldn't it make more sense to move your kioslave implementation into
> > kdesdk- kioslaves, replacing the older copy?
> > 
> > I'm not sure whether Albert just wants to kill the repository or he's just
> > phasing old unmaintained software. In case of the latter, updating the
> > copy
> > with the better maintained version probably makes more sense.
> 
> I took a look into kdesdk-kioslaves - the code for svn there is
> completely different from kdesvn kioslave. Therefore I would suggest to
> remove kdesdk-kioslaves/svn because I won't maintain two different
> implementations for one protocol.
> A distro packager can separate the kdesvn kioslave into a separate
> package, at least this is what I would expect looking at the kdesvn code.

Since noone really complained I went ahead and removed the svn kioslave from 
kdesdk-kioslaves, the kdesvn kioslave seems to work for the lightweight svn 
browsing i'd expect people to use a kioslave for.

Cheers,
  Albert

> 
> 
> Christian

Re: Dropping the svn kio from kdesdk-kioslaves

2016-12-20 Thread Christian Ehrlicher 

Am 16.12.2016 um 11:32 schrieb Kevin Funk:

If the SVN kioslave is standalone, wouldn't it make more sense to actually
keep it in a separate repository/package? So users who just want the Dolphin
integration can just use that?

Wouldn't it make more sense to move your kioslave implementation into kdesdk-
kioslaves, replacing the older copy?

I'm not sure whether Albert just wants to kill the repository or he's just
phasing old unmaintained software. In case of the latter, updating the copy
with the better maintained version probably makes more sense.
I took a look into kdesdk-kioslaves - the code for svn there is 
completely different from kdesvn kioslave. Therefore I would suggest to 
remove kdesdk-kioslaves/svn because I won't maintain two different 
implementations for one protocol.
A distro packager can separate the kdesvn kioslave into a separate 
package, at least this is what I would expect looking at the kdesvn code.



Christian

Re: Dropping the svn kio from kdesdk-kioslaves

2016-12-16 Thread Kevin Funk 
On Friday, 16 December 2016 06:31:46 CET Christian Ehrlicher wrote:
> Am 15.12.2016 um 23:12 schrieb Kevin Funk:
> > On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote:
> >> Why?
> >> 
> >>   * It doesn't compile with newer libsvn
> >>   * It's kdelibs4-based
> > 
> > Heya,
> > 
> > I know a few people that use kdesvn, how's the relation to that?
> > 
> > I saw that Christian (CC'ed) put quite some effort in porting kdesvn over
> > to a KF5-based kdelibs4support-free code base. If I understand correctly
> > kdesvn.git even contains a copy of the KIO SVN implementation (c.f.
> > kdesvn.git:src/ kiosvn)?
> > 
> > Please elaborate :)
> 
> You're correct - kdesvn contains a kioslave for svn and I ported it to
> KF5 (just released kdesvn 2.0.0 some days ago). I don't know if
> kdesdk-kioslaves has more functionality but from my point of view it can
> be dropped.

If the SVN kioslave is standalone, wouldn't it make more sense to actually 
keep it in a separate repository/package? So users who just want the Dolphin 
integration can just use that?

Wouldn't it make more sense to move your kioslave implementation into kdesdk-
kioslaves, replacing the older copy?

I'm not sure whether Albert just wants to kill the repository or he's just 
phasing old unmaintained software. In case of the latter, updating the copy 
with the better maintained version probably makes more sense.

Cheers,
Kevin

> Cheers,
> Christian


-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.

Re: Dropping the svn kio from kdesdk-kioslaves

2016-12-15 Thread Christian Ehrlicher 

Am 15.12.2016 um 23:12 schrieb Kevin Funk:

On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote:

Why?
  * It doesn't compile with newer libsvn
  * It's kdelibs4-based

Heya,

I know a few people that use kdesvn, how's the relation to that?

I saw that Christian (CC'ed) put quite some effort in porting kdesvn over to a
KF5-based kdelibs4support-free code base. If I understand correctly kdesvn.git
even contains a copy of the KIO SVN implementation (c.f. kdesvn.git:src/
kiosvn)?

Please elaborate :)
You're correct - kdesvn contains a kioslave for svn and I ported it to 
KF5 (just released kdesvn 2.0.0 some days ago). I don't know if 
kdesdk-kioslaves has more functionality but from my point of view it can 
be dropped.


Cheers,
Christian

Re: Dropping the svn kio from kdesdk-kioslaves

2016-12-15 Thread Tobias C. Berner 
On FreeBSD we have this patch
https://svnweb.freebsd.org/ports/head/devel/kdesdk4-kioslaves/files/patch-svn_svn.cpp?revision=400399
to make the kioslave build against subversion 1.9.


mfg Tobias

On 15 December 2016 at 23:12, Kevin Funk  wrote:

> On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote:
> > Why?
> >  * It doesn't compile with newer libsvn
> >  * It's kdelibs4-based
>
> Heya,
>
> I know a few people that use kdesvn, how's the relation to that?
>
> I saw that Christian (CC'ed) put quite some effort in porting kdesvn over
> to a
> KF5-based kdelibs4support-free code base. If I understand correctly
> kdesvn.git
> even contains a copy of the KIO SVN implementation (c.f. kdesvn.git:src/
> kiosvn)?
>
> Please elaborate :)
>
> PS: /me never uses SVN directly usually.
>
> Cheers,
> Kevin
>
> > Any disagreement on dropping it?
> >
> > Cheers,
> >   Albert
>
>
> --
> Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Dropping the svn kio from kdesdk-kioslaves

2016-12-15 Thread Kevin Funk 
On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote:
> Why?
>  * It doesn't compile with newer libsvn
>  * It's kdelibs4-based

Heya,

I know a few people that use kdesvn, how's the relation to that?

I saw that Christian (CC'ed) put quite some effort in porting kdesvn over to a 
KF5-based kdelibs4support-free code base. If I understand correctly kdesvn.git 
even contains a copy of the KIO SVN implementation (c.f. kdesvn.git:src/
kiosvn)?

Please elaborate :)

PS: /me never uses SVN directly usually.

Cheers,
Kevin

> Any disagreement on dropping it?
> 
> Cheers,
>   Albert


-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.

Dropping the svn kio from kdesdk-kioslaves

2016-12-15 Thread Albert Astals Cid 
Why?
 * It doesn't compile with newer libsvn
 * It's kdelibs4-based

Any disagreement on dropping it?

Cheers,
  Albert