Re: Freeze break exception for #771628

2016-09-19 Thread Matthias Clasen
On Mon, Sep 19, 2016 at 8:00 AM, Frederic Peters wrote: > Carlos Garnacho wrote: >> Hi, >> >> A crasher sneaked in on "unknown" tablets (at least to libwacom): >> https://bugzilla.gnome.org/show_bug.cgi?id=771628 >> >> This causes crashes on gnome-shell startup for the owners

Re: Freeze break exception for #771628

2016-09-19 Thread Andre Klapper
On Mon, 2016-09-19 at 17:00 +0200, Frederic Peters wrote: > Carlos Garnacho wrote: > > A crasher sneaked in on "unknown" tablets (at least to libwacom): > > https://bugzilla.gnome.org/show_bug.cgi?id=771628 > > > > This causes crashes on gnome-shell startup for the owners of these > > tablets,

Re: Freeze break exception for #771628

2016-09-19 Thread Michael Catanzaro
On Mon, 2016-09-19 at 17:00 +0200, Frederic Peters wrote: > Style-wise the maybe-else part cut by #endif is quite ugly; but ok, > first approval nevertheless. 2/2, but consider this solution to avoid the weird placement of the preprocessor conditionals: #ifdef HAVE_LIBWACOM   if

Re: Freeze break exception for #771628

2016-09-19 Thread Frederic Peters
Carlos Garnacho wrote: > Hi, > > A crasher sneaked in on "unknown" tablets (at least to libwacom): > https://bugzilla.gnome.org/show_bug.cgi?id=771628 > > This causes crashes on gnome-shell startup for the owners of these > tablets, both on x11 and wayland, would be great to push this fix >

Freeze break exception for #771628

2016-09-19 Thread Carlos Garnacho
Hi, A crasher sneaked in on "unknown" tablets (at least to libwacom): https://bugzilla.gnome.org/show_bug.cgi?id=771628 This causes crashes on gnome-shell startup for the owners of these tablets, both on x11 and wayland, would be great to push this fix before mutter 3.22.0. Cheers, Carlos