>
> As an aside, if you're using RewriteEngine anyway, you might as well use

repoze.vhm#vhm_path. The X-header stuff is mostly useful if you're using

mod_wsgi. I'm glad we're trying to fix it, though. :)

I know that. This is more natural for anyone to use though--I'm setting up a
client with this. Also, I just came across it and thought it should be
fixed....

I've gained svn access, created the branch, added tests and made the fix.

I'll test it for a bit and once I feel good about it, merge it to the
trunk.


Thanks for all the help.

-Nathan

On Wed, Dec 30, 2009 at 10:27 AM, Martin Aspeli
<optilude+li...@gmail.com<optilude%2bli...@gmail.com>
> wrote:

> Chris McDonough wrote:
> > Martin Aspeli wrote:
> >>> I assumed it was just acquisition trickery. Looking more closely,
> >>> z2bob.py uses the repoze.vhm.virtual_root via the getVirtualRoot in the
> >>> repoze.vhm.utils package to get the virtual root and it seems to create
> >>> the correct path for traversal regardless of the issue. Just some small
> >>> things are off, like content actions and I just noticed that related
> >>> items don't show also.
> >> Well, if ACTUAL_URL is wrong, then that's a serious bug.
> >
> > TBH, I never really understood what ACTUAL_URL was supposed to do.  Limi
> added
> > it at some point, but I'm pretty sure he never really understood what it
> was
> > supposed to do either. ;-)  Or at least he'll deny knowing anything about
> it.
>
> Ah, history...
>
> Limi *wanted* ACTUAL_URL to be "what the user sees", so basically the
> virtual or real URL, *and* the query string, if any.
>
> What he got was something which is basically the same as VIRTUAL_URL if
> that's set, or URL if not. It's still useful, though, since VIRTUAL_URL
> is not set at all if you're not using VHM (in standard Zope). So
> request['ACTUAL_URL'] is a safe way to get "the real URL people see".
> And to get what Alex wanted, you'd need request['ACTUAL_URL'] + '?' +
> request['QUERY_STRING'].
>
> > I'm going to defer to the professionals here; I don't use this package
> much
> > anymore, so you'll need to use some judgment and check in a fix that is
> more
> > correct I think.
>
> I figured. :)
>
> I think Nathan's on the right path, though we just need to do some
> sanity checks with a live running site to be sure.
>
> Martin
>
> --
> Author of `Professional Plone Development`, a book for developers who
> want to work with Plone. See http://martinaspeli.net/plone-book
>
> _______________________________________________
> Repoze-dev mailing list
> Repoze-dev@lists.repoze.org
> http://lists.repoze.org/listinfo/repoze-dev
>
_______________________________________________
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev

Reply via email to