[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

[Tres Seaver]

Tres Seaver  added the comment:

Fix released to PyPI: http://pypi.python.org/pypi/repoze.profile/1.2

--
status: chatting -> resolved

__
Repoze Bugs 

__
___
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

[jkarp]

jkarp  added the comment:

Thanks! That works for me. I appreciate your work, repoze.profile was just what
I was looking for.

--
status: testing -> chatting

__
Repoze Bugs 

__
___
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

[Tres Seaver]

Tres Seaver  added the comment:

I just checked in a change which moves the conditional list inside the
profiled code.  Please give it a try.

I made creation of the list condition in order to avoid injecting any
unnecessary overhead into the profiled code.  I'm probably being too fussy,
but there you go.

--
status: chatting -> testing

__
Repoze Bugs 

__
___
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

[jkarp]

jkarp  added the comment:

I tried the changes you made; I don't they fix it. You made it iterate inside
__call__, but that is not enough, iteration needs to happen inside
self.profiler.runctx() or the profiler won't capture the execution.

The change I originally suggested seems to work. And it shouldn't break
anything, because PEP 333 guarantees a WSGI application will produce an
iterable, which list() will handle correctly, regardless of whether its a
generator under the covers or not.

Anyhow, paste.debug.profile takes a similar approach to what I'm suggesting. It
creates a nested function that does [].extend(app_iter), and profiles that 
function.

--
status: resolved -> chatting

__
Repoze Bugs 

__
___
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

[Tres Seaver]

Tres Seaver  added the comment:

Fix checked in on the trunk for the next release.

--
status: chatting -> resolved

__
Repoze Bugs 

__
___
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

[Tres Seaver]

Tres Seaver  added the comment:

Thanks for the report!  I agree that your suggested solution is probably
the correct one, with the exception that I would have it apply 'list()'
only for results which were generators:  hmm, how do I detect that?

--
assignedto:  -> tseaver
nosy: +tseaver
status: unread -> chatting

__
Repoze Bugs 

__
___
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev

[Repoze-dev] [issue169] repoze.profile: useless profile recorded when application is a generator

[jkarp]

New submission from jkarp :

When repoze.profile is given an application to wrap that takes the form of a
generator, you end up with a useless profile that has only the entries
":1()" and "{method 'disable' of '_lsprof.Profiler' objects}".

This is because the way the profiling is being invoked, it only includes the
assignment of a generator object to app_iter. For the application code to be
executed, the generator must be iterated over, and that isn't happening until
after profiling has stopped.

One band-aid solution might be to change repoze.profile to profile
'list(self.app(environ, start_response))' instead of 'self.app(environ,
start_response)'.

--
messages: 456
nosy: jkarp
priority: bug
status: unread
title: repoze.profile: useless profile recorded when application is a generator

__
Repoze Bugs 

__
___
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev