-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Chris Rossi wrote:
> FWIW, I just checked in a fix on the 1.0 branch of repoze.mailin that
> should fix this problem. Tres, you could still evaluate my fix and see
> if you agree with it, and then maybe cut a new release of repoze.mailin
> to get it in the pipe for Karl.
I don't think working further on that branch is all that helpful: we
should focus on keeping the trunk in shape, and just plan to release a
new version (0.2) with whatever fixes are appropriate.
Also, the following diff seems to me to indicate that you removed a
reasonable test while working on this bug:
$ svn diff $RSVN/repoze.mailin/{tags/0.1.5,branches/0.1}
Index: repoze/mailin/tests/test_pending.py
===================================================================
- --- repoze/mailin/tests/test_pending.py (.../tags/0.1.5)
(revision 5508)
+++ repoze/mailin/tests/test_pending.py (.../branches/0.1) (revision 5508)
@@ -71,7 +71,7 @@
pq.remove(MESSAGE_ID)
self.failIf(pq)
- - def test_pop_not_empty_with_many(self):
+ def test_pop_empty_with_many(self):
pq = self._makeOne()
found = list(pq.pop(2))
self.assertEqual(len(found), 0)
@@ -84,16 +84,6 @@
pq = self._makeOne()
for message_id in MESSAGE_IDS:
pq.push(message_id)
- - found = list(pq.pop(w))
- -
- - def test_pop_not_empty_with_many(self):
- - MESSAGE_IDS = ['<abc...@example.com>',
- - '<def...@example.com>',
- - '<ghi...@example.com>',
- - ]
- - pq = self._makeOne()
- - for message_id in MESSAGE_IDS:
- - pq.push(message_id)
found = list(pq.pop(2))
self.assertEqual(len(found), 2)
self.assertEqual(found[0], MESSAGE_IDS[0])
The two test cases may have had the same name, but they were testing
different conditions. Ditching the "not empty" case doesn't seem
reasonable here.
Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tsea...@palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFKQDwn+gerLs4ltQ4RAj7pAKCUE0I1b8jKXIi3qypkV4vFcrLGaACcCO6j
wcOxVjZVo0HSyqT5Ztop4Sg=
=6tRZ
-----END PGP SIGNATURE-----
_______________________________________________
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev
