Bug#901758: diffoscope: leaves progress bar on terminal after completion

2018-07-07 Thread Chris Lamb
Hi Paul, > Attached a couple more patches. Also applied. :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Reproducible-builds mailing list

Bug#901758: diffoscope: leaves progress bar on terminal after completion

2018-07-07 Thread Paul Wise
On Sat, 2018-07-07 at 11:26 +0100, Chris Lamb wrote: > Thanks, applied. Attached a couple more patches. -- bye, pabs https://wiki.debian.org/PaulWise From 2c95bd3ec8e17c54fc2f8a1c4a1735d17df7ab55 Mon Sep 17 00:00:00 2001 From: Paul Wise Date: Sat, 7 Jul 2018 16:31:24 +0800 Subject: [PATCH

Bug#901758: diffoscope: leaves progress bar on terminal after completion

2018-07-07 Thread Paul Wise
On Sat, 2018-07-07 at 07:45 +0100, Chris Lamb wrote: > I wasn't aware that was a possibility. Yeah, different terminals have different capabilities. Most modern ones of course can erase to EOL though. > If you mean via --text=filename then the progress bar does not > appear there. I was

Bug#901758: diffoscope: leaves progress bar on terminal after completion

2018-07-07 Thread Chris Lamb
tags 901758 - pending thanks > > +self.fd.write("\033[K") > > This isn't going to work if the terminal being used doesn't support > that escape sequence I wasn't aware that was a possibility. > or if the user requested a progress bar but directed output to > a file If you mean

Bug#901758: diffoscope: leaves progress bar on terminal after completion

2018-07-06 Thread Paul Wise
On Fri, 06 Jul 2018 18:50:44 +0100 Chris Lamb wrote: > https://salsa.debian.org/reproducible-builds/diffoscope/commit/68c8263a430aca779b0c44fd31e729ae9bd59e0b.patch > +# Clear the progress bar after completion (#901758) I don't think mentioning the bug in the comment is useful

Bug#901758: diffoscope: leaves progress bar on terminal after completion

2018-06-17 Thread Paul Wise
Package: diffoscope Version: 95 Severity: minor diffoscope leaves a giant progress bar on the terminal after it completes. It would be nice if the progress bar could disappear after it has served its purpose. In case the progress bar code you use doesn't support this, I've included code below