Re: [PATCH] reproducible Debian: filter Environment section from buildinfo files

2016-11-10 Thread Holger Levsen
On Mon, Nov 07, 2016 at 06:11:36PM -0500, Daniel Kahn Gillmor wrote: > What if we only included the .buildinfo differences (clearly demarcated) > if there was other stuff which should be fixed? And if nothing needs to > be fixed, then don't show the buildinfo differences. That strikes me as >

Re: [PATCH] reproducible Debian: filter Environment section from buildinfo files

2016-11-07 Thread Daniel Kahn Gillmor
On Mon 2016-11-07 09:14:00 -0500, HW42 wrote: > 1) Currently the diff contains only stuff which should be fixed. If we >include .buildinfo differences it will include stuff which should not >be "fixed" (and can't be by the package maintainer). What if we only included the .buildinfo

Re: [PATCH] reproducible Debian: filter Environment section from buildinfo files

2016-11-07 Thread HW42
Mattia Rizzolo: > On Mon, Nov 07, 2016 at 01:41:00PM +, HW42 wrote: >> I removed the filter from Reiner and replaced it with a 'sed' filtering >> out the .buildinfo entries from the .changes file. So diffoscope should >> not compare the .buildinfos (and the files refered by them) at all. > >

Re: [PATCH] reproducible Debian: filter Environment section from buildinfo files

2016-11-07 Thread Mattia Rizzolo
On Mon, Nov 07, 2016 at 01:41:00PM +, HW42 wrote: > I removed the filter from Reiner and replaced it with a 'sed' filtering > out the .buildinfo entries from the .changes file. So diffoscope should > not compare the .buildinfos (and the files refered by them) at all. Ah, right, I missed the

Re: [PATCH] reproducible Debian: filter Environment section from buildinfo files

2016-11-07 Thread HW42
Mattia Rizzolo: > On Sun, Nov 06, 2016 at 10:04:00PM +, HW42 wrote: >> (As I wrote an hour ago on irc,) See last 3 commit at >> https://anonscm.debian.org/git/users/hw42-guest/jenkins.debian.net.git/ > > >> commit fdb7a50073ef9e3b8d22176b63817a78c928d73c >> Author: HW42

Re: [PATCH] reproducible Debian: filter Environment section from buildinfo files

2016-11-07 Thread Mattia Rizzolo
On Sun, Nov 06, 2016 at 10:04:00PM +, HW42 wrote: > (As I wrote an hour ago on irc,) See last 3 commit at > https://anonscm.debian.org/git/users/hw42-guest/jenkins.debian.net.git/ > commit fdb7a50073ef9e3b8d22176b63817a78c928d73c > Author: HW42 > Date: Sun Nov 6