Re: [Reproducible-builds] Bug#818856: diffoscope: crashes on broken symlinks

2016-04-06 Thread Satyam Zode
Hi Reiner! Thank you for reviewing patch. I have made all the changes you mentioned above. Please find an attachment :-) Cheers, Satyam Zode From 2e440a527e4689a6f4321695801b5cd04ff8642a Mon Sep 17 00:00:00 2001 From: Satyam Zode Date: Thu, 7 Apr 2016 00:31:42 +0530

Re: [Reproducible-builds] Bug#818856: diffoscope: crashes on broken symlinks

2016-04-02 Thread Reiner Herrmann
Hi Satyam! Thanks for submitting a patch for this issue! On Sun, Apr 03, 2016 at 02:08:52AM +0530, Satyam Zode wrote: > logger.debug('%s has_same_content %s', self, other) > # try comparing small files directly first > my_size = os.path.getsize(self.path) > -

Re: [Reproducible-builds] Bug#818856: diffoscope: crashes on broken symlinks

2016-04-02 Thread Satyam Zode
Package: diffoscope Version: 51 Severity: normal Hi, Pabs! Please try an attached patch. Hopefully, it'll solve this problem. :) Thanks! Satyam Zode PICT, Pune On Sun, Apr 3, 2016 at 2:02 AM, Satyam Zode wrote: > Hi, Pabs! > > Please try an attached patch! Hopefully,

[Reproducible-builds] Bug#818856: diffoscope: crashes on broken symlinks

2016-03-20 Thread Chris Lamb
Hi, > diffoscope: crashes on broken symlinks (See also #810825 and #796262) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Reproducible-builds mailing list

[Reproducible-builds] Bug#818856: diffoscope: crashes on broken symlinks

2016-03-20 Thread Paul Wise
Package: diffoscope Version: 51 Severity: normal I found a way to crash diffoscope with broken symlinks: pabs@chianamo ~ $ mkdir foo barĀ  pabs@chianamo ~ $ touch foo/baz pabs@chianamo ~ $ ln -s asdasfahguwbagpiuasbdifgsabdf bar/baz pabs@chianamo ~ $ diffoscope foo bar Traceback (most recent call