Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-19 Thread Paul Wise
On Sun, 2016-06-19 at 15:40 +0530, Satyam Zode wrote: > Here is range completion using updated patch: ... > Here, I used logger.error for displaying error and if error occurs > diffoscope returns. Excellent, thanks! From my perspective this is ready to be committed. -- bye, pabs https://wiki.

Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-19 Thread Satyam Zode
Hi, On Sun, Jun 19, 2016 at 8:16 AM, Paul Wise wrote: > On Sun, 2016-06-19 at 00:32 +0530, Satyam Zode wrote: > >> I made the changes as you mentioned, please find an attached patches. > > Personally, I would suggest that the changes you have separated into > separate patches per file are a single

Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-18 Thread Paul Wise
On Sun, 2016-06-19 at 00:32 +0530, Satyam Zode wrote: > I made the changes as you mentioned, please find an attached patches.  Personally, I would suggest that the changes you have separated into separate patches per file are a single logical change and as such should all be made in the same comm

Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-18 Thread Satyam Zode
Hi, all ! Pabs, Thanks for suggestions :) I made the changes as you mentioned, please find an attached patches. On Sun, Jun 12, 2016 at 1:31 PM, Paul Wise wrote: > On Sun, 2016-06-12 at 11:50 +0530, Satyam Zode wrote: > > > Tags: patch > > That only works in mails to sub...@bugs.debian.org, for

Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-12 Thread Paul Wise
On Sun, 2016-06-12 at 11:50 +0530, Satyam Zode wrote: > Tags: patch That only works in mails to sub...@bugs.debian.org, for mails to the bug report address, you want this instead (-1 means the current bug): Control: tags -1 + patch > I have updated the patch as per suggestions please review it.

Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-11 Thread Satyam Zode
Tags: patch Hi, Pabs! I have updated the patch as per suggestions please review it. Thanks! Satyam Zode, From a1389838a38aecd894e052635e4c3e73f3cf6ef4 Mon Sep 17 00:00:00 2001 From: Satyam Zode Date: Sun, 12 Jun 2016 11:46:02 +0530 Subject: [PATCH] Added support for argument completion * diff

Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-11 Thread Paul Wise
On Sat, 2016-06-11 at 16:31 +0530, Satyam Zode wrote: > Please find an attached patch which enables argument completion for > diffoscope. Looking forward to review and feedback. I forgot you need to generate and install the bash-completion snippet: register-python-argcomplete diffoscope

Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-11 Thread Paul Wise
On Sat, 2016-06-11 at 16:31 +0530, Satyam Zode wrote: > Please find an attached patch which enables argument completion for > diffoscope. Looking forward to review and feedback. Thanks for the patch. > +++ b/debian/control > @@ -20,6 +20,7 @@ Build-Depends: > + python3-argcomplete, I think you

Re: [Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-11 Thread Satyam Zode
Hi, all ! Paul Wise : > > Package: diffoscope > Severity: wishlist > Tags: newcomer > > Please add argument completion. Using the Python 3 argcomplete module > makes this relatively simple. This project can be used as an example: > > https://anonscm.debian.org/cgit/collab-maint/check-all-the-thin

[Reproducible-builds] Bug#826711: diffoscope: please add argument completion

2016-06-08 Thread Paul Wise
Package: diffoscope Severity: wishlist Tags: newcomer Please add argument completion. Using the Python 3 argcomplete module makes this relatively simple. This project can be used as an example: https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git/ -- bye, pabs https://wiki.deb