Bug#866120: diffoscope: please add an xml comparator

Hi Juliana, > Just found out what was going wrong. > > XMLFile returns an array with the Difference object, while the > previous TextFile class doesn't. So test_apk was looking for a > unified_diff in the wrong place. Neat — looking forward to your patch! In fact, can you commit it directly? :)

Bug#866120: diffoscope: please add an xml comparator

Hi Mattia, Actually I havent. Looks like minidom is vulnerable to both [billion laughs] and [quadratic blowup]. Should we migrate to defusexml? What you think? (: 2017-07-21 14:22 GMT-03:00 Mattia Rizzolo : > On Fri, Jul 21, 2017 at 10:48:07AM +0100, Chris Lamb wrote: > >

Bug#866120: diffoscope: please add an xml comparator

Hey Chris, Just found out what was going wrong. XMLFile returns an array with the Difference object, while the previous TextFile class doesn't. So test_apk was looking for a unified_diff in the wrong place. This is easily fixed, but I've got a new question. Since XMLFile now returns an array,

Bug#866120: diffoscope: please add an xml comparator

Hey Juliana, > Yes! I would like to work on fixing that. Also, I'll take a look at the > other failed tests and get back at you. (: Any news on this? We'd love to get the tests all passing again :) Regards, -- ,''`. : :' : Chris Lamb, Debian Project Leader `. `'`

Bug#866120: diffoscope: please add an xml comparator

On Fri, Jul 21, 2017 at 10:48:07AM +0100, Chris Lamb wrote: > … And I've now also merged the code into our Git repo. Thanks! Did you both go through https://docs.python.org/3/library/xml.html#xml-vulnerabilities and decided that the standard minidom was safe for our usages? -- regards,

Bug#866120: diffoscope: please add an xml comparator

Hi Juliana, > Hi Chris and Mattia, Yes, it seems like we sent our mails within 59 seconds of each other. Oh; feel free to join our IRC channels (on OFTC, #debian-reproducible & #reproducible-builds) as that is where our automated testsuite prints it's current status. Best wishes, --

Bug#866120: diffoscope: please add an xml comparator

Hi Chris and Mattia, Yes! I would like to work on fixing that. Also, I'll take a look at the other failed tests and get back at you. (: Thank you very much for the feedback! Juliana Em sex, 21 de jul de 2017 11:00, Chris Lamb escreveu: > Hi Juliana, > > > About the

Bug#866120: diffoscope: please add an xml comparator

Hi Juliana, > About the testsuite: Firstly I ran all tests, but some were naturally > failing (like test_debian, I guess) In general we try never to have any failing tests in diffoscope, so none should ever be "naturally" failing. :) > Then I focused on getting to work at least the one test I

Bug#866120: diffoscope: please add an xml comparator

Hi Chris! I see. I'll be more careful with python coding style next time. (: About the testsuite: Firstly I ran all tests, but some were naturally failing (like test_debian, I guess). Then I focused on getting to work at least the one test I was writting, since I don't know much about the

Bug#866120: diffoscope: please add an xml comparator

tags 866120 + pending thanks Chris Lamb wrote: > Woo, thanks! First, am going to merge this into the existing > wishlist bug… … And I've now also merged the code into our Git repo. Thanks! I did make some changes after committing which might be useful to know/understand for next time. First

Bug#866120: diffoscope: please add an xml comparator

Source: diffoscope Version: 83 Severity: wishlist Currently scribus treats XML files as regular text files. I believe it could be better by trying to understand them, like it's done for .json, and provide a more smart output. -- regards, Mattia Rizzolo GPG Key: 66AE