Bug#869154: [PATCH] comparators.xml: added new XML comparator

Source: diffoscope Version: 84 Severity: wishlist Added XML Comparator as requested in our wishlist. This patch closes #866120 and shows XML some love. Signed-off-by: Juliana Rodrigues <juliana.o...@gmail.com> --- diffoscope/comparators/__init__.py | 1 + diffoscope/comparators/

Bug#866120: diffoscope: please add an xml comparator

Hi Chris! I see. I'll be more careful with python coding style next time. (: About the testsuite: Firstly I ran all tests, but some were naturally failing (like test_debian, I guess). Then I focused on getting to work at least the one test I was writting, since I don't know much about the

Bug#866120: diffoscope: please add an xml comparator

Hi Chris and Mattia, Yes! I would like to work on fixing that. Also, I'll take a look at the other failed tests and get back at you. (: Thank you very much for the feedback! Juliana Em sex, 21 de jul de 2017 11:00, Chris Lamb escreveu: > Hi Juliana, > > > About the

Bug#866120: diffoscope: please add an xml comparator

Hi Mattia, Actually I havent. Looks like minidom is vulnerable to both [billion laughs] and [quadratic blowup]. Should we migrate to defusexml? What you think? (: 2017-07-21 14:22 GMT-03:00 Mattia Rizzolo : > On Fri, Jul 21, 2017 at 10:48:07AM +0100, Chris Lamb wrote: > >

Bug#866120: diffoscope: please add an xml comparator

Hey Chris, Just found out what was going wrong. XMLFile returns an array with the Difference object, while the previous TextFile class doesn't. So test_apk was looking for a unified_diff in the wrong place. This is easily fixed, but I've got a new question. Since XMLFile now returns an array,