Re: [Reproducible-builds] [RFC PATCH] Makefile: search for GNU date

2015-08-29 Thread Marek Vasut
On Thursday, August 27, 2015 at 10:13:49 AM, Andreas Bießmann wrote:
 The SOURCE_DATE_EPOCH mechanism for reproducible builds requires the GNU
 variant of date.

Why does it require the GNU date ?

 Respect this and search it, error on missing GNU date.

Wouldn't it make more sense to fix the code to NOT depend on GNU extensions ?

 Signed-off-by: Andreas Bießmann andreas.de...@googlemail.com

[...]

Best regards,
Marek Vasut

___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds


Re: [Reproducible-builds] [RFC PATCH] Makefile: search for GNU date

2015-08-29 Thread Marek Vasut
On Thursday, August 27, 2015 at 11:01:19 AM, Andreas Bießmann wrote:
 Hi Marek,

Hi!

 On 08/27/2015 10:28 AM, Marek Vasut wrote:
  On Thursday, August 27, 2015 at 10:13:49 AM, Andreas Bießmann wrote:
  The SOURCE_DATE_EPOCH mechanism for reproducible builds requires the GNU
  variant of date.
  
  Why does it require the GNU date ?
 
 Cause of the -d switch. It is used in GNU date variants to set the time
 to print the string from. On the other hand *BSD variants use it to set
 the DST flag.

This sort of stuff should be in the commit message :)

  Respect this and search it, error on missing GNU date.
  
  Wouldn't it make more sense to fix the code to NOT depend on GNU
  extensions ?
 
 That would be great, but so we need to check for the tool and use the
 right switches depending on that.
 I think forcing the user to provide the right tool here is Ok.

I think we don't have a better option here anyway, right ? Maybe try
checking uname ? But you can have linux with bsd userspace ... and
probably BSD with GNU userspace, meh.

Best regards,
Marek Vasut

___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds