Control: tag -1 pending
On Wed, Oct 26, 2016 at 10:52:29AM +, Daniel Shahaf wrote:
> Mattia Rizzolo wrote on Sun, Oct 23, 2016 at 23:21:53 +:
> > Though I'd really prefer to see some tests for this before applying it;
>
> Attached.
>
> The code change is unchanged from the previous
Processing control commands:
> tag -1 pending
Bug #839538 [src:diffoscope] diffoscope: json: detect order-only differences
Added tag(s) pending.
--
839538: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=839538
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Mattia Rizzolo wrote on Sun, Oct 23, 2016 at 23:21:53 +:
> Though I'd really prefer to see some tests for this before applying it;
Attached.
The code change is unchanged from the previous patch.
Test test works; I'm not sure whether is idiomatic pytest, though.
Cheers
Daniel
[[[
diff
Mattia Rizzolo wrote on Sun, Oct 23, 2016 at 23:21:53 +:
> On Sat, Oct 01, 2016 at 06:06:38PM +, Daniel Shahaf wrote:
> > It passes the existing test suite, but I haven't yet tried writing
> > a unit test for this.
>
> It looks cool to me.
Thanks.
> Though I'd really prefer to see some
On Sun, Oct 02, 2016 at 04:55:37PM +, Daniel Shahaf wrote:
> HW42 wrote on Sat, Oct 01, 2016 at 17:39:00 +:
> > Daniel Shahaf:
> > > It would be better to report "json files are equal up to order of
> > > elements in an object (= hash, dictionary, associative array)", and to
> > > print
On Sat, Oct 01, 2016 at 06:06:38PM +, Daniel Shahaf wrote:
> It passes the existing test suite, but I haven't yet tried writing
> a unit test for this.
It looks cool to me.
Though I'd really prefer to see some tests for this before applying it;
do you think you can work on some?
--
regards,
Daniel Shahaf:
> It would be better to report "json files are equal up to order of
> elements in an object (= hash, dictionary, associative array)", and to
> print the difference in a more readable way than a hex dump. (For
> example, a linewise diff of pretty-printed json.)
While at it, it
Processing control commands:
> tags -1 patch
Bug #839538 [src:diffoscope] diffoscope: json: detect order-only differences
Added tag(s) patch.
--
839538: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=839538
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
