Here's a patch to prevent the traceback. It just detects the general
situation (comparing a directory with something else) and bails with a
more helpful message when they're incompatible.
I checked what diff does, and it does something slightly more nuanced:
if you compare directory D against
Processing commands for cont...@bugs.debian.org:
> tags 835641 +patch
Bug #835641 [diffoscope] diffoscope: traceback when comparing dangling symlink
to directory
Added tag(s) patch.
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
835641:
Source: diffoscope
Version: git as of 011987f
Severity: minor
Tags: upstream
On jessie, test_openssh_pub_key.test_diff fails like this:
=== FAILURES ===
__ test_diff
Holger Levsen wrote:
> > The --profile flag is new in diffoscope 65.
>
> yes, and? it's not being used on t.r-b.o…?!!
What is "it" here? If referring to the flag then yes, it's not being
used - that's the intention of this patch set. If it refers to diffoscope
>= 65 then I am not actually sure
On Sun, Dec 25, 2016 at 05:44:50PM +, Chris Lamb wrote:
> Chris Lamb wrote:
>
> > Reproducible debian: Log diffoscope profiling info if available.
>
> Updated patch attached now that diffoscope 65 is in unstable.
>
> (From an IRC conversation I am working under the assumption that
On Mon, Dec 26, 2016 at 12:30:06PM +, Chris Lamb wrote:
> The previous patch I mailed did a version check before injecting this flag so
> it did not break.
On Mon, Dec 26, 2016 at 12:17:27PM +, Daniel Shahaf wrote:
> The --profile flag is new in diffoscope 65.
yes, and? it's not being
Hey, thanks for this!
A question - do you consider #836786 closed by this patch, or is there still
more work to be done on it?
(#836786 - diffoscope: Differences between long lines are missing in HTML
format")
X
Emanuel Bronshtein:
> Sure, here is the test:
>
Source: diffoscope
Severity: normal
Dear Maintainer,
W3 validator report several errors/warnings for diffoscope output, for example:
https://validator.w3.org/nu/?doc=https://tests.reproducible-builds.org/debian/dbd/unstable/amd64/monotone_1.1-9.diffoscope.html
js-beautify is used as JavaScript code beautifier from commit:
https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?=002f05444cc0a238d8e617b31dabef4111b4ecd2
which fix the above examples, but there are more results that have partial
results in lines, such as:
in attribute inside
No, it's a partial fix, see my replay in #836786
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836786#10
-Emanuel
Sent: Monday, December 26, 2016 at 8:20 PM
From: "Ximin Luo"
To: "Emanuel Bronshtein" , "Mattia Rizzolo"
Cc:
Ximin Luo:
> https://reproducible.alioth.debian.org/blog/drafts/87/
>
> Late one this week, forgot about it because of the summit.
>
^ um, ignore that, oversight in copy-paste. ^_^;;;
X
--
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://reproducible.alioth.debian.org/blog/drafts/87/
Late one this week, forgot about it because of the summit.
Feel free to commit fixes directly to drafts/87.mdwn in
https://anonscm.debian.org/git/reproducible/blog.git/
I will publish this in 48 hours, to give some time for the holiday
On Sat, 24 Dec 2016, Ximin Luo wrote:
> For all you people that already have single-CPU KVM VMs set up, can you
> please try to reduce your test cases that still reproduce the bug?
>
> For example, can you still reproduce it with `debian/rules clean build`? What
> about `python3 -m pytest`?
Holger Levsen wrote on Mon, Dec 26, 2016 at 12:07:11 +:
> On Sun, Dec 25, 2016 at 05:44:50PM +, Chris Lamb wrote:
> > Chris Lamb wrote:
> >
> > > Reproducible debian: Log diffoscope profiling info if available.
> >
> > Updated patch attached now that diffoscope 65 is in unstable.
> >
>
Holger Levsen wrote:
> > Updated patch attached now that diffoscope 65 is in unstable.
> >
> > (From an IRC conversation I am working under the assumption that diffoscope
> > from unstable is used even when comparing build results from testing.)
>
> while this is true (on t.r-b.o) I wonder why
tags 849391 + pending
thanks
Thanks for the report. I've fixed this in:
https://anonscm.debian.org/git/reproducible/strip-nondeterminism.git/commit/?h=debian=81d06905acb35b7a8681ff2e9bf29087cae5414e
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org /
Processing commands for cont...@bugs.debian.org:
> tags 849391 + pending
Bug #849391 [src:strip-nondeterminism] strip-nondeterminism: autopkgtest
failures
Added tag(s) pending.
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
849391:
Source: diffoscope
Severity: wishlist
Dear Maintainer,
1. Better handle .dex files
currently enjarify tool is used in order to transform .dex file to .jar, this
tool can fail (as probably any decompiler) for example:
Command `enjarify -o /tmp/tmpdp3fttiq_diffoscope/classes.jar
Source: diffoscope
Severity: normal
Dear Maintainer,
readelf/objdump return errors/warnings and sometimes fails, examples:
1. objdump: can't disassemble for architecture UNKNOWN!
1.1 objdump: section '.plt' mentioned in a -j option, but not found in
any input file
source: strip-nondeterminism
version: 0.029-1
severity: important
from
https://ci.debian.net/data/packages/unstable/amd64/s/strip-nondeterminism/20161226_100743.autopkgtest.log.gz
8<--
1..2
not ok 1 - bin/dh_strip_nondeterminism --help returns 127
# Failed test
On Mon, Dec 26, 2016 at 03:26:54PM +, Chris Lamb wrote:
> > I still wonder :) Do you plan to use --profile on t.r-b.o or?
> Yes; that's the entire point of this thread! :p
I see, thanks.
--
cheers,
Holger
signature.asc
Description: Digital signature
Source: diffoscope
Severity: wishlist
Dear Maintainer,
1. compare image metadata (EXIF / XMP / size / etc..) for various images
formats, can be done with following tools:
exiftool - http://www.sno.phy.queensu.ca/~phil/exiftool/ -
https://packages.debian.org/sid/libimage-exiftool-perl
Source: diffoscope
Severity: wishlist
Dear Maintainer,
Currently javap is used for .class files, for example:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/arm64/diffoscope-results/velocity.html
On Mon, Dec 26, 2016 at 01:01:34PM +, Chris Lamb wrote:
> Holger Levsen wrote:
>
> > > The --profile flag is new in diffoscope 65.
> >
> > yes, and? it's not being used on t.r-b.o…?!!
>
> What is "it" here? If referring to the flag then yes, it's not being
> used - that's the intention of
Holger Levsen wrote:
> I still wonder :) Do you plan to use --profile on t.r-b.o or?
Yes; that's the entire point of this thread! :p
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
Santiago Vila wrote:
> If I do "python3 -m pytest" afterwards this is what it's shown:
[…]
> Note: This is still diffoscope_63 in stretch, not sure if I should
> better try the version in unstable and forget completely about this
> version.
Please do so; the icc tests were fixed later and there
On Mon, Dec 26, 2016 at 07:19:17PM +0200, Emanuel Bronshtein wrote:
> 2. Support parsing android resources not in APK file
>
> Support for some Android files (such as: AndroidManifest.xml &
> resources.arsc) was added in:
>
On Mon, Dec 26, 2016 at 07:37:55PM +, Chris Lamb wrote:
> Santiago Vila wrote:
>
> > If I do "python3 -m pytest" afterwards this is what it's shown:
> […]
> > Note: This is still diffoscope_63 in stretch, not sure if I should
> > better try the version in unstable and forget completely about
Hi.
I have built version 66 one hundred times in unstable.
The builds were made on 19 different autobuilders.
The number of failed builds has been zero.
(Previously it failed 10% of the time).
If you do not remember what kind of change may have fixed this,
then there must be some broken
I should add, I also had failures with diffoscope version 64 and older, but
no failures on newer versions. It seems likely that
one of the changes fixed this bug as a side effect, but I cannot yet tell
which one.
___
Reproducible-builds mailing list
30 matches
Mail list logo