Package: debhelper
Version: 9.20141222
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain fileordering

Hi!

While working on the “reproducible builds” effort [1], we have noticed
that some packages failed to build reproducibly because the order of
icons listed in dh_icons output varies depending on the order of files
on the filesystem.

The attached patch modifies dh_icons to sort the icon list, resulting
in a stable order in postinst and postrm files. This allows more
packages to build reproducibly.

 [1]: https://wiki.debian.org/ReproducibleBuilds

-- 
Lunar                                .''`. 
lu...@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   
From f621ee23d9f304bd0d36727d35afcae90ff357ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Bobbio?= <lu...@debian.org>
Date: Sun, 28 Dec 2014 16:21:46 +0000
Subject: [PATCH 2/3] dh_icons: output icon list in a stable order

We now sort the icon list in order to guarantee a stable output.
This was preventing some packages to build reproducibly.
---
 dh_icons | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dh_icons b/dh_icons
index 916f188..b506f1f 100755
--- a/dh_icons
+++ b/dh_icons
@@ -61,7 +61,7 @@ foreach my $package (@{$dh{DOPACKAGES}}) {
 			push @dirlist, "$baseicondir/$subdir" if $needs_cache;
 		}
 		if (@dirlist and ! $dh{NOSCRIPTS}) {
-			my $list=join(" ", @dirlist);
+			my $list=join(" ", sort @dirlist);
 			autoscript($package,"postinst","postinst-icons","s%#DIRLIST#%$list%");
 			autoscript($package,"postrm","postrm-icons","s%#DIRLIST#%$list%");
 		}
-- 
2.1.3

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to