Re: [Reproducible-builds] Bug#774869: libmodule-build-perl: please output data in stable order

2015-01-08 Thread gregor herrmann 
On Thu, 08 Jan 2015 16:30:27 +0100, Jérémy Bobbio wrote:

> Jonas Smedegaard:
> > Seems you missed the attachment, though...
> Oops. :)
> It's also available from
> git://git.debian.org/reproducible/libmodule-build-perl.git

Module::Build is both in libmodule-build-perl and in perl-modules, so
you probably want the more or less same patch there as well.
 

Cheers,
gregor


-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Willi Resetarits + Stubnblues: noan wia mia


signature.asc
Description: Digital Signature
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Re: [Reproducible-builds] Bug#774869: libmodule-build-perl: please output data in stable order

2015-01-08 Thread Jérémy Bobbio 
Jonas Smedegaard:
> Seems you missed the attachment, though...

Oops. :)

It's also available from
git://git.debian.org/reproducible/libmodule-build-perl.git

-- 
Lunar.''`. 
lu...@debian.org: :Ⓐ  :  # apt-get install anarchism
`. `'` 
  `-   
diff -Nru libmodule-build-perl-0.421000/debian/changelog libmodule-build-perl-0.421000/debian/changelog
--- libmodule-build-perl-0.421000/debian/changelog	2014-09-19 11:10:35.0 +0200
+++ libmodule-build-perl-0.421000/debian/changelog	2015-01-08 15:53:11.0 +0100
@@ -1,3 +1,9 @@
+libmodule-build-perl (0.421000-2.0~reproducible1) UNRELEASED; urgency=low
+
+  * Add a patch to output data in stable order to make builds reproducible.
+
+ -- Jérémy Bobbio   Thu, 08 Jan 2015 15:52:19 +0100
+
 libmodule-build-perl (0.421000-2) unstable; urgency=medium
 
   [ gregor herrmann ]
diff -Nru libmodule-build-perl-0.421000/debian/patches/output-data-in-stable-order.patch libmodule-build-perl-0.421000/debian/patches/output-data-in-stable-order.patch
--- libmodule-build-perl-0.421000/debian/patches/output-data-in-stable-order.patch	1970-01-01 01:00:00.0 +0100
+++ libmodule-build-perl-0.421000/debian/patches/output-data-in-stable-order.patch	2015-01-08 15:53:11.0 +0100
@@ -0,0 +1,16 @@
+Description: output data in a stable order
+ In order to make builds reproducible, we sort keys when dumping
+ data.
+Author: Jérémy Bobbio 
+
+--- libmodule-build-perl-0.421000.orig/lib/Module/Build/Dumper.pm
 libmodule-build-perl-0.421000/lib/Module/Build/Dumper.pm
+@@ -12,7 +12,7 @@ use Data::Dumper;
+ sub _data_dump {
+   my ($self, $data) = @_;
+   return ("do{ my "
+-	  . Data::Dumper->new([$data],['x'])->Purity(1)->Terse(0)->Dump()
++	  . Data::Dumper->new([$data],['x'])->Purity(1)->Terse(0)->Sortkeys(1)->Dump()
+ 	  . '$x; }')
+ }
+ 
diff -Nru libmodule-build-perl-0.421000/debian/patches/series libmodule-build-perl-0.421000/debian/patches/series
--- libmodule-build-perl-0.421000/debian/patches/series	2014-09-19 11:10:35.0 +0200
+++ libmodule-build-perl-0.421000/debian/patches/series	2015-01-08 15:53:11.0 +0100
@@ -1,2 +1,3 @@
 man-ext
 0001-Allow-loading-from-system-path-when-running-under-au.patch
+output-data-in-stable-order.patch


signature.asc
Description: Digital signature
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#774869: libmodule-build-perl: please output data in stable order

2015-01-08 Thread Jérémy Bobbio 
Source: libmodule-build-perl
Version: 0.421000-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain randomness

Hi!

While working on the “reproducible builds” effort [1], we have noticed
that libmodule-build-perl could not be built reproducibly. It also
prevents other packages to build reproducibly.

The issue is that it outputs data with keys in a different order at each
run. The attached patch will tell Data::Dumper to sort the keys,
resulting in a stable output.

 [1]: https://wiki.debian.org/ReproducibleBuilds

-- 
Lunar.''`. 
lu...@debian.org: :Ⓐ  :  # apt-get install anarchism
`. `'` 
  `-   


signature.asc
Description: Digital signature
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds