Source: openarena Version: 0.8.8-12 Severity: wishlist Tags: patch User: reproducible-builds@lists.alioth.debian.org Usertags: timestamps X-Debbugs-CC: reproducible-builds@lists.alioth.debian.org
Hi! You recently added a patch to openarena which replaces __DATE__ with a deterministic value (date from debian/changelog), which is awesome! :) Unfortunately the build isn't yet completely reproducible [1]. Telling date to use a constant timezone (e.g. UTC) is also necessary, or the date could vary depending on "where" it is build. And the result of the %b format value is also locale dependent, so fixing the locale is also required. You can find these changes in the attached patch. And btw ioquake3 has the exactly same problem. You might want to apply the patch there too. Thanks! Regards, Reiner [1]: https://reproducible.debian.net/rb-pkg/unstable/amd64/openarena
diff --git a/debian/rules b/debian/rules index 8715ad2..fc0917e 100755 --- a/debian/rules +++ b/debian/rules @@ -8,7 +8,7 @@ Q3PLATFORM := $(shell /usr/share/ioquake3/q3arch platform HOST) Q3COMPILE_ARCH := $(shell /usr/share/ioquake3/q3arch arch BUILD) Q3COMPILE_PLATFORM := $(shell /usr/share/ioquake3/q3arch platform BUILD) distro := $(shell lsb_release -is) -PRODUCT_DATE := $(shell date --date="`dpkg-parsechangelog -SDate`" "+%b %_d %Y") +PRODUCT_DATE := $(shell LC_ALL=C date --utc --date="`dpkg-parsechangelog -SDate`" "+%b %_d %Y") # the Q3 engine's build system doesn't respect CPPFLAGS, so put them in CFLAGS CFLAGS += $(CPPFLAGS) -fsigned-char
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
