Source: wheel Version: 0.24.0-3 Severity: wishlist Tags: patch User: reproducible-builds@lists.alioth.debian.org Usertags: timestamps toolchain X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org
Hi! Thanks for applying the reproducibility patch in one of the last uploads! :) We found another small issue about reproducibility of whl files (see [1]). The timestamps still vary depending on the configured timezone. The fix would be to store them in UTC like in the attached patch. Regards, Reiner [1]: https://reproducible.debian.net/rb-pkg/unstable/amd64/python-setuptools.html
diff --git a/debian/patches/reproducible-whls.diff b/debian/patches/reproducible-whls.diff index 18c0372..3675e3f 100644 --- a/debian/patches/reproducible-whls.diff +++ b/debian/patches/reproducible-whls.diff @@ -30,7 +30,7 @@ Author: Barry Warsaw <ba...@debian.org> + if timestamp is None: + date_time = None + else: -+ date_time = time.localtime(int(timestamp))[0:6] ++ date_time = time.gmtime(int(timestamp))[0:6] + # XXX support bz2, xz when available zip = zipfile.ZipFile(open(zip_filename, "wb+"), "w", @@ -44,7 +44,7 @@ Author: Barry Warsaw <ba...@debian.org> + def writefile(path, date_time): + if date_time is None: + st = os.stat(path) -+ mtime = time.localtime(st.st_mtime) ++ mtime = time.gmtime(st.st_mtime) + date_time = mtime[0:6] + zinfo = zipfile.ZipInfo(path, date_time) + with open(path, 'rb') as fp:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds