[Reproducible-builds] Bug#808002: Bug#808002: diffoscope: Add support for Mozilla-optimized ZIPs
Control: tag -1 + pending Mike Hommey: > On Tue, Dec 15, 2015 at 04:31:46PM +0100, Jérémy Bobbio wrote: > > Mike Hommey: > > > It would be useful for diffoscope to output differences in omni.ja files > > > as > > > for other Zip files, instead of ending up with a diff of an hexdump. > > > > > > The attached patch implements a minimal support for this. It however > > > doesn't > > > look at the difference in the `preload` value. > > > > Great! I think it's fine to just skip the preload value. It will show up > > in the fallback binary comparison if that's the only remaining difference. > > > > I was going to merge this, but actually I have to ask: would you be kind > > enough to amend the test suite as well? > > Attached. Awesome! Applied. :) -- Lunar.''`. lu...@debian.org: :Ⓐ : # apt-get install anarchism `. `'` `- signature.asc Description: Digital signature ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
[Reproducible-builds] Bug#808002: Bug#808002: diffoscope: Add support for Mozilla-optimized ZIPs
Mike Hommey: > It would be useful for diffoscope to output differences in omni.ja files as > for other Zip files, instead of ending up with a diff of an hexdump. > > The attached patch implements a minimal support for this. It however doesn't > look at the difference in the `preload` value. Great! I think it's fine to just skip the preload value. It will show up in the fallback binary comparison if that's the only remaining difference. I was going to merge this, but actually I have to ask: would you be kind enough to amend the test suite as well? Thanks! -- Lunar.''`. lu...@debian.org: :Ⓐ : # apt-get install anarchism `. `'` `- signature.asc Description: Digital signature ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
