Source: milkytracker
Version: 0.90.85+dfsg-2.2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that milkytracker could not be built reproducibly.
The Makefiles used to build milkyplay uses globs to list the source
files. Depending on the locale they are sorted differently.

The attached patch sorts the list of source files.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/milkyplay/Makefile b/debian/milkyplay/Makefile
index eadd81a..ef3dfab 100644
--- a/debian/milkyplay/Makefile
+++ b/debian/milkyplay/Makefile
@@ -1,5 +1,7 @@
+SOURCES = $(sort $(wildcard milkyplay.cpp ../../src/milkyplay/*.cpp ../../src/milkyplay/drivers/sdl/*.cpp))
+
 all:
-	g++ milkyplay.cpp ../../src/milkyplay/*.cpp ../../src/milkyplay/drivers/sdl/*.cpp -I../../src/milkyplay/drivers/sdl/ -I../../src/milkyplay/ -L../../src/milkyplay/drivers/sdl/ -L../../src/milkyplay/ `sdl-config --cflags --libs` -o milkyplay
+	g++ $(SOURCES) -I../../src/milkyplay/drivers/sdl/ -I../../src/milkyplay/ -L../../src/milkyplay/drivers/sdl/ -L../../src/milkyplay/ `sdl-config --cflags --libs` -o milkyplay
 
 clean:
 	-rm milkyplay `find "../../src/milkyplay" -name "*.o"`
_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to