Source: brainparty
Version: 0.61+dfsg-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that brainparty could not be built reproducibly.
The list of object files is not sorted, which causes a non-deterministic
linking order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible-build.patch b/debian/patches/reproducible-build.patch
new file mode 100644
index 0000000..146d61c
--- /dev/null
+++ b/debian/patches/reproducible-build.patch
@@ -0,0 +1,12 @@
+Author: Reiner Herrmann <rei...@reiner-h.de>
+Description: Sort object files for deterministic linking order
+
+--- a/Makefile
++++ b/Makefile
+@@ -1,5 +1,5 @@
+ MACHINE= $(shell uname -s)
+-OBJFILES := $(patsubst %.cpp,%.o,$(wildcard *.cpp))
++OBJFILES := $(patsubst %.cpp,%.o,$(sort $(wildcard *.cpp)))
+ 
+ ifeq ($(MACHINE),Darwin)
+ 	INCLUDES = -I/Library/Frameworks/SDL.framework/Headers -I/Library/Frameworks/SDL_image.framework/Headers -I/Library/Frameworks/SDL_mixer.framework/Headers -I/Library/Frameworks/SDL_ttf.framework/Headers -I/System/Library/Frameworks/OpenGL.framework/Headers
diff --git a/debian/patches/series b/debian/patches/series
index d70055e..3075f32 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -4,3 +4,4 @@ make.patch
 unbundle-ttf.patch
 disable-fistrun-prompt.patch
 fix-FTBFS-with-GCC-4.9.patch
+reproducible-build.patch

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to