Re: [Reproducible-builds] Bug#828636: libembperl-perl: please make the build reproducible

2016-06-26 Thread Reiner Herrmann
On Sun, Jun 26, 2016 at 05:07:54PM +0200, Axel Beckert wrote:
> I currently fail to see why this can catch Embperl::Syntax::POD in one
> build, but not in another. IMHO this should happen with every build.
> Will investigate.

It's actually related to the shell...

$ touch aD bD cD dD eD AD BD
$ dash -c "ls *[a-z]D"
aD  bD  cD  dD  eD
$ bash -c "ls *[a-z]D"
aD  AD  bD  BD  cD  dD  eD

With bash POD.3pm also matches *[a-z]D.3pm.


signature.asc
Description: Digital signature
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Re: [Reproducible-builds] Bug#828636: libembperl-perl: please make the build reproducible

2016-06-26 Thread Reiner Herrmann
On Sun, Jun 26, 2016 at 05:07:54PM +0200, Axel Beckert wrote:
> > In one build the manpage Embperl::Syntax::POD.3pm is incorrectly sorted
> > to the German manpages (Embperl::FeaturesD too), because their names end
> > with D.
> 
> Why only in one build? Due to different locale settings? Anyway, if
> there's a way that Embperl::Syntax::POD is installed as
> /usr/share/man/de/man3/Embperl::Syntax::PO.3pm.gz, that's clearly a
> bug and deserves a higher severity than just wishlist.

Why this happens only in one build is also not yet clear to me.

> > As the package provides no German manpages anyway,
> 
> Sorry, but that's wrong:
> 
> → dpkg -L libembperl-perl | egrep man/de/man./
> /usr/share/man/de/man3/Embperl::Features.3pm.gz
> → man /usr/share/man/de/man3/Embperl::Features.3pm.gz
> 
> That's clearly my mother tongue. :-)

Sorry, I assumed Embperl::Features was also misdetected (because the
original file ends with D) and haven't looked into it.

> > -   # move German manpages to usr/share/man/de/man{1,2,3}
> > -   @set -e;\
> > -   for f in $(TMP)/usr/share/man/man3/*[a-z]D.3pm; do \
> > -   f_de=`echo $$f | sed 
> > 's,man\(.\)/\([^/]*\)D\.\([^/]*\)$$,de/man\1/\2.\3,'` ;\
> > -   echo "mv $$f $$f_de" ;\
> > -   mv $$f $$f_de ;\
> > -   done
> 
> I currently fail to see why this can catch Embperl::Syntax::POD in one
> build, but not in another. IMHO this should happen with every build.
> Will investigate.

I'm also not sure, but I can imagine it's related to the locale and
*[a-z] works somewhat differently.


signature.asc
Description: Digital signature
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Re: [Reproducible-builds] Bug#828636: libembperl-perl: please make the build reproducible

2016-06-26 Thread Axel Beckert
Control: tag -1 - patch
Control: severity -1 normal

Hi Reiner,

Reiner Herrmann wrote:
> While working on the "reproducible builds" effort [1], we have noticed
> that libembperl-perl could not be built reproducibly.

Thanks for the examination and the bug report.

> In one build the manpage Embperl::Syntax::POD.3pm is incorrectly sorted
> to the German manpages (Embperl::FeaturesD too), because their names end
> with D.

Why only in one build? Due to different locale settings? Anyway, if
there's a way that Embperl::Syntax::POD is installed as
/usr/share/man/de/man3/Embperl::Syntax::PO.3pm.gz, that's clearly a
bug and deserves a higher severity than just wishlist.

> As the package provides no German manpages anyway,

Sorry, but that's wrong:

→ dpkg -L libembperl-perl | egrep man/de/man./
/usr/share/man/de/man3/Embperl::Features.3pm.gz
→ man /usr/share/man/de/man3/Embperl::Features.3pm.gz

That's clearly my mother tongue. :-)

> I think the part in debian/rules, which moves the manpages can be
> safely removed.

I disagree at least with the reasoning here.

I nevertheless think, that if Embperl::Features.3pm is the only German
man page in the source package, we can remove it from the binary
package without much impact since that's the kind of documentation you
usually read _before_ installing the package, e.g. online on the
upstream website.

> - # move German manpages to usr/share/man/de/man{1,2,3}
> - @set -e;\
> - for f in $(TMP)/usr/share/man/man3/*[a-z]D.3pm; do \
> - f_de=`echo $$f | sed 
> 's,man\(.\)/\([^/]*\)D\.\([^/]*\)$$,de/man\1/\2.\3,'` ;\
> - echo "mv $$f $$f_de" ;\
> - mv $$f $$f_de ;\
> - done

I currently fail to see why this can catch Embperl::Syntax::POD in one
build, but not in another. IMHO this should happen with every build.
Will investigate.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

[Reproducible-builds] Bug#828636: libembperl-perl: please make the build reproducible

2016-06-26 Thread Reiner Herrmann
Source: libembperl-perl
Version: 2.5.0-6
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that libembperl-perl could not be built reproducibly.
In one build the manpage Embperl::Syntax::POD.3pm is incorrectly sorted
to the German manpages (Embperl::FeaturesD too), because their names end
with D.
As the package provides no German manpages anyway, I think the part in
debian/rules, which moves the manpages can be safely removed.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/rules b/debian/rules
index f643b0b..ab91682 100755
--- a/debian/rules
+++ b/debian/rules
@@ -27,14 +27,6 @@ override_dh_auto_install: $(POD2TEXT)
 	# install by default
 	install -m 755 *cgi.pl debian/libembperl-perl/usr/lib/cgi-bin/
 
-	# move German manpages to usr/share/man/de/man{1,2,3}
-	@set -e;\
-	for f in $(TMP)/usr/share/man/man3/*[a-z]D.3pm; do \
-	f_de=`echo $$f | sed 's,man\(.\)/\([^/]*\)D\.\([^/]*\)$$,de/man\1/\2.\3,'` ;\
-	echo "mv $$f $$f_de" ;\
-	mv $$f $$f_de ;\
-	done
-
 	# ship Apache config in mods-available
 	sed -e 's,@ARCHLIB@,$(ARCHLIB),g' debian/zembperl.load.in > debian/zembperl.load
 	install -m 644 debian/zembperl.conf debian/zembperl.load \
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds