Re: [Reproducible-builds] [Reproducible-commits] [misc] 01/01: Move timezone setting from rebuild.sh to pbuilderrc.build
On Sat, Feb 20, 2016 at 11:06 AM, Jérémy Bobbio wrote: > Hi! > >> commit 420424b096c254aa5610b479fb1746e1a7bd13cb >> Author: Esa Peuha >> Date: Sat Feb 20 09:50:46 2016 +0200 >> >> Move timezone setting from rebuild.sh to pbuilderrc.build >> --- >> prebuilder/pbuilderrc.build | 1 + >> prebuilder/rebuild.sh | 1 - >> 2 files changed, 1 insertion(+), 1 deletion(-) > > Why is this needed? Clarity and consistency. When I was trying to understand how rebuild.sh worked, I found it confusing that the timezone for the first build was specified directly on the command line, while the timezone for the second build was in pbuilderrc.rebuild with the locale settings. Since the first build is using pbuilderrc.build now because of CCACHEDIR, I think it is the right place to set TZ as well. ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] [Reproducible-commits] [misc] 01/01: Move timezone setting from rebuild.sh to pbuilderrc.build
Hi! > commit 420424b096c254aa5610b479fb1746e1a7bd13cb > Author: Esa Peuha > Date: Sat Feb 20 09:50:46 2016 +0200 > > Move timezone setting from rebuild.sh to pbuilderrc.build > --- > prebuilder/pbuilderrc.build | 1 + > prebuilder/rebuild.sh | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) Why is this needed? In the future please make sure that the commit message explains why a change is required. See “Documenting your changes” in https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches and “Answer the following questions” in https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=HEAD#l521 -- Lunar.''`. lu...@debian.org: :Ⓐ : # apt-get install anarchism `. `'` `- signature.asc Description: Digital signature ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
