Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
Ok, Chris said, and I agree, that in general we should not submit bugs without patches. What should we do with this bug, then? Should we leave it closed even if it's apparently not fixed?: https://reproducible.debian.net/dbdtxt/unstable/amd64/websocket-client_0.18.0-2.debbindiff.txt [ Note: I'm intentionally not Cc:ing the bug address ]. Thanks. ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
Hi Santiago, On Samstag, 17. Oktober 2015, Santiago Vila wrote: > Ok, Chris said, and I agree, that in general we should not submit bugs > without patches. +1 :) > What should we do with this bug, then? Should we leave it closed even > if it's apparently not fixed?: no, we should also not hide problems, so if there is a bug we know about and don't have time to write a patch, it's totally ok to open it "anyway". Best if you come up with a patch later, but… that's _best_ and not required. Though we do try to be this nice! :) cheers, Holger signature.asc Description: This is a digitally signed message part. ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
On Sat, Oct 17, 2015 at 02:36:54PM +0100, Chris Lamb wrote: > > What should we do with this bug, then? Should we leave it closed even > > if it's apparently not fixed?: > > I am unclear why this requires any special treatment or private > discussion. Note: I do not consider this list to be private. It's just that I didn't want to bother the maintainer with this little discussion. > Please re-open the bug with the correspending "found" header as if > it were any other issue in Debian that was not actually resolved. > :) Done. ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
> What should we do with this bug, then? Should we leave it closed even > if it's apparently not fixed?: I am unclear why this requires any special treatment or private discussion. Please re-open the bug with the correspending "found" header as if it were any other issue in Debian that was not actually resolved. :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
Hi. Is this really fixed in python3-defaults 3.4.3-7? There is at least one package still showing the error: https://reproducible.debian.net/rb-pkg/unstable/amd64/lttnganalyses.html and the buildinfo file says "python3 (= 3.4.3-7)". ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
Hi Scott, > I've fixed this as described above and uploaded to experimental. Tested it here and it works for me. Thanks, Scott. In case it saves someone a couple of moments looking it up, this appears to be the pertinent change: https://alioth.debian.org/scm/loggerhead/pkg-python/python3-defaults-debian/revision/331#debian/py3versions.py Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
Hi Scott, > I've fixed this as described above and uploaded to experimental. Tested it here and it works for me. Thanks, Scott. In case it saves someone a couple of moments looking it up, this appears to be the pertinent change: https://alioth.debian.org/scm/loggerhead/pkg-python/python3-defaults-debian/revision/331#debian/py3versions.py Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
On Friday, October 09, 2015 09:49:21 PM Scott Kitterman wrote: > On Friday, October 09, 2015 09:46:48 PM Chris Lamb wrote: > > retitle 801376 pyversions emits requested versions in non-determinstic > > order > > reassign 801376 python3-defaults 3.4.3-6 > > tags 801376 + patch > > thanks > > > > Chris Lamb wrote: > > > > dh-python generates a Depends line which depends on the locale > > > > setting > > > > > > Alas this is not correct; I can reproduce without varying the locale. > > > > Patch attached (NB. in python3-defaults..) > > Thanks for the patch. I think it's not quite what we want though. While > this will make things reproducible in the short run, depending on if the > default is the lower or higher version when there is more than one > supported version, I think the result will be non-deterministic. > > Based on the behavior seen in dh-python, I think we want the default version > last. So think that now we want: > > 3.5 3.4 > > Once 3.5 is default we'd want > > 3.4 3.5 > > The we'd drop 3.4 and get: > > 3.5 > > Someday was add 3.6 (as non-default) and start the process over: > > 3.6 3.5 > > It's getting late here, so I don't intend to work on this today, but I'll > take a shot at it tomorrow (Saturday). > > Scott K I've fixed this as described above and uploaded to experimental. I would appreciate it if you could verify this resolves the problem. If so, I'll upload ot unstable too. Scott K ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [Reproducible-builds] Depends is non-deterministically python3.5 or python3
retitle 801376 pyversions emits requested versions in non-determinstic
order
reassign 801376 python3-defaults 3.4.3-6
tags 801376 + patch
thanks
Chris Lamb wrote:
> > dh-python generates a Depends line which depends on the locale
> > setting
>
> Alas this is not correct; I can reproduce without varying the locale.
Patch attached (NB. in python3-defaults..)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
diff --git a/debian/py3versions.py b/debian/py3versions.py
index 9f15eea..6c35b04 100644
--- a/debian/py3versions.py
+++ b/debian/py3versions.py
@@ -162,6 +162,7 @@ def requested_versions(vstring, version_only=False):
raise ValueError('No python3 versions in version string')
if not versions:
raise ValueError('empty set of versions')
+versions = list(sorted(list))
if version_only:
return versions
else:
___
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
