Re: [diffoscope] [Reproducible-builds] More lazy-loading for diffoscope html output
Chris Lamb: >> Do you have a concrete suggestion? Otherwise I will just turn the >> background light pink, #f99. > > Something like that, although I'm not quite a fan of pink… > > I would definitely increase the padding and — to use a UI/UX term — to > increase the affordance that they are something that may be clicked, I would > be tempted to experiment with styling these somewhat à la rather > than à la . > > This is because the latter subconciously suggests that the browser will > navigate "away", rather than expand inline. > I've commited this. I added some padding, and also now the bg of the entire row will change when you hover over it. I also tried using but it was too hard to get right, so I gave up on that. I kept it at pink but if you want a different colour feel free to change it. X -- GPG: ed25519/56034877E1F87C35 GPG: rsa4096/1318EFAC5FBBDBCE https://github.com/infinity0/pubkeys.git ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [diffoscope] [Reproducible-builds] More lazy-loading for diffoscope html output
> Do you have a concrete suggestion? Otherwise I will just turn the > background light pink, #f99. Something like that, although I'm not quite a fan of pink… I would definitely increase the padding and — to use a UI/UX term — to increase the affordance that they are something that may be clicked, I would be tempted to experiment with styling these somewhat à la rather than à la . This is because the latter subconciously suggests that the browser will navigate "away", rather than expand inline. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [diffoscope] [Reproducible-builds] More lazy-loading for diffoscope html output
Chris Lamb: > Hi Ximin, > >> https://people.debian.org/~infinity0/res/dfs-demo/index.html > > One quick bit of feedback is that the: > >" ... load diff (3 pieces, truncated) ... " > > links aren't always immediately obvious to my eyes/colour scheme. > > Indeed, I am sure I found find myself wondering where the rest of > differences were. I'm sure some judicial CSS styling would solve this. > Do you have a concrete suggestion? Otherwise I will just turn the background light pink, #f99. X -- GPG: ed25519/56034877E1F87C35 GPG: rsa4096/1318EFAC5FBBDBCE https://github.com/infinity0/pubkeys.git ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [diffoscope] [Reproducible-builds] More lazy-loading for diffoscope html output
Hi Ximin, > https://people.debian.org/~infinity0/res/dfs-demo/index.html One quick bit of feedback is that the: " ... load diff (3 pieces, truncated) ... " links aren't always immediately obvious to my eyes/colour scheme. Indeed, I am sure I found find myself wondering where the rest of differences were. I'm sure some judicial CSS styling would solve this. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: [diffoscope] [Reproducible-builds] More lazy-loading for diffoscope html output
Ximin Luo: > Chris Lamb: >>> https://people.debian.org/~infinity0/res/dfs-demo/ >> >> Like it! >> >> However, hould you object to making it show some — however small — diff on >> page load? I am all behind lazy-loading of further chunks but I am certain >> I will find it annoying to have to click «load diffs» when I did not before. >> >> It makes it much harder to skip over chunks I don't care about, and also >> requires me to switch from keyboard to mouse. >> > > Understood, yeah I agree, I'll fix this before I push. > Updated here: https://people.debian.org/~infinity0/res/dfs-demo/index.html >>> I will push this "soon" unless people complain. :p So please play around >>> with it yourself etc >> >> Can you clarify whether this would change the output behaviour of the >> "--html " or is some other switch required…? >> > > This is just for --html-dir so far. But I have some ideas for merging the > flags which would also affect --html, but hopefully make it easier to think > about. I'll go implement them then it'll be easier for me to try to describe > it. > Flag changes completed and described here: https://anonscm.debian.org/cgit/reproducible/diffoscope.git/commit/?h=better-lazy-loading&id=ebbf88382a0762166f10e3d6cd9489b8ee790113 The TL;DR version is that instead of having --max-diff-block-lines affects single (--html) and child pages, in unpredictable ways --separate-file-diff-size affects parent and child pages, in unpredictable ways we now have --max-diff-block-lines affects single (--html) and parent pages, in the same way --max-diff-block-lines-html-dir affects child pages X -- GPG: ed25519/56034877E1F87C35 GPG: rsa4096/1318EFAC5FBBDBCE https://github.com/infinity0/pubkeys.git ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
