[request-sponsor] Fix for bug 6615447 : r.manifest can use $smf_alive without ever setting it
It doesn't look like the fix for this CR ever got integrated, so I'd like to request a sponsor for myself, with my intended fix being the patch below (or alternatively that the bug just be closed as Not a Bug).. Thanks, Ceri On Wed, Jan 30, 2008 at 10:37:23PM +, Ceri Davies wrote: On Wed, Jan 30, 2008 at 04:35:52PM +0530, Avinash Joshi wrote: Hi. I am working on the bug 6615447. My SCA number is 0S0142 I personally don't see how this is a bug at all, but the preferred idiom for checking uninitialised shell variables is ${var:-default}, so the diff would be something more like: BEGIN --- r.manifest.orig Wed Jan 30 22:33:59 2008 +++ r.manifestWed Jan 30 22:34:25 2008 @@ -49,7 +49,7 @@ SVCPROP=/usr/bin/svcprop while read mfst; do - if [ $smf_alive = yes ]; then + if [ ${smf_alive:-no} = yes ]; then ENTITIES=`$SVCCFG inventory $mfst` for fmri in $ENTITIES; do END Having said that, I don't know if that's true of Sun, but it certainly is where I come from. Ceri -- That must be wonderful! I don't understand it at all. -- Moliere -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available URL: http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20081102/ce51a744/attachment.bin
[request-sponsor] Fix for bug 6615447 : r.manifest can use $smf_alive without ever setting it
Quoth Avinash Joshi on Wed, Jan 30, 2008 at 04:35:52PM +0530: I am working on the bug 6615447. My SCA number is 0S0142 I am attaching the diff file.. Bug ID - 6615447 Synopsis - r.manifest can use $smf_alive without ever setting it Category:Subcategory - utility:smf I'll sponsor you. David
[request-sponsor] Fix for bug 6615447 : r.manifest can use $smf_alive without ever setting it
Hi. I am working on the bug 6615447. My SCA number is 0S0142 I am attaching the diff file.. Bug ID - 6615447 Synopsis - r.manifest can use $smf_alive without ever setting it Category:Subcategory - utility:smf -- Thanks Regards, Avinash Joshi -- next part -- An embedded and charset-unspecified text was scrubbed... Name: 6615447_r.manifest.txt URL: http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080130/6c21f93c/attachment.txt
[request-sponsor] Fix for bug 6615447 : r.manifest can use $smf_alive without ever setting it
On Wed, Jan 30, 2008 at 04:35:52PM +0530, Avinash Joshi wrote: Hi. I am working on the bug 6615447. My SCA number is 0S0142 I personally don't see how this is a bug at all, but the preferred idiom for checking uninitialised shell variables is ${var:-default}, so the diff would be something more like: BEGIN --- r.manifest.orig Wed Jan 30 22:33:59 2008 +++ r.manifest Wed Jan 30 22:34:25 2008 @@ -49,7 +49,7 @@ SVCPROP=/usr/bin/svcprop while read mfst; do - if [ $smf_alive = yes ]; then + if [ ${smf_alive:-no} = yes ]; then ENTITIES=`$SVCCFG inventory $mfst` for fmri in $ENTITIES; do END Having said that, I don't know if that's true of Sun, but it certainly is where I come from. Ceri -- That must be wonderful! I don't understand it at all. -- Moliere -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available URL: http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080130/36aa130e/attachment.bin