[request-sponsor] Sponsor Tasks updated for Mercurial

2008-09-03 Thread Valerie Bubb Fenwick 
Hi James -

The contributor should run his own code review. This is outlined here:
http://opensolaris.org/os/communities/participation/
as well as here:
http://opensolaris.org/os/community/on/crt/sponsor-tasks/

You, as the sponsor, need to help identify the appropriate
reviewers.  You can do this by looking at previous folks
who had modified the code (particularly signficant modifications).

Looking at this bug, I would also say that security-discuss at opensolaris.org
might be a ogod place to find reviewers.

usually a webrev is sufficient for a code review. Many contributors
(internal  external) put a reasonable timer on the review. Obviously,
you still need to get code review comments - so even if the deadline
passes w/out review, it just means you have to try again.

In addition to security folks, I would want to see a kernel person
review as well.

Hope that helps,

Valerie


On Wed, 3 Sep 2008, James.Anderson at sun.com wrote:

 Hi Valerie et al -

 I need guidance on the process we should be following for the
 code reviews.  I am sponsoring CR 6613349 for Jason King.

 Does the requester drive the code review?  Where do they send
 the code for review?  What is the format of the code review? 
 I can ask the requester to send a webrev out for review, but it
 isn't clear which email alias to send it to since the change is in
 common code and not exactly tied to a particular technology area.

 You have mentioned previously that reviewers need not be Sun
 employees.

 I just need to know what to ask the requester to do to get the
 code reviewed per the Sun process.

 thanks,
 -jim


 On 08/21/08 15:29, Valerie Bubb Fenwick wrote:
 Hi Everyone -
 
 We finally have the new best practices for sponsors for
 Mercurial updated here:
 http://opensolaris.org/os/community/on/crt/sponsor-tasks/
 
 There are actually choices for acknowledging the contributor
 now. Please work with the contributor to determine the best
 way of handling this for each particular case.
 
 This other page has recently been updated as well, please
 make sure you check it out, even if you have been a sponsor
 or CRT member for a long time:
 http://opensolaris.org/os/community/on/crt/rti-nits/
 
 Many thanks to Mark Nelson, Rich Lowe, Bonnie Corwin  John Beck
 for their assistance on getting these pages just right.
 
 Thank you,
 
 Valerie, ON CRT Chair

[request-sponsor] Sponsor Tasks updated for Mercurial

2008-09-03 Thread james.ander...@sun.com 
On 09/03/08 17:35, James.Anderson at Sun.COM wrote:

 So far, I have been getting Mercurial change bundles that do not
 compile.  I have to assume the changes have not been tested.   I
 intend to stress to the contributor that they are responsible for driving
 the code review as well as supplying unit test results (which I will
 reproduce prior to putback).


To be fair, the contributor did deliver the latest changes with the 
caveat that
his build environment was not ready yet.   

I had started down the path of making the changes and doing the
testing myself, but I want to follow the documented process.  Hence
my email to clarify the role responsibilities.  Some things weren't clear
to me even after reading the supplied process documentation.

-jim




 ___
 request-sponsor mailing list
 request-sponsor at opensolaris.org
   

-- next part --
An HTML attachment was scrubbed...
URL: 
http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080903/b6518770/attachment.html

[request-sponsor] Sponsor Tasks updated for Mercurial

2008-08-21 Thread Valerie Bubb Fenwick 
Hi Everyone -

We finally have the new best practices for sponsors for
Mercurial updated here:
http://opensolaris.org/os/community/on/crt/sponsor-tasks/

There are actually choices for acknowledging the contributor
now. Please work with the contributor to determine the best
way of handling this for each particular case.

This other page has recently been updated as well, please
make sure you check it out, even if you have been a sponsor
or CRT member for a long time:
http://opensolaris.org/os/community/on/crt/rti-nits/

Many thanks to Mark Nelson, Rich Lowe, Bonnie Corwin  John Beck
for their assistance on getting these pages just right.

Thank you,

Valerie, ON CRT Chair
-- 
Valerie Fenwick, http://blogs.sun.com/bubbva
Solaris Security Technologies,  Developer, Sun Microsystems, Inc.
17 Network Circle, Menlo Park, CA, 94025.